https://bugs.freedesktop.org/show_bug.cgi?id=90898
Bug ID: 90898 Summary: Provide DRM_MODE_FB_DIRTY_MAX_CLIPS in drm_mode.h Product: DRI Version: XOrg git Hardware: x86 (IA32) OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: libdrm Assignee: dri-devel@lists.freedesktop.org Reporter: lampersperger.andreas@heidenhain.de
When calling drmModeDirtyFB on linux, it fails when num_clips are more than DRM_MODE_FB_DIRTY_MAX_CLIPS (value: 256). But there is no way to check this for xf86-video-* drivers, because when including drm_mode.h, you get the drm_mode.h from /usr/include/libdrm/drm_mode.h and not /usr/include/drm/drm_mode.h.
Please add
#define DRM_MODE_FB_DIRTY_MAX_CLIPS 256
to your drm_mode.h, to allow xf86-video-* drivers to check parameters before calling drmModeDirtyFB(...).
https://bugs.freedesktop.org/show_bug.cgi?id=90898
--- Comment #1 from Michel Dänzer michel@daenzer.net --- Can you make a patch and submit it to the dri-devel@lists.freedesktop.org list for review?
https://bugs.freedesktop.org/show_bug.cgi?id=90898
--- Comment #2 from Andreas Lampersperger lampersperger.andreas@heidenhain.de --- Patch was send to dri-devel@lists.freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=90898
Emil Velikov emil.l.velikov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED
--- Comment #3 from Emil Velikov emil.l.velikov@gmail.com --- Hi Andreas, afaict the define has found its way into the header. Admittedly in a slightly different manner.
dri-devel@lists.freedesktop.org