From: Ondrej Jirman megous@megous.com
This check is already performed by of_graph_get_remote_node. No need to repeat it immediately after the call.
Signed-off-by: Ondrej Jirman megous@megous.com --- drivers/gpu/drm/drm_of.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index 43d89dd59c6b..0ca58803ba46 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -247,17 +247,12 @@ int drm_of_find_panel_or_bridge(const struct device_node *np, *panel = NULL;
remote = of_graph_get_remote_node(np, port, endpoint); if (!remote) return -ENODEV;
- if (!of_device_is_available(remote)) { - of_node_put(remote); - return -ENODEV; - } - if (panel) { *panel = of_drm_find_panel(remote); if (!IS_ERR(*panel)) ret = 0; else *panel = NULL;
On Fri, Sep 20, 2019 at 1:29 PM megous@megous.com wrote:
From: Ondrej Jirman megous@megous.com
This check is already performed by of_graph_get_remote_node. No need to repeat it immediately after the call.
Signed-off-by: Ondrej Jirman megous@megous.com
Thanks for your patch, I've applied it to drm-misc-next.
Sean
drivers/gpu/drm/drm_of.c | 5 ----- 1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.c index 43d89dd59c6b..0ca58803ba46 100644 --- a/drivers/gpu/drm/drm_of.c +++ b/drivers/gpu/drm/drm_of.c @@ -247,17 +247,12 @@ int drm_of_find_panel_or_bridge(const struct device_node *np, *panel = NULL;
remote = of_graph_get_remote_node(np, port, endpoint); if (!remote) return -ENODEV;
if (!of_device_is_available(remote)) {
of_node_put(remote);
return -ENODEV;
}
if (panel) { *panel = of_drm_find_panel(remote); if (!IS_ERR(*panel)) ret = 0; else *panel = NULL;
-- 2.23.0
dri-devel@lists.freedesktop.org