From: Ander Conselvan de Oliveira ander.conselvan.de.oliveira@intel.com
linux_sysfs_create() checked for a driver named "intel" while the intel driver is called "i915". This went unnoticed because in kernels 2.6.39 and after this code path was never reached because of the dumb buffer interface. On earlier kernels, kms_create() would fail.
Signed-off-by: Ander Conselvan de Oliveira ander.conselvan.de.oliveira@intel.com --- libkms/linux.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libkms/linux.c b/libkms/linux.c index fc4f205..dde74f7 100644 --- a/libkms/linux.c +++ b/libkms/linux.c @@ -101,7 +101,7 @@ linux_from_sysfs(int fd, struct kms_driver **out) if (ret) return ret;
- if (!strcmp(name, "intel")) + if (!strcmp(name, "i915")) ret = intel_create(fd, out); #ifdef HAVE_VMWGFX else if (!strcmp(name, "vmwgfx"))
Ping?
On 09/05/2012 02:30 PM, Ander Conselvan de Oliveira wrote:
From: Ander Conselvan de Oliveira ander.conselvan.de.oliveira@intel.com
linux_sysfs_create() checked for a driver named "intel" while the intel driver is called "i915". This went unnoticed because in kernels 2.6.39 and after this code path was never reached because of the dumb buffer interface. On earlier kernels, kms_create() would fail.
Signed-off-by: Ander Conselvan de Oliveira ander.conselvan.de.oliveira@intel.com
libkms/linux.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/libkms/linux.c b/libkms/linux.c index fc4f205..dde74f7 100644 --- a/libkms/linux.c +++ b/libkms/linux.c @@ -101,7 +101,7 @@ linux_from_sysfs(int fd, struct kms_driver **out) if (ret) return ret;
- if (!strcmp(name, "intel"))
- if (!strcmp(name, "i915")) ret = intel_create(fd, out); #ifdef HAVE_VMWGFX else if (!strcmp(name, "vmwgfx"))
dri-devel@lists.freedesktop.org