Removing the default display name left a harmless warning:
fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe': fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable]
This removes the now-unused variable as well.
Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support") Signed-off-by: Arnd Bergmann arnd@arndb.de Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com --- Originally submitted on June 9, no reply other than the Reviewed-by tag. The patch is still needed --- drivers/video/fbdev/omap2/omapfb/dss/core.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c index eecf695c16f4..09e5bb013d28 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c @@ -193,7 +193,6 @@ static struct notifier_block omap_dss_pm_notif_block = {
static int __init omap_dss_probe(struct platform_device *pdev) { - struct omap_dss_board_info *pdata = pdev->dev.platform_data; int r;
core.pdev = pdev;
Hi,
On Wednesday, July 26, 2017 03:57:55 PM Arnd Bergmann wrote:
Removing the default display name left a harmless warning:
fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe': fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable]
This removes the now-unused variable as well.
Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support") Signed-off-by: Arnd Bergmann arnd@arndb.de Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
Originally submitted on June 9, no reply other than the Reviewed-by tag. The patch is still needed
It is not lost and will be queued for 4.13 fbdev fixes pull request.
[ The guilty commit went through DRM tree and pulling it into fbdev tree just to fix the warning was not feasible.. ]
drivers/video/fbdev/omap2/omapfb/dss/core.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/core.c b/drivers/video/fbdev/omap2/omapfb/dss/core.c index eecf695c16f4..09e5bb013d28 100644 --- a/drivers/video/fbdev/omap2/omapfb/dss/core.c +++ b/drivers/video/fbdev/omap2/omapfb/dss/core.c @@ -193,7 +193,6 @@ static struct notifier_block omap_dss_pm_notif_block = {
static int __init omap_dss_probe(struct platform_device *pdev) {
struct omap_dss_board_info *pdata = pdev->dev.platform_data; int r;
core.pdev = pdev;
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
On Wed, Jul 26, 2017 at 4:27 PM, Bartlomiej Zolnierkiewicz b.zolnierkie@samsung.com wrote:
Hi,
On Wednesday, July 26, 2017 03:57:55 PM Arnd Bergmann wrote:
Removing the default display name left a harmless warning:
fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe': fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable]
This removes the now-unused variable as well.
Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support") Signed-off-by: Arnd Bergmann arnd@arndb.de Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
Originally submitted on June 9, no reply other than the Reviewed-by tag. The patch is still needed
It is not lost and will be queued for 4.13 fbdev fixes pull request.
Ok, thanks a lot!
[ The guilty commit went through DRM tree and pulling it into fbdev tree just to fix the warning was not feasible.. ]
Yes, I was originally hoping the fix could be merged along with the patch that introduced the bug. I may have messed up the Cc list for that though.
Arnd
On Wed, Jul 26, 2017 at 04:31:38PM +0200, Arnd Bergmann wrote:
On Wed, Jul 26, 2017 at 4:27 PM, Bartlomiej Zolnierkiewicz b.zolnierkie@samsung.com wrote:
Hi,
On Wednesday, July 26, 2017 03:57:55 PM Arnd Bergmann wrote:
Removing the default display name left a harmless warning:
fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe': fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable]
This removes the now-unused variable as well.
Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support") Signed-off-by: Arnd Bergmann arnd@arndb.de Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
Originally submitted on June 9, no reply other than the Reviewed-by tag. The patch is still needed
It is not lost and will be queued for 4.13 fbdev fixes pull request.
Ok, thanks a lot!
[ The guilty commit went through DRM tree and pulling it into fbdev tree just to fix the warning was not feasible.. ]
Yes, I was originally hoping the fix could be merged along with the patch that introduced the bug. I may have messed up the Cc list for that though.
Should we add dri-devel as an mailing list entry to the fbdev system in MAINTAINERS? Iirc there's almost no traffic for fbdev itself, and this would avoid such a fumble in the future. -Daniel
On Wednesday, July 26, 2017 04:27:30 PM Bartlomiej Zolnierkiewicz wrote:
Hi,
On Wednesday, July 26, 2017 03:57:55 PM Arnd Bergmann wrote:
Removing the default display name left a harmless warning:
fbdev/omap2/omapfb/dss/core.c: In function 'omap_dss_probe': fbdev/omap2/omapfb/dss/core.c:196:30: error: unused variable 'pdata' [-Werror=unused-variable]
This removes the now-unused variable as well.
Fixes: 278cba7eaf54 ("drm: omapdrm: Remove unused default display name support") Signed-off-by: Arnd Bergmann arnd@arndb.de Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
Originally submitted on June 9, no reply other than the Reviewed-by tag. The patch is still needed
It is not lost and will be queued for 4.13 fbdev fixes pull request.
[ The guilty commit went through DRM tree and pulling it into fbdev tree just to fix the warning was not feasible.. ]
Patch queued for 4.13, thanks.
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
dri-devel@lists.freedesktop.org
-
Arnd Bergmann -
Bartlomiej Zolnierkiewicz -
Daniel Vetter