On Mon, Mar 01, 2021 at 04:19:50PM +0800, Jiapeng Chong wrote:

Fix the following sparse warning:

drivers/gpu/drm/drm_file.c:789:6: warning: symbol 'drm_send_event_helper' was not declared. Should it be static?

Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Jiapeng Chong jiapeng.chong@linux.alibaba.com

---

drivers/gpu/drm/drm_file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_file.c b/drivers/gpu/drm/drm_file.c index 7efbccf..23d8ad4 100644 --- a/drivers/gpu/drm/drm_file.c +++ b/drivers/gpu/drm/drm_file.c @@ -786,8 +786,8 @@ void drm_event_cancel_free(struct drm_device *dev,

• The timestamp variant of dma_fence_signal is used when the caller
• sends a valid timestamp.

*/ -void drm_send_event_helper(struct drm_device *dev,

• 	   struct drm_pending_event *e, ktime_t timestamp)
  

+static void drm_send_event_helper(struct drm_device *dev, struct drm_pending_event *e,

• 		   ktime_t timestamp)
  

For static inline functions we also remove the kerneldoc, there's not really anything important in there. Can you pls do that and respin your patch?

Thanks, Daniel

{ assert_spin_locked(&dev->event_lock);

-- 1.8.3.1