It does not make sense to have a comma after a sentinel, as any new elements must be added before the sentinel.
Signed-off-by: Geert Uytterhoeven geert+renesas@glider.be --- drivers/gpu/drm/bridge/nwl-dsi.c | 2 +- drivers/gpu/drm/meson/meson_drv.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c index 5abb5ec3de467458..846df1ee7a2888cb 100644 --- a/drivers/gpu/drm/bridge/nwl-dsi.c +++ b/drivers/gpu/drm/bridge/nwl-dsi.c @@ -1151,7 +1151,7 @@ MODULE_DEVICE_TABLE(of, nwl_dsi_dt_ids); static const struct soc_device_attribute nwl_dsi_quirks_match[] = { { .soc_id = "i.MX8MQ", .revision = "2.0", .data = (void *)E11418_HS_MODE_QUIRK }, - { /* sentinel. */ }, + { /* sentinel. */ } };
static int nwl_dsi_probe(struct platform_device *pdev) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c index 26aeaf0ab86ef932..35eaa669e8fe0c2a 100644 --- a/drivers/gpu/drm/meson/meson_drv.c +++ b/drivers/gpu/drm/meson/meson_drv.c @@ -167,7 +167,7 @@ static const struct meson_drm_soc_attr meson_drm_soc_attrs[] = { }, .attrs = (const struct soc_device_attribute []) { { .soc_id = "GXL (S805*)", }, - { /* sentinel */ }, + { /* sentinel */ } } }, };
On Thu, Mar 3, 2022 at 1:45 PM Geert Uytterhoeven geert+renesas@glider.be wrote:
It does not make sense to have a comma after a sentinel, as any new elements must be added before the sentinel.
agreed, thanks for taking care of this!
Signed-off-by: Geert Uytterhoeven geert+renesas@glider.be
drivers/gpu/drm/bridge/nwl-dsi.c | 2 +- drivers/gpu/drm/meson/meson_drv.c | 2 +-
for drivers/gpu/drm/meson/meson_drv.c: Acked-by: Martin Blumenstingl martin.blumenstingl@googlemail.com
Best regards, Martin
On 03/03/2022 13:44, Geert Uytterhoeven wrote:
It does not make sense to have a comma after a sentinel, as any new elements must be added before the sentinel.
Signed-off-by: Geert Uytterhoeven geert+renesas@glider.be
drivers/gpu/drm/bridge/nwl-dsi.c | 2 +- drivers/gpu/drm/meson/meson_drv.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c index 5abb5ec3de467458..846df1ee7a2888cb 100644 --- a/drivers/gpu/drm/bridge/nwl-dsi.c +++ b/drivers/gpu/drm/bridge/nwl-dsi.c @@ -1151,7 +1151,7 @@ MODULE_DEVICE_TABLE(of, nwl_dsi_dt_ids); static const struct soc_device_attribute nwl_dsi_quirks_match[] = { { .soc_id = "i.MX8MQ", .revision = "2.0", .data = (void *)E11418_HS_MODE_QUIRK },
- { /* sentinel. */ },
{ /* sentinel. */ } };
static int nwl_dsi_probe(struct platform_device *pdev)
diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meson_drv.c index 26aeaf0ab86ef932..35eaa669e8fe0c2a 100644 --- a/drivers/gpu/drm/meson/meson_drv.c +++ b/drivers/gpu/drm/meson/meson_drv.c @@ -167,7 +167,7 @@ static const struct meson_drm_soc_attr meson_drm_soc_attrs[] = { }, .attrs = (const struct soc_device_attribute []) { { .soc_id = "GXL (S805*)", },
{ /* sentinel */ },
} }, };{ /* sentinel */ }
Reviewed-by: Neil Armstrong narmstrong@baylibre.com
Tell me if you want me to apply it to drm-misc-next.
Thanks, Neil
Hi Neil,
On Mon, Mar 7, 2022 at 9:30 AM Neil Armstrong narmstrong@baylibre.com wrote:
On 03/03/2022 13:44, Geert Uytterhoeven wrote:
It does not make sense to have a comma after a sentinel, as any new elements must be added before the sentinel.
Signed-off-by: Geert Uytterhoeven geert+renesas@glider.be
Reviewed-by: Neil Armstrong narmstrong@baylibre.com
Thank you!
Tell me if you want me to apply it to drm-misc-next.
Do I have other options? ;-) Thanks in advance!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi,
On Thu, 3 Mar 2022 13:44:56 +0100, Geert Uytterhoeven wrote:
It does not make sense to have a comma after a sentinel, as any new elements must be added before the sentinel.
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/1] drm: Drop commas after SoC match table sentinels https://cgit.freedesktop.org/drm/drm-misc/commit/?id=f6e68388443ff50088e224b...
dri-devel@lists.freedesktop.org