Am 15.11.21 um 08:07 schrieb Bernard Zhao:

This change is to cleanup the code style a bit.

To be honest I think the old style looked better. It took me a moment to validate this now.

What you could to instead is to have goto style error handling which would make this a bit more cleaner I think.

Christian.

Signed-off-by: Bernard Zhao bernard@vivo.com

drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c index 04cf9b207e62..90070b41136a 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c @@ -286,12 +286,14 @@ static int amdgpu_virt_init_ras_err_handler_data(struct amdgpu_device *adev) return -ENOMEM;

bps = kmalloc_array(align_space, sizeof((*data)->bps), GFP_KERNEL);

• if (!bps) {

• kfree(*data);
  

• return -ENOMEM;
  

• } bps_bo = kmalloc_array(align_space, sizeof((*data)->bps_bo), GFP_KERNEL);

• if (!bps || !bps_bo) {

• kfree(bps);
  

• kfree(bps_bo);
  

• if (!bps_bo) { kfree(*data);

• kfree(bps);
  

  return -ENOMEM; }