Support inx Himax8279d 8.0" 1200x1920 TFT LCD panel, it is a MIPI DSI panel.
Signed-off-by: Zhengqiao Xia xiazhengqiao@huaqin.corp-partner.google.com --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-innolux-himax8279d.c | 542 ++++++++++++++++++ 3 files changed, 552 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-innolux-himax8279d.c
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index b4e021ea3..853e39a84 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -123,6 +123,15 @@ config DRM_PANEL_ILITEK_ILI9881C Say Y if you want to enable support for panels based on the Ilitek ILI9881c controller.
+config DRM_PANEL_INNOLUX_HIMAX8279D + tristate "INX 2081101qfh032011-53g 1200x1920 video panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to support for INX 2081101qfh032011-53g + 1200x1920 video panel. + config DRM_PANEL_INNOLUX_P079ZCA tristate "Innolux P079ZCA panel" depends on OF diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index ebbf488c7..6440b4258 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -11,6 +11,7 @@ obj-$(CONFIG_DRM_PANEL_FEIXIN_K101_IM2BA02) += panel-feixin-k101-im2ba02.o obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) += panel-feiyang-fy07024di26a30d.o obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) += panel-ilitek-ili9881c.o +obj-$(CONFIG_DRM_PANEL_INNOLUX_HIMAX8279D) += panel-innolux-himax8279d.o obj-$(CONFIG_DRM_PANEL_INNOLUX_P079ZCA) += panel-innolux-p079zca.o obj-$(CONFIG_DRM_PANEL_JDI_LT070ME05000) += panel-jdi-lt070me05000.o obj-$(CONFIG_DRM_PANEL_KINGDISPLAY_KD097D04) += panel-kingdisplay-kd097d04.o diff --git a/drivers/gpu/drm/panel/panel-innolux-himax8279d.c b/drivers/gpu/drm/panel/panel-innolux-himax8279d.c new file mode 100644 index 000000000..a74dbeaba --- /dev/null +++ b/drivers/gpu/drm/panel/panel-innolux-himax8279d.c @@ -0,0 +1,542 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2021, Huaqin Telecom Technology Co., Ltd + * Author: Zhengqiao Xia xiazhengqiao@huaqin.corp-partner.google.com + */ + +#include <linux/delay.h> +#include <linux/gpio/consumer.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_device.h> +#include <linux/regulator/consumer.h> + +#include <drm/drm_crtc.h> +#include <drm/drm_mipi_dsi.h> +#include <drm/drm_panel.h> + +#include <video/mipi_display.h> + +struct panel_desc { + const struct drm_display_mode *modes; + unsigned int bpc; + + /** + * @width_mm: width of the panel's active display area + * @height_mm: height of the panel's active display area + */ + struct { + unsigned int width_mm; + unsigned int height_mm; + } size; + + unsigned long mode_flags; + enum mipi_dsi_pixel_format format; + const struct panel_init_cmd *init_cmds; + unsigned int lanes; + bool discharge_on_disable; +}; + +struct inx_panel { + struct drm_panel base; + struct mipi_dsi_device *dsi; + + const struct panel_desc *desc; + + struct regulator *pp1800; + struct regulator *avee; + struct regulator *avdd; + struct gpio_desc *enable_gpio; + + bool prepared_power; + bool prepared; +}; + +enum dsi_cmd_type { + INIT_DCS_CMD, + DELAY_CMD, +}; + +struct panel_init_cmd { + enum dsi_cmd_type type; + size_t len; + const char *data; +}; + +#define _INIT_DCS_CMD(...) { \ + .type = INIT_DCS_CMD, \ + .len = sizeof((char[]){__VA_ARGS__}), \ + .data = (char[]){__VA_ARGS__} } + +#define _INIT_DELAY_CMD(...) { \ + .type = DELAY_CMD,\ + .len = sizeof((char[]){__VA_ARGS__}), \ + .data = (char[]){__VA_ARGS__} } + +static const struct panel_init_cmd starry_qfh032011_53g_init_cmd[] = { + _INIT_DCS_CMD(0xB0, 0x05), + _INIT_DCS_CMD(0xC0, 0x03), + _INIT_DCS_CMD(0xC2, 0x03), + _INIT_DCS_CMD(0xD9, 0x03), + _INIT_DCS_CMD(0xDB, 0x03), + _INIT_DCS_CMD(0xB0, 0x01), + _INIT_DCS_CMD(0xC3, 0x4F), + _INIT_DCS_CMD(0xC4, 0x40), + _INIT_DCS_CMD(0xC5, 0x40), + _INIT_DCS_CMD(0xC6, 0x40), + _INIT_DCS_CMD(0xC7, 0x40), + _INIT_DCS_CMD(0xC8, 0x4D), + _INIT_DCS_CMD(0xC9, 0x52), + _INIT_DCS_CMD(0xCA, 0x51), + _INIT_DCS_CMD(0xCD, 0x5D), + _INIT_DCS_CMD(0xCE, 0x5B), + _INIT_DCS_CMD(0xCF, 0x4B), + _INIT_DCS_CMD(0xD0, 0x49), + _INIT_DCS_CMD(0xD1, 0x47), + _INIT_DCS_CMD(0xD2, 0x45), + _INIT_DCS_CMD(0xD3, 0x41), + _INIT_DCS_CMD(0xD7, 0x50), + _INIT_DCS_CMD(0xD8, 0x40), + _INIT_DCS_CMD(0xD9, 0x40), + _INIT_DCS_CMD(0xDA, 0x40), + _INIT_DCS_CMD(0xDB, 0x40), + _INIT_DCS_CMD(0xDC, 0x4E), + _INIT_DCS_CMD(0xDD, 0x52), + _INIT_DCS_CMD(0xDE, 0x51), + _INIT_DCS_CMD(0xE1, 0x5E), + _INIT_DCS_CMD(0xE2, 0x5C), + _INIT_DCS_CMD(0xE3, 0x4C), + _INIT_DCS_CMD(0xE4, 0x4A), + _INIT_DCS_CMD(0xE5, 0x48), + _INIT_DCS_CMD(0xE6, 0x46), + _INIT_DCS_CMD(0xE7, 0x42), + _INIT_DCS_CMD(0xB0, 0x03), + _INIT_DCS_CMD(0xBE, 0x03), + _INIT_DCS_CMD(0xCC, 0x44), + _INIT_DCS_CMD(0xC8, 0x07), + _INIT_DCS_CMD(0xC9, 0x05), + _INIT_DCS_CMD(0xCA, 0x42), + _INIT_DCS_CMD(0xCD, 0x3E), + _INIT_DCS_CMD(0xCF, 0x60), + _INIT_DCS_CMD(0xD2, 0x04), + _INIT_DCS_CMD(0xD3, 0x04), + _INIT_DCS_CMD(0xD4, 0x01), + _INIT_DCS_CMD(0xD5, 0x00), + _INIT_DCS_CMD(0xD6, 0x03), + _INIT_DCS_CMD(0xD7, 0x04), + _INIT_DCS_CMD(0xD9, 0x01), + _INIT_DCS_CMD(0xDB, 0x01), + _INIT_DCS_CMD(0xE4, 0xF0), + _INIT_DCS_CMD(0xE5, 0x0A), + _INIT_DCS_CMD(0xB0, 0x00), + _INIT_DCS_CMD(0xCC, 0x08), + _INIT_DCS_CMD(0xC2, 0x08), + _INIT_DCS_CMD(0xC4, 0x10), + _INIT_DCS_CMD(0xB0, 0x02), + _INIT_DCS_CMD(0xC0, 0x00), + _INIT_DCS_CMD(0xC1, 0x0A), + _INIT_DCS_CMD(0xC2, 0x20), + _INIT_DCS_CMD(0xC3, 0x24), + _INIT_DCS_CMD(0xC4, 0x23), + _INIT_DCS_CMD(0xC5, 0x29), + _INIT_DCS_CMD(0xC6, 0x23), + _INIT_DCS_CMD(0xC7, 0x1C), + _INIT_DCS_CMD(0xC8, 0x19), + _INIT_DCS_CMD(0xC9, 0x17), + _INIT_DCS_CMD(0xCA, 0x17), + _INIT_DCS_CMD(0xCB, 0x18), + _INIT_DCS_CMD(0xCC, 0x1A), + _INIT_DCS_CMD(0xCD, 0x1E), + _INIT_DCS_CMD(0xCE, 0x20), + _INIT_DCS_CMD(0xCF, 0x23), + _INIT_DCS_CMD(0xD0, 0x07), + _INIT_DCS_CMD(0xD1, 0x00), + _INIT_DCS_CMD(0xD2, 0x00), + _INIT_DCS_CMD(0xD3, 0x0A), + _INIT_DCS_CMD(0xD4, 0x13), + _INIT_DCS_CMD(0xD5, 0x1C), + _INIT_DCS_CMD(0xD6, 0x1A), + _INIT_DCS_CMD(0xD7, 0x13), + _INIT_DCS_CMD(0xD8, 0x17), + _INIT_DCS_CMD(0xD9, 0x1C), + _INIT_DCS_CMD(0xDA, 0x19), + _INIT_DCS_CMD(0xDB, 0x17), + _INIT_DCS_CMD(0xDC, 0x17), + _INIT_DCS_CMD(0xDD, 0x18), + _INIT_DCS_CMD(0xDE, 0x1A), + _INIT_DCS_CMD(0xDF, 0x1E), + _INIT_DCS_CMD(0xE0, 0x20), + _INIT_DCS_CMD(0xE1, 0x23), + _INIT_DCS_CMD(0xE2, 0x07), + _INIT_DCS_CMD(0X11), + _INIT_DELAY_CMD(120), + _INIT_DCS_CMD(0X29), + _INIT_DELAY_CMD(80), + {}, +}; + +static inline struct inx_panel *to_inx_panel(struct drm_panel *panel) +{ + return container_of(panel, struct inx_panel, base); +} + +static int inx_panel_init_dcs_cmd(struct inx_panel *inx) +{ + struct mipi_dsi_device *dsi = inx->dsi; + struct drm_panel *panel = &inx->base; + int i, err = 0; + + if (inx->desc->init_cmds) { + const struct panel_init_cmd *init_cmds = inx->desc->init_cmds; + + for (i = 0; init_cmds[i].len != 0; i++) { + const struct panel_init_cmd *cmd = &init_cmds[i]; + + switch (cmd->type) { + case DELAY_CMD: + msleep(cmd->data[0]); + err = 0; + break; + + case INIT_DCS_CMD: + err = mipi_dsi_dcs_write(dsi, cmd->data[0], + cmd->len <= 1 ? NULL : + &cmd->data[1], + cmd->len - 1); + break; + + default: + err = -EINVAL; + } + + if (err < 0) { + dev_err(panel->dev, + "failed to write command %u\n", i); + return err; + } + } + } + return 0; +} + +static int inx_panel_enter_sleep_mode(struct inx_panel *inx) +{ + struct mipi_dsi_device *dsi = inx->dsi; + int ret; + + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; + + ret = mipi_dsi_dcs_set_display_off(dsi); + if (ret < 0) + return ret; + ret = mipi_dsi_dcs_enter_sleep_mode(dsi); + if (ret < 0) + return ret; + + return 0; +} + +static int inx_panel_unprepare_power(struct drm_panel *panel) +{ + struct inx_panel *inx = to_inx_panel(panel); + + if (!inx->prepared_power) + return 0; + + msleep(200); + + if (inx->desc->discharge_on_disable) { + regulator_disable(inx->avee); + regulator_disable(inx->avdd); + usleep_range(5000, 7000); + gpiod_set_value(inx->enable_gpio, 0); + usleep_range(5000, 7000); + regulator_disable(inx->pp1800); + } else { + gpiod_set_value(inx->enable_gpio, 0); + usleep_range(500, 1000); + regulator_disable(inx->avee); + regulator_disable(inx->avdd); + usleep_range(5000, 7000); + regulator_disable(inx->pp1800); + } + + inx->prepared_power = false; + + return 0; +} + +static int inx_panel_unprepare(struct drm_panel *panel) +{ + struct inx_panel *inx = to_inx_panel(panel); + int ret; + + if (!inx->prepared) + return 0; + + if (!inx->desc->discharge_on_disable) { + ret = inx_panel_enter_sleep_mode(inx); + if (ret < 0) { + dev_err(panel->dev, "failed to set panel off: %d\n", + ret); + return ret; + } + } + + inx->prepared = false; + + return 0; +} + +static int inx_panel_prepare_power(struct drm_panel *panel) +{ + struct inx_panel *inx = to_inx_panel(panel); + int ret; + + if (inx->prepared_power) + return 0; + + gpiod_set_value(inx->enable_gpio, 0); + usleep_range(1000, 1500); + + ret = regulator_enable(inx->pp1800); + if (ret < 0) + return ret; + + usleep_range(3000, 5000); + + ret = regulator_enable(inx->avdd); + if (ret < 0) + goto poweroff1v8; + ret = regulator_enable(inx->avee); + if (ret < 0) + goto poweroffavdd; + + usleep_range(5000, 10000); + + gpiod_set_value(inx->enable_gpio, 1); + usleep_range(1000, 2000); + gpiod_set_value(inx->enable_gpio, 0); + usleep_range(1000, 2000); + gpiod_set_value(inx->enable_gpio, 1); + usleep_range(6000, 10000); + + inx->prepared_power = true; + + return 0; + +poweroffavdd: + regulator_disable(inx->avdd); +poweroff1v8: + usleep_range(5000, 7000); + regulator_disable(inx->pp1800); + gpiod_set_value(inx->enable_gpio, 0); + + return ret; +} + +static int inx_panel_prepare(struct drm_panel *panel) +{ + struct inx_panel *inx = to_inx_panel(panel); + int ret; + + if (inx->prepared) + return 0; + + ret = inx_panel_init_dcs_cmd(inx); + if (ret < 0) { + dev_err(panel->dev, "failed to init panel: %d\n", ret); + return ret; + } + + inx->prepared = true; + + return 0; +} + +static int inx_panel_enable(struct drm_panel *panel) +{ + msleep(130); + return 0; +} + +static const struct drm_display_mode starry_qfh032011_53g_default_mode = { + .clock = 165731, + .hdisplay = 1200, + .hsync_start = 1200 + 100, + .hsync_end = 1200 + 100 + 10, + .htotal = 1200 + 100 + 10 + 100, + .vdisplay = 1920, + .vsync_start = 1920 + 14, + .vsync_end = 1920 + 14 + 10, + .vtotal = 1920 + 14 + 10 + 15, + .vrefresh = 60, +}; + +static const struct panel_desc starry_qfh032011_53g_desc = { + .modes = &starry_qfh032011_53g_default_mode, + .bpc = 8, + .size = { + .width_mm = 135, + .height_mm = 216, + }, + .lanes = 4, + .format = MIPI_DSI_FMT_RGB888, + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | + MIPI_DSI_MODE_LPM, + .init_cmds = starry_qfh032011_53g_init_cmd, + .discharge_on_disable = false, +}; + +static int inx_panel_get_modes(struct drm_panel *panel) +{ + struct inx_panel *inx = to_inx_panel(panel); + const struct drm_display_mode *m = inx->desc->modes; + struct drm_display_mode *mode; + struct drm_connector *connector = panel->connector; + + mode = drm_mode_duplicate(connector->dev, m); + if (!mode) { + dev_err(panel->dev, "failed to add mode %ux%u@%u\n", + m->hdisplay, m->vdisplay, m->vrefresh); + return -ENOMEM; + } + + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; + drm_mode_set_name(mode); + drm_mode_probed_add(connector, mode); + + connector->display_info.width_mm = inx->desc->size.width_mm; + connector->display_info.height_mm = inx->desc->size.height_mm; + connector->display_info.bpc = inx->desc->bpc; + + return 1; +} + +static const struct drm_panel_funcs inx_panel_funcs = { + .unprepare = inx_panel_unprepare, + .unprepare_power = inx_panel_unprepare_power, + .prepare = inx_panel_prepare, + .prepare_power = inx_panel_prepare_power, + .enable = inx_panel_enable, + .get_modes = inx_panel_get_modes, +}; + +static int inx_panel_add(struct inx_panel *inx) +{ + struct device *dev = &inx->dsi->dev; + int ret; + + inx->avdd = devm_regulator_get(dev, "avdd"); + if (IS_ERR(inx->avdd)) + return PTR_ERR(inx->avdd); + + inx->avee = devm_regulator_get(dev, "avee"); + if (IS_ERR(inx->avee)) + return PTR_ERR(inx->avee); + + inx->pp1800 = devm_regulator_get(dev, "pp1800"); + if (IS_ERR(inx->pp1800)) + return PTR_ERR(inx->pp1800); + + inx->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW); + if (IS_ERR(inx->enable_gpio)) { + dev_err(dev, "cannot get reset-gpios %ld\n", + PTR_ERR(inx->enable_gpio)); + return PTR_ERR(inx->enable_gpio); + } + + gpiod_set_value(inx->enable_gpio, 0); + + drm_panel_init(&inx->base); + ret = of_drm_get_panel_orientation(dev->of_node, + &inx->base.orientation); + if (ret < 0) + return ret; + + inx->base.funcs = &inx_panel_funcs; + inx->base.dev = &inx->dsi->dev; + + ret = drm_panel_of_backlight(&inx->base); + if (ret) + return ret; + + return drm_panel_add(&inx->base); +} + +static int inx_panel_probe(struct mipi_dsi_device *dsi) +{ + struct inx_panel *inx; + int ret; + const struct panel_desc *desc; + + inx = devm_kzalloc(&dsi->dev, sizeof(*inx), GFP_KERNEL); + if (!inx) + return -ENOMEM; + + desc = of_device_get_match_data(&dsi->dev); + dsi->lanes = desc->lanes; + dsi->format = desc->format; + dsi->mode_flags = desc->mode_flags; + inx->desc = desc; + inx->dsi = dsi; + ret = inx_panel_add(inx); + if (ret < 0) + return ret; + + mipi_dsi_set_drvdata(dsi, inx); + + ret = mipi_dsi_attach(dsi); + if (ret) + drm_panel_remove(&inx->base); + + return ret; +} + +static void inx_panel_shutdown(struct mipi_dsi_device *dsi) +{ + struct inx_panel *inx = mipi_dsi_get_drvdata(dsi); + + drm_panel_disable(&inx->base); + drm_panel_unprepare(&inx->base); +} + +static int inx_panel_remove(struct mipi_dsi_device *dsi) +{ + struct inx_panel *inx = mipi_dsi_get_drvdata(dsi); + int ret; + + inx_panel_shutdown(dsi); + + ret = mipi_dsi_detach(dsi); + if (ret < 0) + dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); + + if (inx->base.dev) + drm_panel_remove(&inx->base); + + return 0; +} + +static const struct of_device_id inx_of_match[] = { + { .compatible = "starry,2081101qfh032011-53g", + .data = &starry_qfh032011_53g_desc + }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, inx_of_match); + +static struct mipi_dsi_driver inx_panel_driver = { + .driver = { + .name = "panel-inx-2081101qfh032011-53g", + .of_match_table = inx_of_match, + }, + .probe = inx_panel_probe, + .remove = inx_panel_remove, + .shutdown = inx_panel_shutdown, +}; +module_mipi_dsi_driver(inx_panel_driver); + +MODULE_AUTHOR("Zhengqiao Xia xiazhengqiao@huaqin.corp-partner.google.com"); +MODULE_DESCRIPTION("INX 2081101qfh032011-53g 1200x1920 video mode panel driver"); +MODULE_LICENSE("GPL v2");
Hi Zhengqiao,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master] [also build test WARNING on v5.11-rc6 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Zhengqiao-Xia/drm-panel-Add-inx-Him... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 61556703b610a104de324e4f061dc6cf7b218b46 config: nios2-allyesconfig (attached as .config) compiler: nios2-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/40cb37f54329ed37a56856e1122f8f5ba9c7... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Zhengqiao-Xia/drm-panel-Add-inx-Himax8279d-MIPI-DSI-LCD-panel/20210209-071837 git checkout 40cb37f54329ed37a56856e1122f8f5ba9c7a7d8 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:373:3: error: 'const struct drm_display_mode' has no member named 'vrefresh' 373 | .vrefresh = 60, | ^~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c: In function 'inx_panel_get_modes': drivers/gpu/drm/panel/panel-innolux-himax8279d.c:396:43: error: 'struct drm_panel' has no member named 'connector'; did you mean 'connector_type'? 396 | struct drm_connector *connector = panel->connector; | ^~~~~~~~~ | connector_type In file included from include/linux/device.h:15, from include/linux/node.h:18, from include/linux/cpu.h:17, from include/linux/of_device.h:5, from drivers/gpu/drm/panel/panel-innolux-himax8279d.c:11: drivers/gpu/drm/panel/panel-innolux-himax8279d.c:401:31: error: 'const struct drm_display_mode' has no member named 'vrefresh' 401 | m->hdisplay, m->vdisplay, m->vrefresh); | ^~ include/linux/dev_printk.h:112:32: note: in definition of macro 'dev_err' 112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c: At top level: drivers/gpu/drm/panel/panel-innolux-himax8279d.c:418:3: error: 'const struct drm_panel_funcs' has no member named 'unprepare_power' 418 | .unprepare_power = inx_panel_unprepare_power, | ^~~~~~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:418:21: error: initialization of 'int (*)(struct drm_panel *, struct drm_connector *)' from incompatible pointer type 'int (*)(struct drm_panel *)' [-Werror=incompatible-pointer-types] 418 | .unprepare_power = inx_panel_unprepare_power, | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:418:21: note: (near initialization for 'inx_panel_funcs.get_modes') drivers/gpu/drm/panel/panel-innolux-himax8279d.c:420:3: error: 'const struct drm_panel_funcs' has no member named 'prepare_power' 420 | .prepare_power = inx_panel_prepare_power, | ^~~~~~~~~~~~~
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:421:12: warning: initialized field overwritten [-Woverride-init]
421 | .enable = inx_panel_enable, | ^~~~~~~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:421:12: note: (near initialization for 'inx_panel_funcs.enable') drivers/gpu/drm/panel/panel-innolux-himax8279d.c:422:15: error: initialization of 'int (*)(struct drm_panel *, struct drm_connector *)' from incompatible pointer type 'int (*)(struct drm_panel *)' [-Werror=incompatible-pointer-types] 422 | .get_modes = inx_panel_get_modes, | ^~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:422:15: note: (near initialization for 'inx_panel_funcs.get_modes') drivers/gpu/drm/panel/panel-innolux-himax8279d.c:422:15: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/panel/panel-innolux-himax8279d.c:422:15: note: (near initialization for 'inx_panel_funcs.get_modes') drivers/gpu/drm/panel/panel-innolux-himax8279d.c: In function 'inx_panel_add': drivers/gpu/drm/panel/panel-innolux-himax8279d.c:451:2: error: too few arguments to function 'drm_panel_init' 451 | drm_panel_init(&inx->base); | ^~~~~~~~~~~~~~ In file included from drivers/gpu/drm/panel/panel-innolux-himax8279d.c:16: include/drm/drm_panel.h:176:6: note: declared here 176 | void drm_panel_init(struct drm_panel *panel, struct device *dev, | ^~~~~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:453:19: error: 'struct drm_panel' has no member named 'orientation' 453 | &inx->base.orientation); | ^ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:464:9: error: void value not ignored as it ought to be 464 | return drm_panel_add(&inx->base); | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:465:1: error: control reaches end of non-void function [-Werror=return-type] 465 | } | ^ cc1: some warnings being treated as errors
vim +421 drivers/gpu/drm/panel/panel-innolux-himax8279d.c
415 416 static const struct drm_panel_funcs inx_panel_funcs = { 417 .unprepare = inx_panel_unprepare, 418 .unprepare_power = inx_panel_unprepare_power, 419 .prepare = inx_panel_prepare, 420 .prepare_power = inx_panel_prepare_power,
421 .enable = inx_panel_enable,
422 .get_modes = inx_panel_get_modes, 423 }; 424
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Hi Zhengqiao,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master] [also build test WARNING on v5.11-rc6 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Zhengqiao-Xia/drm-panel-Add-inx-Him... base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 61556703b610a104de324e4f061dc6cf7b218b46 config: mips-allyesconfig (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/40cb37f54329ed37a56856e1122f8f5ba9c7... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Zhengqiao-Xia/drm-panel-Add-inx-Himax8279d-MIPI-DSI-LCD-panel/20210209-071837 git checkout 40cb37f54329ed37a56856e1122f8f5ba9c7a7d8 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:373:3: error: 'const struct drm_display_mode' has no member named 'vrefresh' 373 | .vrefresh = 60, | ^~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c: In function 'inx_panel_get_modes': drivers/gpu/drm/panel/panel-innolux-himax8279d.c:396:43: error: 'struct drm_panel' has no member named 'connector'; did you mean 'connector_type'? 396 | struct drm_connector *connector = panel->connector; | ^~~~~~~~~ | connector_type In file included from include/linux/device.h:15, from include/linux/node.h:18, from include/linux/cpu.h:17, from include/linux/of_device.h:5, from drivers/gpu/drm/panel/panel-innolux-himax8279d.c:11: drivers/gpu/drm/panel/panel-innolux-himax8279d.c:401:31: error: 'const struct drm_display_mode' has no member named 'vrefresh' 401 | m->hdisplay, m->vdisplay, m->vrefresh); | ^~ include/linux/dev_printk.h:112:32: note: in definition of macro 'dev_err' 112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__) | ^~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c: At top level: drivers/gpu/drm/panel/panel-innolux-himax8279d.c:418:3: error: 'const struct drm_panel_funcs' has no member named 'unprepare_power' 418 | .unprepare_power = inx_panel_unprepare_power, | ^~~~~~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:418:21: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init] 418 | .unprepare_power = inx_panel_unprepare_power, | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:418:21: note: (near initialization for 'inx_panel_funcs')
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:418:21: warning: excess elements in struct initializer
drivers/gpu/drm/panel/panel-innolux-himax8279d.c:418:21: note: (near initialization for 'inx_panel_funcs') drivers/gpu/drm/panel/panel-innolux-himax8279d.c:420:3: error: 'const struct drm_panel_funcs' has no member named 'prepare_power' 420 | .prepare_power = inx_panel_prepare_power, | ^~~~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:420:19: error: positional initialization of field in 'struct' declared with 'designated_init' attribute [-Werror=designated-init] 420 | .prepare_power = inx_panel_prepare_power, | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:420:19: note: (near initialization for 'inx_panel_funcs') drivers/gpu/drm/panel/panel-innolux-himax8279d.c:420:19: error: initialization of 'int (*)(struct drm_panel *, struct drm_connector *)' from incompatible pointer type 'int (*)(struct drm_panel *)' [-Werror=incompatible-pointer-types] drivers/gpu/drm/panel/panel-innolux-himax8279d.c:420:19: note: (near initialization for 'inx_panel_funcs.get_modes') drivers/gpu/drm/panel/panel-innolux-himax8279d.c:422:15: error: initialization of 'int (*)(struct drm_panel *, struct drm_connector *)' from incompatible pointer type 'int (*)(struct drm_panel *)' [-Werror=incompatible-pointer-types] 422 | .get_modes = inx_panel_get_modes, | ^~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:422:15: note: (near initialization for 'inx_panel_funcs.get_modes') drivers/gpu/drm/panel/panel-innolux-himax8279d.c:422:15: warning: initialized field overwritten [-Woverride-init] drivers/gpu/drm/panel/panel-innolux-himax8279d.c:422:15: note: (near initialization for 'inx_panel_funcs.get_modes') drivers/gpu/drm/panel/panel-innolux-himax8279d.c: In function 'inx_panel_add': drivers/gpu/drm/panel/panel-innolux-himax8279d.c:451:2: error: too few arguments to function 'drm_panel_init' 451 | drm_panel_init(&inx->base); | ^~~~~~~~~~~~~~ In file included from drivers/gpu/drm/panel/panel-innolux-himax8279d.c:16: include/drm/drm_panel.h:176:6: note: declared here 176 | void drm_panel_init(struct drm_panel *panel, struct device *dev, | ^~~~~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:453:19: error: 'struct drm_panel' has no member named 'orientation' 453 | &inx->base.orientation); | ^ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:464:9: error: void value not ignored as it ought to be 464 | return drm_panel_add(&inx->base); | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/panel/panel-innolux-himax8279d.c:465:1: error: control reaches end of non-void function [-Werror=return-type] 465 | } | ^ cc1: some warnings being treated as errors
vim +418 drivers/gpu/drm/panel/panel-innolux-himax8279d.c
415 416 static const struct drm_panel_funcs inx_panel_funcs = { 417 .unprepare = inx_panel_unprepare,
418 .unprepare_power = inx_panel_unprepare_power,
419 .prepare = inx_panel_prepare, 420 .prepare_power = inx_panel_prepare_power, 421 .enable = inx_panel_enable, 422 .get_modes = inx_panel_get_modes, 423 }; 424
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Hi,
I am sorry that I am the first time to upload codes, and I mean to upload codes to kernel branch v4.19, Do we have to upload the code to upstream/master?
zhengqiao
Add STARRY 2081101QFH032011-53G 10.1" WUXGA TFT LCD panel
Signed-off-by: Zhengqiao Xia xiazhengqiao@huaqin.corp-partner.google.com --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + .../gpu/drm/panel/panel-innolux-himax8279d.c | 520 ++++++++++++++++++ 3 files changed, 530 insertions(+) create mode 100644 drivers/gpu/drm/panel/panel-innolux-himax8279d.c
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 4894913936e9..288d9268cead 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -132,6 +132,15 @@ config DRM_PANEL_ILITEK_ILI9881C Say Y if you want to enable support for panels based on the Ilitek ILI9881c controller.
+config DRM_PANEL_INNOLUX_HIMAX8279D + tristate "INX 2081101qfh032011-53g 1200x1920 video panel" + depends on OF + depends on DRM_MIPI_DSI + depends on BACKLIGHT_CLASS_DEVICE + help + Say Y here if you want to support for inx 2081101qfh032011-53g + 1200x1920 video panel. + config DRM_PANEL_INNOLUX_P079ZCA tristate "Innolux P079ZCA panel" depends on OF diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile index cae4d976c069..06be76db0a5b 100644 --- a/drivers/gpu/drm/panel/Makefile +++ b/drivers/gpu/drm/panel/Makefile @@ -12,6 +12,7 @@ obj-$(CONFIG_DRM_PANEL_FEIXIN_K101_IM2BA02) += panel-feixin-k101-im2ba02.o obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) += panel-feiyang-fy07024di26a30d.o obj-$(CONFIG_DRM_PANEL_ILITEK_IL9322) += panel-ilitek-ili9322.o obj-$(CONFIG_DRM_PANEL_ILITEK_ILI9881C) += panel-ilitek-ili9881c.o +obj-$(CONFIG_DRM_PANEL_INNOLUX_HIMAX8279D) += panel-innolux-himax8279d.o obj-$(CONFIG_DRM_PANEL_INNOLUX_P079ZCA) += panel-innolux-p079zca.o obj-$(CONFIG_DRM_PANEL_JDI_LT070ME05000) += panel-jdi-lt070me05000.o obj-$(CONFIG_DRM_PANEL_KHADAS_TS050) += panel-khadas-ts050.o diff --git a/drivers/gpu/drm/panel/panel-innolux-himax8279d.c b/drivers/gpu/drm/panel/panel-innolux-himax8279d.c new file mode 100644 index 000000000000..4420303ec709 --- /dev/null +++ b/drivers/gpu/drm/panel/panel-innolux-himax8279d.c @@ -0,0 +1,520 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (c) 2021, Huaqin Telecom Technology Co., Ltd + * Author: Zhengqiao Xia xiazhengqiao@huaqin.corp-partner.google.com + */ + +#include <linux/delay.h> +#include <linux/gpio/consumer.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/of_device.h> +#include <linux/regulator/consumer.h> + +#include <drm/drm_connector.h> +#include <drm/drm_crtc.h> +#include <drm/drm_mipi_dsi.h> +#include <drm/drm_panel.h> + +#include <video/mipi_display.h> + +struct panel_desc { + const struct drm_display_mode *modes; + unsigned int bpc; + + /** + * @width_mm: width of the panel's active display area + * @height_mm: height of the panel's active display area + */ + struct { + unsigned int width_mm; + unsigned int height_mm; + } size; + + unsigned long mode_flags; + enum mipi_dsi_pixel_format format; + const struct panel_init_cmd *init_cmds; + unsigned int lanes; + bool discharge_on_disable; +}; + +struct inx_panel { + struct drm_panel base; + struct mipi_dsi_device *dsi; + + const struct panel_desc *desc; + + enum drm_panel_orientation orientation; + struct regulator *pp1800; + struct regulator *avee; + struct regulator *avdd; + struct gpio_desc *enable_gpio; + + bool prepared; +}; + +enum dsi_cmd_type { + INIT_DCS_CMD, + DELAY_CMD, +}; + +struct panel_init_cmd { + enum dsi_cmd_type type; + size_t len; + const char *data; +}; + +#define _INIT_DCS_CMD(...) { \ + .type = INIT_DCS_CMD, \ + .len = sizeof((char[]){__VA_ARGS__}), \ + .data = (char[]){__VA_ARGS__} } + +#define _INIT_DELAY_CMD(...) { \ + .type = DELAY_CMD,\ + .len = sizeof((char[]){__VA_ARGS__}), \ + .data = (char[]){__VA_ARGS__} } + +static const struct panel_init_cmd starry_qfh032011_53g_init_cmd[] = { + _INIT_DCS_CMD(0xB0, 0x05), + _INIT_DCS_CMD(0xC0, 0x04), + _INIT_DCS_CMD(0xC2, 0x03), + _INIT_DCS_CMD(0xD9, 0x04), + _INIT_DCS_CMD(0xDB, 0x03), + _INIT_DCS_CMD(0xB0, 0x01), + _INIT_DCS_CMD(0xC3, 0x4F), + _INIT_DCS_CMD(0xC4, 0x40), + _INIT_DCS_CMD(0xC5, 0x40), + _INIT_DCS_CMD(0xC6, 0x40), + _INIT_DCS_CMD(0xC7, 0x40), + _INIT_DCS_CMD(0xC8, 0x4D), + _INIT_DCS_CMD(0xC9, 0x52), + _INIT_DCS_CMD(0xCA, 0x51), + _INIT_DCS_CMD(0xCD, 0x5D), + _INIT_DCS_CMD(0xCE, 0x5B), + _INIT_DCS_CMD(0xCF, 0x4B), + _INIT_DCS_CMD(0xD0, 0x49), + _INIT_DCS_CMD(0xD1, 0x47), + _INIT_DCS_CMD(0xD2, 0x45), + _INIT_DCS_CMD(0xD3, 0x41), + _INIT_DCS_CMD(0xD7, 0x50), + _INIT_DCS_CMD(0xD8, 0x40), + _INIT_DCS_CMD(0xD9, 0x40), + _INIT_DCS_CMD(0xDA, 0x40), + _INIT_DCS_CMD(0xDB, 0x40), + _INIT_DCS_CMD(0xDC, 0x4E), + _INIT_DCS_CMD(0xDD, 0x52), + _INIT_DCS_CMD(0xDE, 0x51), + _INIT_DCS_CMD(0xE1, 0x5E), + _INIT_DCS_CMD(0xE2, 0x5C), + _INIT_DCS_CMD(0xE3, 0x4C), + _INIT_DCS_CMD(0xE4, 0x4A), + _INIT_DCS_CMD(0xE5, 0x48), + _INIT_DCS_CMD(0xE6, 0x46), + _INIT_DCS_CMD(0xE7, 0x42), + _INIT_DCS_CMD(0xB0, 0x03), + _INIT_DCS_CMD(0xBE, 0x03), + _INIT_DCS_CMD(0xCC, 0x44), + _INIT_DCS_CMD(0xC8, 0x07), + _INIT_DCS_CMD(0xC9, 0x05), + _INIT_DCS_CMD(0xCA, 0x42), + _INIT_DCS_CMD(0xCD, 0x3E), + _INIT_DCS_CMD(0xCF, 0x60), + _INIT_DCS_CMD(0xD2, 0x04), + _INIT_DCS_CMD(0xD3, 0x04), + _INIT_DCS_CMD(0xD4, 0x01), + _INIT_DCS_CMD(0xD5, 0x00), + _INIT_DCS_CMD(0xD6, 0x03), + _INIT_DCS_CMD(0xD7, 0x04), + _INIT_DCS_CMD(0xD9, 0x01), + _INIT_DCS_CMD(0xDB, 0x01), + _INIT_DCS_CMD(0xE4, 0xF0), + _INIT_DCS_CMD(0xE5, 0x0A), + _INIT_DCS_CMD(0xB0, 0x00), + _INIT_DCS_CMD(0xCC, 0x08), + _INIT_DCS_CMD(0xC2, 0x08), + _INIT_DCS_CMD(0xC4, 0x10), + _INIT_DCS_CMD(0xB0, 0x02), + _INIT_DCS_CMD(0xC0, 0x00), + _INIT_DCS_CMD(0xC1, 0x0A), + _INIT_DCS_CMD(0xC2, 0x20), + _INIT_DCS_CMD(0xC3, 0x24), + _INIT_DCS_CMD(0xC4, 0x23), + _INIT_DCS_CMD(0xC5, 0x29), + _INIT_DCS_CMD(0xC6, 0x23), + _INIT_DCS_CMD(0xC7, 0x1C), + _INIT_DCS_CMD(0xC8, 0x19), + _INIT_DCS_CMD(0xC9, 0x17), + _INIT_DCS_CMD(0xCA, 0x17), + _INIT_DCS_CMD(0xCB, 0x18), + _INIT_DCS_CMD(0xCC, 0x1A), + _INIT_DCS_CMD(0xCD, 0x1E), + _INIT_DCS_CMD(0xCE, 0x20), + _INIT_DCS_CMD(0xCF, 0x23), + _INIT_DCS_CMD(0xD0, 0x07), + _INIT_DCS_CMD(0xD1, 0x00), + _INIT_DCS_CMD(0xD2, 0x00), + _INIT_DCS_CMD(0xD3, 0x0A), + _INIT_DCS_CMD(0xD4, 0x13), + _INIT_DCS_CMD(0xD5, 0x1C), + _INIT_DCS_CMD(0xD6, 0x1A), + _INIT_DCS_CMD(0xD7, 0x13), + _INIT_DCS_CMD(0xD8, 0x17), + _INIT_DCS_CMD(0xD9, 0x1C), + _INIT_DCS_CMD(0xDA, 0x19), + _INIT_DCS_CMD(0xDB, 0x17), + _INIT_DCS_CMD(0xDC, 0x17), + _INIT_DCS_CMD(0xDD, 0x18), + _INIT_DCS_CMD(0xDE, 0x1A), + _INIT_DCS_CMD(0xDF, 0x1E), + _INIT_DCS_CMD(0xE0, 0x20), + _INIT_DCS_CMD(0xE1, 0x23), + _INIT_DCS_CMD(0xE2, 0x07), + _INIT_DCS_CMD(0X11), + _INIT_DELAY_CMD(120), + _INIT_DCS_CMD(0X29), + _INIT_DELAY_CMD(80), + {}, +}; + +static inline struct inx_panel *to_inx_panel(struct drm_panel *panel) +{ + return container_of(panel, struct inx_panel, base); +} + +static int inx_panel_init_dcs_cmd(struct inx_panel *inx) +{ + struct mipi_dsi_device *dsi = inx->dsi; + struct drm_panel *panel = &inx->base; + int i, err = 0; + + if (inx->desc->init_cmds) { + const struct panel_init_cmd *init_cmds = inx->desc->init_cmds; + + for (i = 0; init_cmds[i].len != 0; i++) { + const struct panel_init_cmd *cmd = &init_cmds[i]; + + switch (cmd->type) { + case DELAY_CMD: + msleep(cmd->data[0]); + err = 0; + break; + + case INIT_DCS_CMD: + err = mipi_dsi_dcs_write(dsi, cmd->data[0], + cmd->len <= 1 ? NULL : + &cmd->data[1], + cmd->len - 1); + break; + + default: + err = -EINVAL; + } + + if (err < 0) { + dev_err(panel->dev, + "failed to write command %u\n", i); + return err; + } + } + } + return 0; +} + +static int inx_panel_enter_sleep_mode(struct inx_panel *inx) +{ + struct mipi_dsi_device *dsi = inx->dsi; + int ret; + + dsi->mode_flags &= ~MIPI_DSI_MODE_LPM; + + ret = mipi_dsi_dcs_set_display_off(dsi); + if (ret < 0) + return ret; + + ret = mipi_dsi_dcs_enter_sleep_mode(dsi); + if (ret < 0) + return ret; + + return 0; +} + +static int inx_panel_unprepare(struct drm_panel *panel) +{ + struct inx_panel *inx = to_inx_panel(panel); + int ret; + + if (!inx->prepared) + return 0; + + ret = inx_panel_enter_sleep_mode(inx); + if (ret < 0) { + dev_err(panel->dev, "failed to set panel off: %d\n", ret); + return ret; + } + + msleep(150); + + if (inx->desc->discharge_on_disable) { + regulator_disable(inx->avee); + regulator_disable(inx->avdd); + usleep_range(5000, 7000); + gpiod_set_value(inx->enable_gpio, 0); + usleep_range(5000, 7000); + regulator_disable(inx->pp1800); + } else { + gpiod_set_value(inx->enable_gpio, 0); + usleep_range(500, 1000); + regulator_disable(inx->avee); + regulator_disable(inx->avdd); + usleep_range(5000, 7000); + regulator_disable(inx->pp1800); + } + + inx->prepared = false; + + return 0; +} + +static int inx_panel_prepare(struct drm_panel *panel) +{ + struct inx_panel *inx = to_inx_panel(panel); + int ret; + + if (inx->prepared) + return 0; + + gpiod_set_value(inx->enable_gpio, 0); + usleep_range(1000, 1500); + + ret = regulator_enable(inx->pp1800); + if (ret < 0) + return ret; + + usleep_range(3000, 5000); + + ret = regulator_enable(inx->avdd); + if (ret < 0) + goto poweroff1v8; + ret = regulator_enable(inx->avee); + if (ret < 0) + goto poweroffavdd; + + usleep_range(5000, 10000); + + gpiod_set_value(inx->enable_gpio, 1); + usleep_range(1000, 2000); + gpiod_set_value(inx->enable_gpio, 0); + usleep_range(1000, 2000); + gpiod_set_value(inx->enable_gpio, 1); + usleep_range(6000, 10000); + + ret = inx_panel_init_dcs_cmd(inx); + if (ret < 0) { + dev_err(panel->dev, "failed to init panel: %d\n", ret); + goto poweroff; + } + + inx->prepared = true; + + return 0; + +poweroff: + regulator_disable(inx->avee); +poweroffavdd: + regulator_disable(inx->avdd); +poweroff1v8: + usleep_range(5000, 7000); + regulator_disable(inx->pp1800); + gpiod_set_value(inx->enable_gpio, 0); + + return ret; +} + +static int inx_panel_enable(struct drm_panel *panel) +{ + msleep(130); + return 0; +} + +static const struct drm_display_mode starry_qfh032011_53g_default_mode = { + .clock = 165731, + .hdisplay = 1200, + .hsync_start = 1200 + 100, + .hsync_end = 1200 + 100 + 10, + .htotal = 1200 + 100 + 10 + 100, + .vdisplay = 1920, + .vsync_start = 1920 + 14, + .vsync_end = 1920 + 14 + 10, + .vtotal = 1920 + 14 + 10 + 15, +}; + +static const struct panel_desc starry_qfh032011_53g_desc = { + .modes = &starry_qfh032011_53g_default_mode, + .bpc = 8, + .size = { + .width_mm = 135, + .height_mm = 216, + }, + .lanes = 4, + .format = MIPI_DSI_FMT_RGB888, + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE | + MIPI_DSI_MODE_LPM, + .init_cmds = starry_qfh032011_53g_init_cmd, + .discharge_on_disable = false, +}; + +static int inx_panel_get_modes(struct drm_panel *panel, + struct drm_connector *connector) +{ + struct inx_panel *inx = to_inx_panel(panel); + const struct drm_display_mode *m = inx->desc->modes; + struct drm_display_mode *mode; + + mode = drm_mode_duplicate(connector->dev, m); + if (!mode) { + dev_err(panel->dev, "failed to add mode %ux%u@%u\n", + m->hdisplay, m->vdisplay, drm_mode_vrefresh(m)); + return -ENOMEM; + } + + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; + drm_mode_set_name(mode); + drm_mode_probed_add(connector, mode); + + connector->display_info.width_mm = inx->desc->size.width_mm; + connector->display_info.height_mm = inx->desc->size.height_mm; + connector->display_info.bpc = inx->desc->bpc; + drm_connector_set_panel_orientation(connector, inx->orientation); + + return 1; +} + +static const struct drm_panel_funcs inx_panel_funcs = { + .unprepare = inx_panel_unprepare, + .prepare = inx_panel_prepare, + .enable = inx_panel_enable, + .get_modes = inx_panel_get_modes, +}; + +static int inx_panel_add(struct inx_panel *inx) +{ + struct device *dev = &inx->dsi->dev; + int err; + + inx->avdd = devm_regulator_get(dev, "avdd"); + if (IS_ERR(inx->avdd)) + return PTR_ERR(inx->avdd); + + inx->avee = devm_regulator_get(dev, "avee"); + if (IS_ERR(inx->avee)) + return PTR_ERR(inx->avee); + + inx->pp1800 = devm_regulator_get(dev, "pp1800"); + if (IS_ERR(inx->pp1800)) + return PTR_ERR(inx->pp1800); + + inx->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW); + if (IS_ERR(inx->enable_gpio)) { + dev_err(dev, "cannot get reset-gpios %ld\n", + PTR_ERR(inx->enable_gpio)); + return PTR_ERR(inx->enable_gpio); + } + + gpiod_set_value(inx->enable_gpio, 0); + + drm_panel_init(&inx->base, dev, &inx_panel_funcs, + DRM_MODE_CONNECTOR_DSI); + err = of_drm_get_panel_orientation(dev->of_node, &inx->orientation); + if (err < 0) { + dev_err(dev, "%pOF: failed to get orientation %d\n", dev->of_node, err); + return err; + } + + err = drm_panel_of_backlight(&inx->base); + if (err) + return err; + + inx->base.funcs = &inx_panel_funcs; + inx->base.dev = &inx->dsi->dev; + + drm_panel_add(&inx->base); + + return 0; +} + +static int inx_panel_probe(struct mipi_dsi_device *dsi) +{ + struct inx_panel *inx; + int ret; + const struct panel_desc *desc; + + inx = devm_kzalloc(&dsi->dev, sizeof(*inx), GFP_KERNEL); + if (!inx) + return -ENOMEM; + + desc = of_device_get_match_data(&dsi->dev); + dsi->lanes = desc->lanes; + dsi->format = desc->format; + dsi->mode_flags = desc->mode_flags; + inx->desc = desc; + inx->dsi = dsi; + ret = inx_panel_add(inx); + if (ret < 0) + return ret; + + mipi_dsi_set_drvdata(dsi, inx); + + ret = mipi_dsi_attach(dsi); + if (ret) + drm_panel_remove(&inx->base); + + return ret; +} + +static void inx_panel_shutdown(struct mipi_dsi_device *dsi) +{ + struct inx_panel *inx = mipi_dsi_get_drvdata(dsi); + + drm_panel_disable(&inx->base); + drm_panel_unprepare(&inx->base); +} + +static int inx_panel_remove(struct mipi_dsi_device *dsi) +{ + struct inx_panel *inx = mipi_dsi_get_drvdata(dsi); + int ret; + + inx_panel_shutdown(dsi); + + ret = mipi_dsi_detach(dsi); + if (ret < 0) + dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); + + if (inx->base.dev) + drm_panel_remove(&inx->base); + + return 0; +} + +static const struct of_device_id inx_of_match[] = { + { .compatible = "starry,2081101qfh032011-53g", + .data = &starry_qfh032011_53g_desc + }, + { /* sentinel */ } +}; +MODULE_DEVICE_TABLE(of, inx_of_match); + +static struct mipi_dsi_driver inx_panel_driver = { + .driver = { + .name = "panel-innolux-himax8279d", + .of_match_table = inx_of_match, + }, + .probe = inx_panel_probe, + .remove = inx_panel_remove, + .shutdown = inx_panel_shutdown, +}; +module_mipi_dsi_driver(inx_panel_driver); + +MODULE_AUTHOR("Zhengqiao Xia xiazhengqiao@huaqin.corp-partner.google.com"); +MODULE_DESCRIPTION("INNOLUX HIMAX8279D 1200x1920 video mode panel driver"); +MODULE_LICENSE("GPL v2");
dri-devel@lists.freedesktop.org
-
kernel test robot -
Zhengqiao Xia