This patch was initially sent along with another one to fix a first hang in the nouveau drm driver[1]. I'm now sending it again as a separate patch as it's to fix a second hang which is not strictly related. It is hidden by the first hang though, as this happens later on during the driver initialisation.
The issue this is addressing is due to a rework[2] of the driver which apparently wasn't fully tested on tegra124 and possibly also on tegra210. The sor->clk_out is not used on these platforms as HDMI and DP are both not supported (but eDP is), so trying to assign the parent clock to clk_out does nothing. The driver then goes on to configure the clock and PLL registers in tegra_sor_edp_enable and this is where it hangs.
As this is hard to debug further without full documentation or a hardware debugger, this patch essentially makes the driver do what it used to do on these platforms before the rework (i.e. assign the parent clock to sor->clk instead). There might be a more correct way of fixing this, hence the RFC.
[1] https://patchwork.kernel.org/patch/10124637/ [2] e1335e2f0cfc ("drm/tegra: sor: Reimplement pad clock")
Guillaume Tucker (1): drm/tegra: sor: Fix hang on tegra124 due to NULL clk_out
drivers/gpu/drm/tegra/sor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
-- 2.11.0
When neither HDMI nor DP is supported such as on the tegra124, the sor->clk_out is not initialised and remains NULL. In this case, the parent clock can't be assigned to it so revert to the previous behaviour of assigning it to the main sor->clk instead.
This fixes a kernel hang on tegra124 and should also affect tegra210 as they both don't support HDMI and DP. Tested on tegra124 only.
Fixes: e1335e2f0cfc ("drm/tegra: sor: Reimplement pad clock") Signed-off-by: Guillaume Tucker guillaume.tucker@collabora.com CC: Thierry Reding treding@nvidia.com --- drivers/gpu/drm/tegra/sor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index b0a1dedac802..a344f66d4ecb 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c @@ -255,7 +255,7 @@ static int tegra_sor_set_parent_clock(struct tegra_sor *sor, struct clk *parent)
clk_disable_unprepare(sor->clk);
- err = clk_set_parent(sor->clk_out, parent); + err = clk_set_parent(sor->clk_out ? sor->clk_out : sor->clk, parent); if (err < 0) return err;
On Wed, Dec 20, 2017 at 11:32:23AM +0000, Guillaume Tucker wrote:
When neither HDMI nor DP is supported such as on the tegra124, the sor->clk_out is not initialised and remains NULL. In this case, the parent clock can't be assigned to it so revert to the previous behaviour of assigning it to the main sor->clk instead.
This fixes a kernel hang on tegra124 and should also affect tegra210 as they both don't support HDMI and DP. Tested on tegra124 only.
Fixes: e1335e2f0cfc ("drm/tegra: sor: Reimplement pad clock") Signed-off-by: Guillaume Tucker guillaume.tucker@collabora.com CC: Thierry Reding treding@nvidia.com
drivers/gpu/drm/tegra/sor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
How about just the below instead? It's one more line than your patch, but it will automatically handle all occurrences of clk_out properly.
--- >8 --- diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index f6313c4d612e..4be9edf9c6fe 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c @@ -3047,6 +3047,8 @@ static int tegra_sor_probe(struct platform_device *pdev) name, err); goto remove; } + } else { + sor->clk_out = sor->clk; }
sor->clk_parent = devm_clk_get(&pdev->dev, "parent"); --- >8 ---
That said, I suspect the SOR might be compatible from a clock point of view with later versions and perhaps we just didn't implement clocks correctly back in the Tegra124 timeframe.
Maybe Peter knows.
Thierry
On 20/12/17 18:15, Thierry Reding wrote:
On Wed, Dec 20, 2017 at 11:32:23AM +0000, Guillaume Tucker wrote:
When neither HDMI nor DP is supported such as on the tegra124, the sor->clk_out is not initialised and remains NULL. In this case, the parent clock can't be assigned to it so revert to the previous behaviour of assigning it to the main sor->clk instead.
This fixes a kernel hang on tegra124 and should also affect tegra210 as they both don't support HDMI and DP. Tested on tegra124 only.
Fixes: e1335e2f0cfc ("drm/tegra: sor: Reimplement pad clock") Signed-off-by: Guillaume Tucker guillaume.tucker@collabora.com CC: Thierry Reding treding@nvidia.com
drivers/gpu/drm/tegra/sor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
How about just the below instead? It's one more line than your patch, but it will automatically handle all occurrences of clk_out properly.
--- >8 --- diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index f6313c4d612e..4be9edf9c6fe 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c @@ -3047,6 +3047,8 @@ static int tegra_sor_probe(struct platform_device *pdev) name, err); goto remove; }
} else {sor->clk_out = sor->clk; } sor->clk_parent = devm_clk_get(&pdev->dev, "parent");--- >8 ---
That said, I suspect the SOR might be compatible from a clock point of view with later versions and perhaps we just didn't implement clocks correctly back in the Tegra124 timeframe.
Maybe Peter knows.
So the above change from Thierry works for me and we need this for v4.15 (otherwise nyan-big does not boot) so you can have my ...
Tested-by: Jon Hunter jonathanh@nvidia.com
However, would be good to have Peter's ACK, especially seeing that Tegra210 sor0 does not support HDMI and DP. So we need to make sure this is correct for Tegra210 as well (although I have not seen any regressions for Tegra210).
Cheers Jon
On Tue, Jan 02, 2018 at 06:32:11PM +0000, Jon Hunter wrote:
On 20/12/17 18:15, Thierry Reding wrote:
On Wed, Dec 20, 2017 at 11:32:23AM +0000, Guillaume Tucker wrote:
When neither HDMI nor DP is supported such as on the tegra124, the sor->clk_out is not initialised and remains NULL. In this case, the parent clock can't be assigned to it so revert to the previous behaviour of assigning it to the main sor->clk instead.
This fixes a kernel hang on tegra124 and should also affect tegra210 as they both don't support HDMI and DP. Tested on tegra124 only.
Fixes: e1335e2f0cfc ("drm/tegra: sor: Reimplement pad clock") Signed-off-by: Guillaume Tucker guillaume.tucker@collabora.com CC: Thierry Reding treding@nvidia.com
drivers/gpu/drm/tegra/sor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
How about just the below instead? It's one more line than your patch, but it will automatically handle all occurrences of clk_out properly.
--- >8 --- diff --git a/drivers/gpu/drm/tegra/sor.c b/drivers/gpu/drm/tegra/sor.c index f6313c4d612e..4be9edf9c6fe 100644 --- a/drivers/gpu/drm/tegra/sor.c +++ b/drivers/gpu/drm/tegra/sor.c @@ -3047,6 +3047,8 @@ static int tegra_sor_probe(struct platform_device *pdev) name, err); goto remove; }
} else {sor->clk_out = sor->clk; } sor->clk_parent = devm_clk_get(&pdev->dev, "parent");--- >8 ---
That said, I suspect the SOR might be compatible from a clock point of view with later versions and perhaps we just didn't implement clocks correctly back in the Tegra124 timeframe.
Maybe Peter knows.
So the above change from Thierry works for me and we need this for v4.15 (otherwise nyan-big does not boot) so you can have my ...
Tested-by: Jon Hunter jonathanh@nvidia.com
However, would be good to have Peter's ACK, especially seeing that Tegra210 sor0 does not support HDMI and DP. So we need to make sure this is correct for Tegra210 as well (although I have not seen any regressions for Tegra210).
There are no Tegra210 boards with eDP or LVDS support, which are the only setups that are impacted by this.
I've sent out the above as a proper patch. I'll submit this for a late fixes pull request.
Thierry
dri-devel@lists.freedesktop.org
-
Guillaume Tucker -
Jon Hunter -
Thierry Reding