Hi all,
After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) produced this warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c: In function 'amdgpu_display_user_framebuffer_create': drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:929:24: warning: unused variable 'adev' [-Wunused-variable] 929 | struct amdgpu_device *adev = drm_to_adev(dev); | ^~~~
Introduced by commit
8f66090b7bb7 ("drm/amdgpu: Remove references to struct drm_device.pdev")
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function 'amdgpu_device_resize_fb_bar': drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1109:6: warning: unused variable 'space_needed' [-Wunused-variable] 1109 | u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size); | ^~~~~~~~~~~~
Introduced by commit
453f617a30aa ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")
Remove unused adev variable
Fixes: 8f66090b7bb7 ("drm/amdgpu: Remove references to struct drm_device.pdev") Reported-by: Stephen Rothwell sfr@canb.auug.org.au Signed-off-by: Nirmoy Das nirmoy.das@amd.com --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c index 0150a51b65ef..f764803c53a4 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c @@ -926,7 +926,6 @@ amdgpu_display_user_framebuffer_create(struct drm_device *dev, struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd) { - struct amdgpu_device *adev = drm_to_adev(dev); struct drm_gem_object *obj; struct amdgpu_framebuffer *amdgpu_fb; int ret;
On Fri, Jan 15, 2021 at 10:02 AM Nirmoy Das nirmoy.das@amd.com wrote:
Remove unused adev variable
Fixes: 8f66090b7bb7 ("drm/amdgpu: Remove references to struct drm_device.pdev") Reported-by: Stephen Rothwell sfr@canb.auug.org.au Signed-off-by: Nirmoy Das nirmoy.das@amd.com
Reviewed-by: Alex Deucher alexander.deucher@amd.com
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c index 0150a51b65ef..f764803c53a4 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c @@ -926,7 +926,6 @@ amdgpu_display_user_framebuffer_create(struct drm_device *dev, struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd) {
struct amdgpu_device *adev = drm_to_adev(dev); struct drm_gem_object *obj; struct amdgpu_framebuffer *amdgpu_fb; int ret;-- 2.29.2
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Stephen,
On 1/15/21 2:23 AM, Stephen Rothwell wrote:
Hi all,
After merging the drm-misc tree, today's linux-next build (x86_64 allmodconfig) produced this warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c: In function 'amdgpu_display_user_framebuffer_create': drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:929:24: warning: unused variable 'adev' [-Wunused-variable] 929 | struct amdgpu_device *adev = drm_to_adev(dev); | ^~~~
Introduced by commit
8f66090b7bb7 ("drm/amdgpu: Remove references to struct drm_device.pdev")
I just sent a patch for this.
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function 'amdgpu_device_resize_fb_bar': drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1109:6: warning: unused variable 'space_needed' [-Wunused-variable] 1109 | u64 space_needed = roundup_pow_of_two(adev->gmc.real_vram_size); | ^~~~~~~~~~~~
Introduced by commit
453f617a30aa ("drm/amdgpu: Resize BAR0 to the maximum available size, even if it doesn't cover VRAM")
We have a fix already merged in drm-misc-next for this.
Thanks,
Nirmoy
dri-devel@lists.freedesktop.org
-
Alex Deucher -
Nirmoy -
Nirmoy Das -
Stephen Rothwell