well.... it builds for me.
but any idea what might be wrong here on gitlab ci?
On Wed, Sep 5, 2018 at 4:20 PM GitLab gitlab@gitlab.freedesktop.org wrote:
[image: Fdo logo] [image: ✖] Your pipeline has failed.
Project Mesa https://gitlab.freedesktop.org/mesa / drm https://gitlab.freedesktop.org/mesa/drm Branch master https://gitlab.freedesktop.org/mesa/drm/commits/master Commit c55f1b9b https://gitlab.freedesktop.org/mesa/drm/commit/c55f1b9b29fe9ffa632497fe4accfeacadd4c7f6 intel: get gen once for gen >= 9 We don't need... Commit Author Lucas De Marchi Committed by Rodrigo Vivi
Pipeline #4114 https://gitlab.freedesktop.org/mesa/drm/pipelines/4114 triggered by Rodrigo Vivi https://gitlab.freedesktop.org/vivijim had 2 failed builds. Logs may contain sensitive data. Please consider before forwarding this email. [image: ✖] build oldest-meson https://gitlab.freedesktop.org/mesa/drm/-/jobs/22383
Full log written to /builds/mesa/drm/_build/meson-logs/testlog.txt Warning: You are using 'ANSI_X3.4-1968' which is not a Unicode-compatible locale. You might see errors if you use UTF-8 strings as filenames, as strings, or as file contents. Please switch to a UTF-8 locale for your platform. FAILED: meson-test /usr/bin/python3 /usr/local/bin/meson test --no-rebuild --print-errorlogs ninja: build stopped: subcommand failed. section_end:1536189512:build_script section_start:1536189512:after_script section_end:1536189513:after_script ERROR: Job failed: exit code 1
[image: ✖] build latest-meson https://gitlab.freedesktop.org/mesa/drm/-/jobs/22381
--- stdout --- intel_get_genx intel_is_genx
Full log written to /builds/mesa/drm/_build/meson-logs/testlog.txt FAILED: meson-test /usr/bin/python -u /usr/bin/meson test --no-rebuild --print-errorlogs ninja: build stopped: subcommand failed. section_end:1536189488:build_script section_start:1536189488:after_script section_end:1536189490:after_script ERROR: Job failed: exit code 1
[image: GitLab] You're receiving this email because of your account on gitlab.freedesktop.org. Manage all notifications https://gitlab.freedesktop.org/profile/notifications · Help https://gitlab.freedesktop.org/help
On Thu, Sep 6, 2018 at 4:00 AM, Rodrigo Vivi rodrigo.vivi@gmail.com wrote:
well.... it builds for me.
but any idea what might be wrong here on gitlab ci?
So ninja test works for you with your changes locally? Aside: Fork the drm repo into your own private space, push there before pushing to drm, and you can make sure it works before you break master :-) -Daniel
On Wed, Sep 5, 2018 at 4:20 PM GitLab gitlab@gitlab.freedesktop.org wrote:
[image: Fdo logo] [image: ✖] Your pipeline has failed.
Project Mesa https://gitlab.freedesktop.org/mesa / drm https://gitlab.freedesktop.org/mesa/drm Branch master https://gitlab.freedesktop.org/mesa/drm/commits/master Commit c55f1b9b https://gitlab.freedesktop.org/mesa/drm/commit/c55f1b9b29fe9ffa632497fe4accfeacadd4c7f6 intel: get gen once for gen >= 9 We don't need... Commit Author Lucas De Marchi Committed by Rodrigo Vivi
Pipeline #4114 https://gitlab.freedesktop.org/mesa/drm/pipelines/4114 triggered by Rodrigo Vivi https://gitlab.freedesktop.org/vivijim had 2 failed builds. Logs may contain sensitive data. Please consider before forwarding this email. [image: ✖] build oldest-meson https://gitlab.freedesktop.org/mesa/drm/-/jobs/22383
Full log written to /builds/mesa/drm/_build/meson-logs/testlog.txt Warning: You are using 'ANSI_X3.4-1968' which is not a Unicode-compatible locale. You might see errors if you use UTF-8 strings as filenames, as strings, or as file contents. Please switch to a UTF-8 locale for your platform. FAILED: meson-test /usr/bin/python3 /usr/local/bin/meson test --no-rebuild --print-errorlogs ninja: build stopped: subcommand failed. section_end:1536189512:build_script section_start:1536189512:after_script section_end:1536189513:after_script ERROR: Job failed: exit code 1
[image: ✖] build latest-meson https://gitlab.freedesktop.org/mesa/drm/-/jobs/22381
--- stdout --- intel_get_genx intel_is_genx
Full log written to /builds/mesa/drm/_build/meson-logs/testlog.txt FAILED: meson-test /usr/bin/python -u /usr/bin/meson test --no-rebuild --print-errorlogs ninja: build stopped: subcommand failed. section_end:1536189488:build_script section_start:1536189488:after_script section_end:1536189490:after_script ERROR: Job failed: exit code 1
[image: GitLab] You're receiving this email because of your account on gitlab.freedesktop.org. Manage all notifications https://gitlab.freedesktop.org/profile/notifications · Help https://gitlab.freedesktop.org/help
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Wed, Sep 5, 2018 at 7:00 PM Rodrigo Vivi rodrigo.vivi@gmail.com wrote:
well.... it builds for me.
but any idea what might be wrong here on gitlab ci?
From the logs:
The output from the failed tests:
8/21 intel-symbol-check FAIL 0.29 s (exit status 1)
--- command --- NM='/usr/sbin/nm' /usr/sbin/bash /builds/mesa/drm/_build/../intel/intel-symbol-check intel/libdrm_intel.so.1.0.0 --- stdout --- intel_get_genx intel_is_genx -------
So... it's not the build that fails, the test is checking for exported symbols, and it only does that when using meson (actually as part of the tests). And we don't use -fvisibility=hidden?!??! Ugh, I think we need some fixing on that :(
On Wed, Sep 5, 2018 at 4:20 PM GitLab gitlab@gitlab.freedesktop.org wrote:
Your pipeline has failed.
Project Mesa / drm Branch master Commit c55f1b9b intel: get gen once for gen >= 9 We don't need... Commit Author Lucas De Marchi Committed by Rodrigo Vivi
Pipeline #4114 triggered by Rodrigo Vivi had 2 failed builds. Logs may contain sensitive data. Please consider before forwarding this email. build oldest-meson
Full log written to /builds/mesa/drm/_build/meson-logs/testlog.txt Warning: You are using 'ANSI_X3.4-1968' which is not a Unicode-compatible locale. You might see errors if you use UTF-8 strings as filenames, as strings, or as file contents. Please switch to a UTF-8 locale for your platform. FAILED: meson-test /usr/bin/python3 /usr/local/bin/meson test --no-rebuild --print-errorlogs ninja: build stopped: subcommand failed. section_end:1536189512:build_script section_start:1536189512:after_script section_end:1536189513:after_script ERROR: Job failed: exit code 1
build latest-meson
--- stdout --- intel_get_genx intel_is_genx
Full log written to /builds/mesa/drm/_build/meson-logs/testlog.txt FAILED: meson-test /usr/bin/python -u /usr/bin/meson test --no-rebuild --print-errorlogs ninja: build stopped: subcommand failed. section_end:1536189488:build_script section_start:1536189488:after_script section_end:1536189490:after_script ERROR: Job failed: exit code 1
You're receiving this email because of your account on gitlab.freedesktop.org. Manage all notifications · Help
Hi,
On Thu, 6 Sep 2018 at 10:11, Lucas De Marchi lucas.de.marchi@gmail.com wrote:
On Wed, Sep 5, 2018 at 7:00 PM Rodrigo Vivi rodrigo.vivi@gmail.com wrote:
well.... it builds for me.
but any idea what might be wrong here on gitlab ci?
You can simulate what happens in CI by running the same script inside the same container. There's no magic setup on the CI runner.
From the logs:
The output from the failed tests:
8/21 intel-symbol-check FAIL 0.29 s (exit status 1)
--- command --- NM='/usr/sbin/nm' /usr/sbin/bash /builds/mesa/drm/_build/../intel/intel-symbol-check intel/libdrm_intel.so.1.0.0 --- stdout --- intel_get_genx intel_is_genx
So... it's not the build that fails, the test is checking for exported symbols, and it only does that when using meson (actually as part of the tests). And we don't use -fvisibility=hidden?!??! Ugh, I think we need some fixing on that :(
Yeah. It probably should be a bit more visible though. I sent a patch here: https://lists.freedesktop.org/archives/dri-devel/2018-September/188826.html
You can see the results here: https://gitlab.freedesktop.org/daniels/drm/pipelines/4130
And for example, from this failed job: https://gitlab.freedesktop.org/daniels/drm/-/jobs/22438
going to 'browse artifacts' (you can also just download the bundle) will lead you to this full test log: https://daniels.pages.freedesktop.org/-/drm/-/jobs/22438/artifacts/_build/me...
Cheers, Daniel
HI all,
On 6 September 2018 at 07:10, Lucas De Marchi lucas.de.marchi@gmail.com wrote:
On Wed, Sep 5, 2018 at 7:00 PM Rodrigo Vivi rodrigo.vivi@gmail.com wrote:
well.... it builds for me.
but any idea what might be wrong here on gitlab ci?
FWIW gitlab gives you the test target and command used. It might be a bit hard to find at first though :-\
FAILED: meson-test /usr/bin/python3 /usr/local/bin/meson test --no-rebuild --print-errorlogs
From the logs:
The output from the failed tests:
8/21 intel-symbol-check FAIL 0.29 s (exit status 1)
--- command --- NM='/usr/sbin/nm' /usr/sbin/bash /builds/mesa/drm/_build/../intel/intel-symbol-check intel/libdrm_intel.so.1.0.0 --- stdout --- intel_get_genx intel_is_genx
So... it's not the build that fails, the test is checking for exported symbols, and it only does that when using meson (actually as part of the tests). And we don't use -fvisibility=hidden?!??! Ugh, I think we need some fixing on that :(
I nuked it back in 0f8da82500ec542e269092c0718479e25eaff5f6 because weird compilers. I guess we can reconsider that?
On the other hand: git grep does point out to drm_private. Will send a patch in a moment, unless someone beats me to it.
-Emil
On Thu, Sep 6, 2018 at 8:11 AM Emil Velikov emil.l.velikov@gmail.com wrote:
HI all,
On 6 September 2018 at 07:10, Lucas De Marchi lucas.de.marchi@gmail.com wrote:
On Wed, Sep 5, 2018 at 7:00 PM Rodrigo Vivi rodrigo.vivi@gmail.com wrote:
well.... it builds for me.
but any idea what might be wrong here on gitlab ci?
FWIW gitlab gives you the test target and command used. It might be a bit hard to find at first though :-\
FAILED: meson-test /usr/bin/python3 /usr/local/bin/meson test --no-rebuild --print-errorlogs
From the logs:
The output from the failed tests:
8/21 intel-symbol-check FAIL 0.29 s (exit status 1)
--- command --- NM='/usr/sbin/nm' /usr/sbin/bash /builds/mesa/drm/_build/../intel/intel-symbol-check intel/libdrm_intel.so.1.0.0 --- stdout --- intel_get_genx intel_is_genx
So... it's not the build that fails, the test is checking for exported symbols, and it only does that when using meson (actually as part of the tests). And we don't use -fvisibility=hidden?!??! Ugh, I think we need some fixing on that :(
I nuked it back in 0f8da82500ec542e269092c0718479e25eaff5f6 because weird compilers. I guess we can reconsider that?
I think we should reconsider. Having the default visibility as hidden is the sanest thing to do to avoid problems of exporting what we shoulnd't in a release. But even before that commit you pointed, it only had the attributes to make a function private/public, but the default was to export... do drm_public was basically a nop.
I know several libraries that use visibility=hidden for a very long time and also maintain compatibility with several "embedded toolchains". IMO If the compiler is that broken, then I think we'd better workaround when building with that specific compiler if possible or declare it as not supported.
On the other hand: git grep does point out to drm_private. Will send a patch in a moment, unless someone beats me to it.
I missed that, thanks. For a short-term fix, I think adding drm_private attribute is reasonable, sorry for the breakage.
Lucas De Marchi
-Emil
dri-devel@lists.freedesktop.org
-
Daniel Stone -
Daniel Vetter -
Emil Velikov -
Lucas De Marchi -
Rodrigo Vivi