Push a few patches that has been sitting in my tree for far too long time. Adds a few more panels to panel-simple, including documentation of the compatible.
I have added the last few people that added new panels to panel-simple to the cc list, in the hope to speed up the review process a little.
Sam
Sam Ravnborg (6): dt-bindings: panel: add Seiko 70WVW2T 7" panel drm: panel-simple: add Seiko 70WVW2T 7" simple panel dt-bindings: panel: add Hitachi 3,5" QVGA panel drm: panel-simple: add Hitachi 3.5" QVGA panel dt-bindings: panel: add LOGIC Technologies panels drm: panel-simple: add LOGIC Technologies panels
.../bindings/display/panel/panel-simple.yaml | 8 ++ drivers/gpu/drm/panel/panel-simple.c | 127 +++++++++++++++++++++ 2 files changed, 135 insertions(+)
Add compatible for Seiko Instruments 7" TFT LCD. This panel is a dumb panel that matches the panel-simple binding.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Søren Andersen san@skov.dk Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml index d6cca1479633..60cc093fbd75 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml @@ -239,6 +239,8 @@ properties: - sharp,ls020b1dd01d # Shelly SCA07010-BFN-LNN 7.0" WVGA TFT LCD panel - shelly,sca07010-bfn-lnn + # Seiko Instruments Inc. 7.0" WVGA (800x480) TFT with Touch-Panel + - sii,70wvw2t # Starry KR070PE2T 7" WVGA TFT LCD panel - starry,kr070pe2t # Starry 12.2" (1920x1200 pixels) TFT LCD panel
On Mon, 01 Jun 2020 10:33:04 +0200, Sam Ravnborg wrote:
Add compatible for Seiko Instruments 7" TFT LCD. This panel is a dumb panel that matches the panel-simple binding.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Søren Andersen san@skov.dk Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+)
Acked-by: Rob Herring robh@kernel.org
The Seiko 70WVW2T is a discontinued product, but may be used somewhere. Tested on a proprietary product.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Søren Andersen san@skov.dk Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org --- drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index b067f66cea0e..8624bb80108c 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -3194,6 +3194,31 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = { .bus_format = MEDIA_BUS_FMT_RGB666_1X18, };
+static const struct drm_display_mode sii_70wvw2t_mode = { + .clock = 33000, + .hdisplay = 800, + .hsync_start = 800 + 256, + .hsync_end = 800 + 256 + 0, + .htotal = 800 + 256 + 0 + 0, + .vdisplay = 480, + .vsync_start = 480 + 0, + .vsync_end = 480 + 0 + 0, + .vtotal = 480 + 0 + 0 + 45, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +}; + +static const struct panel_desc sii_70wvw2t = { + .modes = &sii_70wvw2t_mode, + .num_modes = 1, + .size = { + .width = 152, + .height = 91, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_PIXDATA_POSEDGE, + .connector_type = DRM_MODE_CONNECTOR_DPI, +}; + static const struct drm_display_mode starry_kr070pe2t_mode = { .clock = 33000, .hdisplay = 800, @@ -3877,6 +3902,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "shelly,sca07010-bfn-lnn", .data = &shelly_sca07010_bfn_lnn, + }, { + .compatible = "sii,70wvw2t", + .data = &sii_70wvw2t, }, { .compatible = "starry,kr070pe2t", .data = &starry_kr070pe2t,
Hi,
On Mon, Jun 1, 2020 at 1:33 AM Sam Ravnborg sam@ravnborg.org wrote:
The Seiko 70WVW2T is a discontinued product, but may be used somewhere. Tested on a proprietary product.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Søren Andersen san@skov.dk Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org
drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index b067f66cea0e..8624bb80108c 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -3194,6 +3194,31 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = { .bus_format = MEDIA_BUS_FMT_RGB666_1X18, };
+static const struct drm_display_mode sii_70wvw2t_mode = {
.clock = 33000,.hdisplay = 800,.hsync_start = 800 + 256,.hsync_end = 800 + 256 + 0,.htotal = 800 + 256 + 0 + 0,.vdisplay = 480,.vsync_start = 480 + 0,.vsync_end = 480 + 0 + 0,.vtotal = 480 + 0 + 0 + 45,
Important to have a "vrefresh"?
.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,+};
+static const struct panel_desc sii_70wvw2t = {
.modes = &sii_70wvw2t_mode,.num_modes = 1,
Do we want "bpc = 6"?
.size = {.width = 152,.height = 91,},.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
Should this be a 666 format? Random internet-found data sheet says 262K colors...
On Tue, 2 Jun 2020 at 01:31, Doug Anderson dianders@chromium.org wrote:
Hi,
On Mon, Jun 1, 2020 at 1:33 AM Sam Ravnborg sam@ravnborg.org wrote:
The Seiko 70WVW2T is a discontinued product, but may be used somewhere. Tested on a proprietary product.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Søren Andersen san@skov.dk Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org
drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index b067f66cea0e..8624bb80108c 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -3194,6 +3194,31 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = { .bus_format = MEDIA_BUS_FMT_RGB666_1X18, };
+static const struct drm_display_mode sii_70wvw2t_mode = {
.clock = 33000,.hdisplay = 800,.hsync_start = 800 + 256,.hsync_end = 800 + 256 + 0,.htotal = 800 + 256 + 0 + 0,.vdisplay = 480,.vsync_start = 480 + 0,.vsync_end = 480 + 0 + 0,.vtotal = 480 + 0 + 0 + 45,Important to have a "vrefresh"?
Ville posted a series (most of which already landed) getting removing vrefresh all together. The overall idea is to compute it, in the rare case it's needed.
.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,+};
+static const struct panel_desc sii_70wvw2t = {
.modes = &sii_70wvw2t_mode,.num_modes = 1,Do we want "bpc = 6"?
The largest user of bpc is userspace - the data gets copied via the ioctls.
A secondary, and quite limited, user are drivers exposing the "max bpc" connector property. From a quick look: amdgpu, the synopsys dw-hdmi bridge and i915 do so. In case the data missing, atomics assume a max 8 bpc.
.size = {.width = 152,.height = 91,},.bus_format = MEDIA_BUS_FMT_RGB888_1X24,Should this be a 666 format? Random internet-found data sheet says 262K colors...
Good catch. Would be nice to have a spec sheet link (even if random) in the commit message.
HTH -Emil
Hi Doug.
On Mon, Jun 01, 2020 at 05:31:06PM -0700, Doug Anderson wrote:
Hi,
On Mon, Jun 1, 2020 at 1:33 AM Sam Ravnborg sam@ravnborg.org wrote:
The Seiko 70WVW2T is a discontinued product, but may be used somewhere. Tested on a proprietary product.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Søren Andersen san@skov.dk Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org
drivers/gpu/drm/panel/panel-simple.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index b067f66cea0e..8624bb80108c 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -3194,6 +3194,31 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = { .bus_format = MEDIA_BUS_FMT_RGB666_1X18, };
+static const struct drm_display_mode sii_70wvw2t_mode = {
.clock = 33000,.hdisplay = 800,.hsync_start = 800 + 256,.hsync_end = 800 + 256 + 0,.htotal = 800 + 256 + 0 + 0,.vdisplay = 480,.vsync_start = 480 + 0,.vsync_end = 480 + 0 + 0,.vtotal = 480 + 0 + 0 + 45,Important to have a "vrefresh"?
.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,+};
+static const struct panel_desc sii_70wvw2t = {
.modes = &sii_70wvw2t_mode,.num_modes = 1,Do we want "bpc = 6"?
.size = {.width = 152,.height = 91,},.bus_format = MEDIA_BUS_FMT_RGB888_1X24,Should this be a 666 format? Random internet-found data sheet says 262K colors...
Thanks for catching this! You are indeed right, this is MEDIA_BUS_FMT_RGB666_1X18 and only bpc = 6. My bad excuse is that other displays for the same HW is RGB888 and bpc = 8.
Will fix and repost.
Sam
This panel is used on evaluation boards for Atmel at91sam9261 and at91sam6263.
The panel is named: TX09D71VM1CCA
The panel is a dumb panel that matches the panel-simple binding
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org --- .../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml index 60cc093fbd75..6fe0ac86696d 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml @@ -133,6 +133,8 @@ properties: - hannstar,hsd070pww1 # HannStar Display Corp. HSD100PXN1 10.1" XGA LVDS panel - hannstar,hsd100pxn1 + # Hitachi Ltd. Corporation 3,5" QVGA (240x320) TFT LCD panel + - hit,tx09d71vm1cca # Hitachi Ltd. Corporation 9" WVGA (800x480) TFT LCD panel - hit,tx23d38vm0caa # InfoVision Optoelectronics M133NWF4 R0 13.3" FHD (1920x1080) TFT LCD panel
On Mon, 01 Jun 2020 10:33:06 +0200, Sam Ravnborg wrote:
This panel is used on evaluation boards for Atmel at91sam9261 and at91sam6263.
The panel is named: TX09D71VM1CCA
The panel is a dumb panel that matches the panel-simple binding
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org
.../devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+)
Acked-by: Rob Herring robh@kernel.org
This panel is used on evaluation boards for Atmel at91sam9261 and at91sam6263.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org --- drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 8624bb80108c..25c96639631f 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1813,6 +1813,32 @@ static const struct panel_desc hannstar_hsd100pxn1 = { .connector_type = DRM_MODE_CONNECTOR_LVDS, };
+static const struct drm_display_mode hitachi_tx09d71vm1cca_mode = { + .clock = 4965000, + .hdisplay = 240, + .hsync_start = 240 + 0, + .hsync_end = 240 + 0 + 5, + .htotal = 240 + 0 + 5 + 1, + .vdisplay = 320, + .vsync_start = 320 + 0, + .vsync_end = 320 + 0 + 1, + .vtotal = 320 + 0 + 1 + 1, + .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_NVSYNC, +}; + +static const struct panel_desc hitachi_tx09d71vm1cca = { + .modes = &hitachi_tx09d71vm1cca_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 54, + .height = 72, + }, + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_NEGEDGE, + .connector_type = DRM_MODE_CONNECTOR_DPI, +}; + static const struct drm_display_mode hitachi_tx23d38vm0caa_mode = { .clock = 33333, .hdisplay = 800, @@ -3737,6 +3763,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "hannstar,hsd100pxn1", .data = &hannstar_hsd100pxn1, + }, { + .compatible = "hit,tx09d71vm1cca", + .data = &hitachi_tx09d71vm1cca, }, { .compatible = "hit,tx23d38vm0caa", .data = &hitachi_tx23d38vm0caa
Hi,
On Mon, Jun 1, 2020 at 1:33 AM Sam Ravnborg sam@ravnborg.org wrote:
This panel is used on evaluation boards for Atmel at91sam9261 and at91sam6263.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org
drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 8624bb80108c..25c96639631f 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1813,6 +1813,32 @@ static const struct panel_desc hannstar_hsd100pxn1 = { .connector_type = DRM_MODE_CONNECTOR_LVDS, };
+static const struct drm_display_mode hitachi_tx09d71vm1cca_mode = {
.clock = 4965000,
This is the pixel clock in kHz, right? So it runs at almost 5 Terahertz?
.hdisplay = 240,.hsync_start = 240 + 0,.hsync_end = 240 + 0 + 5,.htotal = 240 + 0 + 5 + 1,.vdisplay = 320,.vsync_start = 320 + 0,.vsync_end = 320 + 0 + 1,.vtotal = 320 + 0 + 1 + 1,
Some random datasheet I found has really different numbers. If the numbers above are what everyone is using then I suppose it's fine, just curious why the mismatch.
Also: should you provide "vrefresh"?
-Doug
Hi Doug.
On Mon, Jun 01, 2020 at 05:30:53PM -0700, Doug Anderson wrote:
Hi,
On Mon, Jun 1, 2020 at 1:33 AM Sam Ravnborg sam@ravnborg.org wrote:
This panel is used on evaluation boards for Atmel at91sam9261 and at91sam6263.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org
drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 8624bb80108c..25c96639631f 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1813,6 +1813,32 @@ static const struct panel_desc hannstar_hsd100pxn1 = { .connector_type = DRM_MODE_CONNECTOR_LVDS, };
+static const struct drm_display_mode hitachi_tx09d71vm1cca_mode = {
.clock = 4965000,This is the pixel clock in kHz, right? So it runs at almost 5 Terahertz?
.hdisplay = 240,.hsync_start = 240 + 0,.hsync_end = 240 + 0 + 5,.htotal = 240 + 0 + 5 + 1,.vdisplay = 320,.vsync_start = 320 + 0,.vsync_end = 320 + 0 + 1,.vtotal = 320 + 0 + 1 + 1,Some random datasheet I found has really different numbers. If the numbers above are what everyone is using then I suppose it's fine, just curious why the mismatch.
The timing comes from: arch/arm/boot/dts/at91sam9263ek.dts - that include display timings for the panel on the evaluation board. I did not verify any datasheet - I just blindly copied what was there. And clock was obviously not properly adjusted to khz.
Will fix in v2 - will also try to find a datasheet this time.
Thanks for noticing!
Sam
Add support for the following panels from LOGIC Technologies, Inc: - LTTD800480070-L2RT - LTTD800480070-L6WH-RT
The LTTD800480 L2RT is discontinued, but it may be used in existing products.
Both panels are dumb panels that matches the panel-simple binding.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Søren Andersen san@skov.dk Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org --- .../devicetree/bindings/display/panel/panel-simple.yaml | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml index 6fe0ac86696d..a4910d4af96b 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml @@ -183,6 +183,10 @@ properties: - logictechno,lt161010-2nhr # Logic Technologies LT170410-2WHC 10.1" 1280x800 IPS TFT Cap Touch Mod. - logictechno,lt170410-2whc + # LOGIC Technologies Inc. LTTD800480070-L2RT 7" (800x480) TFT LCD panel + - logictechno,lttd800480070-l2rt + # LOGIC Technologies Inc. LTTD800480070-L6WH-RT 7" (800x480) TFT LCD panel + - logictechno,lttd800480070-l6wh-rt # Mitsubishi "AA070MC01 7.0" WVGA TFT LCD panel - mitsubishi,aa070mc01-ca1 # NEC LCD Technologies, Ltd. 12.1" WXGA (1280x800) LVDS TFT LCD panel
On Mon, 01 Jun 2020 10:33:08 +0200, Sam Ravnborg wrote:
Add support for the following panels from LOGIC Technologies, Inc:
- LTTD800480070-L2RT
- LTTD800480070-L6WH-RT
The LTTD800480 L2RT is discontinued, but it may be used in existing products.
Both panels are dumb panels that matches the panel-simple binding.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Søren Andersen san@skov.dk Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org
.../devicetree/bindings/display/panel/panel-simple.yaml | 4 ++++ 1 file changed, 4 insertions(+)
Acked-by: Rob Herring robh@kernel.org
Add support for the following panels from LOGIC Technologies, Inc: - LTTD800480070-L2RT - LTTD800480070-L6WH-RT
The LTTD800480 L2RT is discontinued, but it may be used by existing products.
Signed-off-by: Søren Andersen san@skov.dk Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Søren Andersen san@skov.dk Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org --- drivers/gpu/drm/panel/panel-simple.c | 70 ++++++++++++++++++++++++++++ 1 file changed, 70 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 25c96639631f..70d54164b1ae 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2428,6 +2428,70 @@ static const struct panel_desc logictechno_lt170410_2whc = { .connector_type = DRM_MODE_CONNECTOR_LVDS, };
+static const struct drm_display_mode logictechno_lttd800480070_l2rt_mode = { + .clock = 33000, + .hdisplay = 800, + .hsync_start = 800 + 112, + .hsync_end = 800 + 112 + 3, + .htotal = 800 + 112 + 3 + 85, + .vdisplay = 480, + .vsync_start = 480 + 38, + .vsync_end = 480 + 38 + 3, + .vtotal = 480 + 38 + 3 + 29, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +}; + +static const struct panel_desc logictechno_lttd800480070_l2rt = { + .modes = &logictechno_lttd800480070_l2rt_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 154, + .height = 86, + }, + .delay = { + .prepare = 45, + .enable = 100, + .disable = 100, + .unprepare = 45 + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_PIXDATA_POSEDGE, + .connector_type = DRM_MODE_CONNECTOR_DPI, +}; + +static const struct drm_display_mode logictechno_lttd800480070_l6wh_rt_mode = { + .clock = 33000, + .hdisplay = 800, + .hsync_start = 800 + 154, + .hsync_end = 800 + 154 + 3, + .htotal = 800 + 154 + 3 + 43, + .vdisplay = 480, + .vsync_start = 480 + 47, + .vsync_end = 480 + 47 + 3, + .vtotal = 480 + 47 + 3 + 20, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +}; + +static const struct panel_desc logictechno_lttd800480070_l6wh_rt = { + .modes = &logictechno_lttd800480070_l6wh_rt_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 154, + .height = 86, + }, + .delay = { + .prepare = 45, + .enable = 100, + .disable = 100, + .unprepare = 45 + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_PIXDATA_POSEDGE, + .connector_type = DRM_MODE_CONNECTOR_DPI, +}; + static const struct drm_display_mode mitsubishi_aa070mc01_mode = { .clock = 30400, .hdisplay = 800, @@ -3841,6 +3905,12 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "logictechno,lt170410-2whc", .data = &logictechno_lt170410_2whc, + }, { + .compatible = "logictechno,lttd800480070-l2rt", + .data = &logictechno_lttd800480070_l2rt, + }, { + .compatible = "logictechno,lttd800480070-l6wh-rt", + .data = &logictechno_lttd800480070_l6wh_rt, }, { .compatible = "mitsubishi,aa070mc01-ca1", .data = &mitsubishi_aa070mc01,
Hi,
On Mon, Jun 1, 2020 at 1:33 AM Sam Ravnborg sam@ravnborg.org wrote:
+static const struct drm_display_mode logictechno_lttd800480070_l6wh_rt_mode = {
.clock = 33000,.hdisplay = 800,.hsync_start = 800 + 154,.hsync_end = 800 + 154 + 3,.htotal = 800 + 154 + 3 + 43,.vdisplay = 480,.vsync_start = 480 + 47,.vsync_end = 480 + 47 + 3,.vtotal = 480 + 47 + 3 + 20,.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
This is different than the "typ" mode from the random spreadsheet I found on the internet:
https://logictechno.com/wp-content/uploads/2016/11/LTTD800480070-L6WH-RT-v1....
As per my other comments, I wonder how important "vrefresh" is and if we should include it.
-Doug
dri-devel@lists.freedesktop.org
-
Doug Anderson -
Emil Velikov -
Rob Herring -
Sam Ravnborg