Instead of dumping unprocessed dwords, dump the last 64 dwords of the ring. This make debugging of some case easier.
Signed-off-by: Jerome Glisse jglisse@redhat.com --- drivers/gpu/drm/radeon/r600.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index f68cc92..1537079 100644 --- a/drivers/gpu/drm/radeon/r600.c +++ b/drivers/gpu/drm/radeon/r600.c @@ -3371,9 +3371,9 @@ static int r600_debugfs_cp_ring_info(struct seq_file *m, void *data) seq_printf(m, "driver's copy of the CP_RB_RPTR 0x%08x\n", rdev->cp.rptr); seq_printf(m, "%u free dwords in ring\n", rdev->cp.ring_free_dw); seq_printf(m, "%u dwords in ring\n", count); - i = rdev->cp.rptr; - for (j = 0; j <= count; j++) { - seq_printf(m, "r[%04d]=0x%08x\n", i, rdev->cp.ring[i]); + i = (rdev->cp.wptr + (rdev->cp.ring_size / 4) - 64) & rdev->cp.ptr_mask; + for (j = 0; j <= 64; j++) { + seq_printf(m, "r[%04d]=0x%08X\n", i, rdev->cp.ring[i]); i = (i + 1) & rdev->cp.ptr_mask; } return 0;
2010/6/4 Jerome Glisse jglisse@redhat.com:
Instead of dumping unprocessed dwords, dump the last 64 dwords of the ring. This make debugging of some case easier.
Signed-off-by: Jerome Glisse jglisse@redhat.com
drivers/gpu/drm/radeon/r600.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index f68cc92..1537079 100644 --- a/drivers/gpu/drm/radeon/r600.c +++ b/drivers/gpu/drm/radeon/r600.c @@ -3371,9 +3371,9 @@ static int r600_debugfs_cp_ring_info(struct seq_file *m, void *data) seq_printf(m, "driver's copy of the CP_RB_RPTR 0x%08x\n", rdev->cp.rptr); seq_printf(m, "%u free dwords in ring\n", rdev->cp.ring_free_dw); seq_printf(m, "%u dwords in ring\n", count);
- i = rdev->cp.rptr;
- for (j = 0; j <= count; j++) {
- seq_printf(m, "r[%04d]=0x%08x\n", i, rdev->cp.ring[i]);
- i = (rdev->cp.wptr + (rdev->cp.ring_size / 4) - 64) & rdev->cp.ptr_mask;
- for (j = 0; j <= 64; j++) {
- seq_printf(m, "r[%04d]=0x%08X\n", i, rdev->cp.ring[i]);
i = (i + 1) & rdev->cp.ptr_mask; } return 0; -- 1.7.0.1
What about same for r1xx-r5xx? Could you care?
On Fri, Jun 04, 2010 at 02:54:42PM +0200, Rafał Miłecki wrote:
2010/6/4 Jerome Glisse jglisse@redhat.com:
Instead of dumping unprocessed dwords, dump the last 64 dwords of the ring. This make debugging of some case easier.
Signed-off-by: Jerome Glisse jglisse@redhat.com
drivers/gpu/drm/radeon/r600.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index f68cc92..1537079 100644 --- a/drivers/gpu/drm/radeon/r600.c +++ b/drivers/gpu/drm/radeon/r600.c @@ -3371,9 +3371,9 @@ static int r600_debugfs_cp_ring_info(struct seq_file *m, void *data) seq_printf(m, "driver's copy of the CP_RB_RPTR 0x%08x\n", rdev->cp.rptr); seq_printf(m, "%u free dwords in ring\n", rdev->cp.ring_free_dw); seq_printf(m, "%u dwords in ring\n", count);
- i = rdev->cp.rptr;
- for (j = 0; j <= count; j++) {
- seq_printf(m, "r[%04d]=0x%08x\n", i, rdev->cp.ring[i]);
- i = (rdev->cp.wptr + (rdev->cp.ring_size / 4) - 64) & rdev->cp.ptr_mask;
- for (j = 0; j <= 64; j++) {
- seq_printf(m, "r[%04d]=0x%08X\n", i, rdev->cp.ring[i]);
i = (i + 1) & rdev->cp.ptr_mask; } return 0; -- 1.7.0.1
What about same for r1xx-r5xx? Could you care?
-- Rafał
Yes will do the patch, sorry i was working on r6xx bug at the time i did this patch.
Cheers, Jerome
W dniu 4 czerwca 2010 21:55 użytkownik Jerome Glisse glisse@freedesktop.org napisał:
On Fri, Jun 04, 2010 at 02:54:42PM +0200, Rafał Miłecki wrote:
2010/6/4 Jerome Glisse jglisse@redhat.com:
Instead of dumping unprocessed dwords, dump the last 64 dwords of the ring. This make debugging of some case easier.
Signed-off-by: Jerome Glisse jglisse@redhat.com
drivers/gpu/drm/radeon/r600.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c index f68cc92..1537079 100644 --- a/drivers/gpu/drm/radeon/r600.c +++ b/drivers/gpu/drm/radeon/r600.c @@ -3371,9 +3371,9 @@ static int r600_debugfs_cp_ring_info(struct seq_file *m, void *data) seq_printf(m, "driver's copy of the CP_RB_RPTR 0x%08x\n", rdev->cp.rptr); seq_printf(m, "%u free dwords in ring\n", rdev->cp.ring_free_dw); seq_printf(m, "%u dwords in ring\n", count);
- i = rdev->cp.rptr;
- for (j = 0; j <= count; j++) {
- seq_printf(m, "r[%04d]=0x%08x\n", i, rdev->cp.ring[i]);
- i = (rdev->cp.wptr + (rdev->cp.ring_size / 4) - 64) & rdev->cp.ptr_mask;
- for (j = 0; j <= 64; j++) {
- seq_printf(m, "r[%04d]=0x%08X\n", i, rdev->cp.ring[i]);
i = (i + 1) & rdev->cp.ptr_mask; } return 0; -- 1.7.0.1
What about same for r1xx-r5xx? Could you care?
-- Rafał
Yes will do the patch, sorry i was working on r6xx bug at the time i did this patch.
Thanks :)
dri-devel@lists.freedesktop.org