This file doesn't need everything provided by <linux/kernel.h>. All it needs are some types, which are provided by <drm/drm_mode.h>.
Drop unneeded <linux/kernel.h> completely.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com --- v3: Drop header completely (Laurent) include/linux/platform_data/shmob_drm.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h index fe815d7d9f58..d661399b217d 100644 --- a/include/linux/platform_data/shmob_drm.h +++ b/include/linux/platform_data/shmob_drm.h @@ -10,8 +10,6 @@ #ifndef __SHMOB_DRM_H__ #define __SHMOB_DRM_H__
-#include <linux/kernel.h> - #include <drm/drm_mode.h>
enum shmob_drm_clk_source {
On Thu, Feb 06, 2020 at 01:12:32PM +0200, Andy Shevchenko wrote:
This file doesn't need everything provided by <linux/kernel.h>. All it needs are some types, which are provided by <drm/drm_mode.h>.
Drop unneeded <linux/kernel.h> completely.
Any comments on this?
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
v3: Drop header completely (Laurent) include/linux/platform_data/shmob_drm.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h index fe815d7d9f58..d661399b217d 100644 --- a/include/linux/platform_data/shmob_drm.h +++ b/include/linux/platform_data/shmob_drm.h @@ -10,8 +10,6 @@ #ifndef __SHMOB_DRM_H__ #define __SHMOB_DRM_H__
-#include <linux/kernel.h>
#include <drm/drm_mode.h>
enum shmob_drm_clk_source {
2.24.1
Hi Andy,
Thank you for the patch, and sorry for the delay.
On Mon, Feb 24, 2020 at 11:04:30AM +0200, Andy Shevchenko wrote:
On Thu, Feb 06, 2020 at 01:12:32PM +0200, Andy Shevchenko wrote:
This file doesn't need everything provided by <linux/kernel.h>.
s/everything/anything/
All it needs are some types, which are provided by <drm/drm_mode.h>.
Drop unneeded <linux/kernel.h> completely.
Any comments on this?
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
Feel free to push :-)
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
v3: Drop header completely (Laurent) include/linux/platform_data/shmob_drm.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h index fe815d7d9f58..d661399b217d 100644 --- a/include/linux/platform_data/shmob_drm.h +++ b/include/linux/platform_data/shmob_drm.h @@ -10,8 +10,6 @@ #ifndef __SHMOB_DRM_H__ #define __SHMOB_DRM_H__
-#include <linux/kernel.h>
#include <drm/drm_mode.h>
enum shmob_drm_clk_source {
On Wed, Feb 26, 2020 at 03:44:06AM +0200, Laurent Pinchart wrote:
Hi Andy,
Thank you for the patch, and sorry for the delay.
On Mon, Feb 24, 2020 at 11:04:30AM +0200, Andy Shevchenko wrote:
On Thu, Feb 06, 2020 at 01:12:32PM +0200, Andy Shevchenko wrote:
This file doesn't need everything provided by <linux/kernel.h>.
s/everything/anything/
All it needs are some types, which are provided by <drm/drm_mode.h>.
Drop unneeded <linux/kernel.h> completely.
Any comments on this?
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
Feel free to push :-)
Pushed to drm-misc-next, thanks for the patch and review.
Signed-off-by: Andy Shevchenko andriy.shevchenko@linux.intel.com
v3: Drop header completely (Laurent) include/linux/platform_data/shmob_drm.h | 2 -- 1 file changed, 2 deletions(-)
diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h index fe815d7d9f58..d661399b217d 100644 --- a/include/linux/platform_data/shmob_drm.h +++ b/include/linux/platform_data/shmob_drm.h @@ -10,8 +10,6 @@ #ifndef __SHMOB_DRM_H__ #define __SHMOB_DRM_H__
-#include <linux/kernel.h>
#include <drm/drm_mode.h>
enum shmob_drm_clk_source {
-- Regards,
Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
dri-devel@lists.freedesktop.org
-
Andy Shevchenko -
Imre Deak -
Laurent Pinchart