Hi Nickey,

Thank you for the patch.

On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote:

From: Nickey Yang nickey.yang@rock-chips.com

We might include additional ports in derivative device trees, so the 'port' node should have an address, and the parent 'ports' node needs /#{addres,size}-cells.

v4:

• keep #{address,size}-cells in both 'ports' and 'port@0' nodes
• separate from the rest of the series, since this is mostly independent of the driver refactoring

Signed-off-by: Nickey Yang nickey.yang@rock-chips.com Signed-off-by: Brian Norris briannorris@chromium.org

Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com

---

arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index d340b58ab184..c6dae25a3f23 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi @@ -1652,7 +1652,11 @@ status = "disabled";

ports {

• 	mipi_in: port {
  

• 	#address-cells = <1>;
  

• 	#size-cells = <0>;
  

• 	mipi_in: port@0 {
  

• 		reg = <0>;
  	#address-cells = <1>;
  	#size-cells = <0>;