Static function dal_ddc_i2c_payloads_destroy is only called in dal_ddc_service_query_ddc_data, the parameter is &payloads , there is no point NULL risk, so no need to check. This change is to make the code run a bit fast.
Signed-off-by: Bernard Zhao bernard@vivo.com --- drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c index b984eecca58b..6dcc666738fc 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c @@ -150,9 +150,6 @@ static uint32_t dal_ddc_i2c_payloads_get_count(struct i2c_payloads *p)
static void dal_ddc_i2c_payloads_destroy(struct i2c_payloads *p) { - if (!p) - return; - dal_vector_destruct(&p->payloads); }
On Mon, Sep 21, 2020 at 9:14 AM Bernard Zhao bernard@vivo.com wrote:
Static function dal_ddc_i2c_payloads_destroy is only called in dal_ddc_service_query_ddc_data, the parameter is &payloads , there is no point NULL risk, so no need to check. This change is to make the code run a bit fast.
How about just getting rid of dal_ddc_i2c_payloads_destroy() and just call dal_vector_destruct() directly.
Alex
Signed-off-by: Bernard Zhao bernard@vivo.com
drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c index b984eecca58b..6dcc666738fc 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c @@ -150,9 +150,6 @@ static uint32_t dal_ddc_i2c_payloads_get_count(struct i2c_payloads *p)
static void dal_ddc_i2c_payloads_destroy(struct i2c_payloads *p) {
if (!p)return;dal_vector_destruct(&p->payloads);}
-- 2.28.0
amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
From: Alex Deucher alexdeucher@gmail.com Date: 2020-09-22 03:33:20 To: Bernard Zhao bernard@vivo.com Cc: Harry Wentland harry.wentland@amd.com,Leo Li sunpeng.li@amd.com,Alex Deucher alexander.deucher@amd.com,"Christian König" christian.koenig@amd.com,David Airlie airlied@linux.ie,Daniel Vetter daniel@ffwll.ch,Rodrigo Siqueira Rodrigo.Siqueira@amd.com,Jun Lei Jun.Lei@amd.com,Aric Cyr aric.cyr@amd.com,Wenjing Liu wenjing.liu@amd.com,abdoulaye berthe abdoulaye.berthe@amd.com,Michael Strauss michael.strauss@amd.com,Brandon Syu Brandon.Syu@amd.com,Martin Leung martin.leung@amd.com,amd-gfx list amd-gfx@lists.freedesktop.org,Maling list - DRI developers dri-devel@lists.freedesktop.org,LKML linux-kernel@vger.kernel.org,opensource.kernel@vivo.com Subject: Re: [PATCH] drm/amd/display: optimize code runtime a bit>On Mon, Sep 21, 2020 at 9:14 AM Bernard Zhao bernard@vivo.com wrote:
Static function dal_ddc_i2c_payloads_destroy is only called in dal_ddc_service_query_ddc_data, the parameter is &payloads , there is no point NULL risk, so no need to check. This change is to make the code run a bit fast.
How about just getting rid of dal_ddc_i2c_payloads_destroy() and just call dal_vector_destruct() directly.
Good idea, I will resubmit a patch, thanks!
BR//Bernard
Alex
Signed-off-by: Bernard Zhao bernard@vivo.com
drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c | 3 --- 1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c index b984eecca58b..6dcc666738fc 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c @@ -150,9 +150,6 @@ static uint32_t dal_ddc_i2c_payloads_get_count(struct i2c_payloads *p)
static void dal_ddc_i2c_payloads_destroy(struct i2c_payloads *p) {
if (!p)return;dal_vector_destruct(&p->payloads);}
-- 2.28.0
amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx
dri-devel@lists.freedesktop.org
-
Alex Deucher -
Bernard -
Bernard Zhao