[PATCH] Remove extra device acquisition method of i2c client in lt9611 driver

List overview All Threads
Download

newer

older

[v2 0/3] drm/msm/dsi: Add 10nm dsi...

[PATCH 4/5] drm/stm: ltdc: add...

lzmlzm

11 Jan 2022 11 Jan '22

3:40 a.m.

Signed-off-by: lzmlzm lzmlzmhh@gmail.com --- drivers/gpu/drm/bridge/lontium-lt9611.c | 2 +- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c index dafb1b47c15f..e0feb4fd9780 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client, if (!lt9611) return -ENOMEM;

- lt9611->dev = &client->dev; + lt9611->dev = dev; lt9611->client = client; lt9611->sleep = false;

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c index 33f9716da0ee..e50e42312e82 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client, if (!lt9611uxc) return -ENOMEM;

- lt9611uxc->dev = &client->dev; + lt9611uxc->dev = dev; lt9611uxc->client = client; mutex_init(&lt9611uxc->ocm_lock);

-- 2.25.1

Show replies by date

Robert Foss

13 Jan 13 Jan

10:14 a.m.

Hello,

Thanks for submitting this cleanup patch.

On Tue, 11 Jan 2022 at 04:41, lzmlzm lzmlzmhh@gmail.com wrote:

...

A commit message is necessary for all changes, no matter how trivial.

...

Signed-off-by: lzmlzm lzmlzmhh@gmail.com

Is your name listed correctly above? For the 'Signed-off-by' tag to be meaningful, a real name needs to be supplied.

...

drivers/gpu/drm/bridge/lontium-lt9611.c | 2 +- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c index dafb1b47c15f..e0feb4fd9780 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client, if (!lt9611) return -ENOMEM;
  lt9611->dev = &client->dev;
  lt9611->dev = dev;
  lt9611->client = client;
  lt9611->sleep = false;
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c index 33f9716da0ee..e50e42312e82 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client, if (!lt9611uxc) return -ENOMEM;
  lt9611uxc->dev = &client->dev;
  lt9611uxc->dev = dev;
  lt9611uxc->client = client;
  mutex_init(&lt9611uxc->ocm_lock);
--

With these two issues fixed, please submit a v2 of this patch.

Rob.

Zhiming Liu

11:21 a.m.

Hello Robert,

I am new to linux kernel development, thank you very much for your patient reply.I will attach V2 of patch in the next email.

Best regards Zhiming Liu

Robert Foss robert.foss@linaro.org 于2022年1月13日周四 18:14写道：

...

Hello,

Thanks for submitting this cleanup patch.

On Tue, 11 Jan 2022 at 04:41, lzmlzm lzmlzmhh@gmail.com wrote:

...
A commit message is necessary for all changes, no matter how trivial.

...
Signed-off-by: lzmlzm lzmlzmhh@gmail.com

Is your name listed correctly above? For the 'Signed-off-by' tag to be meaningful, a real name needs to be supplied.

...

drivers/gpu/drm/bridge/lontium-lt9611.c | 2 +- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c

b/drivers/gpu/drm/bridge/lontium-lt9611.c

...
index dafb1b47c15f..e0feb4fd9780 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client, if (!lt9611) return -ENOMEM;
  lt9611->dev = &client->dev;
  lt9611->dev = dev;
  lt9611->client = client;
  lt9611->sleep = false;
diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c

...
index 33f9716da0ee..e50e42312e82 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client, if (!lt9611uxc) return -ENOMEM;
  lt9611uxc->dev = &client->dev;
  lt9611uxc->dev = dev;
  lt9611uxc->client = client;
  mutex_init(&lt9611uxc->ocm_lock);
--
With these two issues fixed, please submit a v2 of this patch.

Rob.

Zhiming Liu

11:22 a.m.

...

From 10b677e995ab1f32df79896dbdb7cda779d3f798 Mon Sep 17 00:00:00 2001

From: Zhiming Liu lzmlzmhh@gmail.com Date: Thu, 13 Jan 2022 19:09:37 +0800 Subject: [PATCH v2] Signed-off-by: Zhiming Liu lzmlzmhh@gmail.com

bridge : drm : Remove extra device acquisition method of i2c client in lt9611 driver.

We have get the device of i2c client in probe function.So we should remove extra device acquisition method of i2c client in lt9611 driver. --- drivers/gpu/drm/bridge/lontium-lt9611.c | 4 ++-- drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c index dafb1b47c15f..feb128a4557d 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client, if (!lt9611) return -ENOMEM;

- lt9611->dev = &client->dev; + lt9611->dev = dev; lt9611->client = client; lt9611->sleep = false;

@@ -1100,7 +1100,7 @@ static int lt9611_probe(struct i2c_client *client, return PTR_ERR(lt9611->regmap); }

- ret = lt9611_parse_dt(&client->dev, lt9611); + ret = lt9611_parse_dt(dev, lt9611); if (ret) { dev_err(dev, "failed to parse device tree\n"); return ret; diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c index 33f9716da0ee..3d62e6bf6892 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client, if (!lt9611uxc) return -ENOMEM;

- lt9611uxc->dev = &client->dev; + lt9611uxc->dev = dev; lt9611uxc->client = client; mutex_init(&lt9611uxc->ocm_lock);

@@ -870,7 +870,7 @@ static int lt9611uxc_probe(struct i2c_client *client, return PTR_ERR(lt9611uxc->regmap); }

- ret = lt9611uxc_parse_dt(&client->dev, lt9611uxc); + ret = lt9611uxc_parse_dt(dev, lt9611uxc); if (ret) { dev_err(dev, "failed to parse device tree\n"); return ret;

-- 2.25.1 Robert Foss robert.foss@linaro.org 于2022年1月13日周四 18:14写道： > Hello, > > Thanks for submitting this cleanup patch. > > On Tue, 11 Jan 2022 at 04:41, lzmlzm lzmlzmhh@gmail.com wrote: > > > > A commit message is necessary for all changes, no matter how trivial. > > > Signed-off-by: lzmlzm lzmlzmhh@gmail.com > > Is your name listed correctly above? For the 'Signed-off-by' tag to be > meaningful, a real name needs to be supplied. > > > --- > > drivers/gpu/drm/bridge/lontium-lt9611.c | 2 +- > > drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c > b/drivers/gpu/drm/bridge/lontium-lt9611.c > > index dafb1b47c15f..e0feb4fd9780 100644 > > --- a/drivers/gpu/drm/bridge/lontium-lt9611.c > > +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c > > @@ -1090,7 +1090,7 @@ static int lt9611_probe(struct i2c_client *client, > > if (!lt9611) > > return -ENOMEM; > > > > - lt9611->dev = &client->dev; > > + lt9611->dev = dev; > > lt9611->client = client; > > lt9611->sleep = false; > > > > diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > > index 33f9716da0ee..e50e42312e82 100644 > > --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > > +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c > > @@ -860,7 +860,7 @@ static int lt9611uxc_probe(struct i2c_client *client, > > if (!lt9611uxc) > > return -ENOMEM; > > > > - lt9611uxc->dev = &client->dev; > > + lt9611uxc->dev = dev; > > lt9611uxc->client = client; > > mutex_init(&lt9611uxc->ocm_lock); > > > > -- > > With these two issues fixed, please submit a v2 of this patch. > > > Rob. >

1219

Age (days ago)

1221

Last active (days ago)

dri-devel@lists.freedesktop.org

3 comments

3 participants

tags (0)

participants (3)

lzmlzm
Robert Foss
Zhiming Liu