Hi Inki, I noticed that you merged "drm/exynos: change callback argument of sub driver with device" to your tree without posting it to me, or dri-devel, first. I think it would have been prudent to send for review/comments considering that:
a) we don't agree on this, and were in discussion about it last week, and b) it essentially reverts my "Pass exynos_drm_manager in..." patch, and changes key elements of my "Split manager/display/subdrv" patch,
Lastly, I was working on fixing the vidi errors in the patchset, instead of just on top. For bisect reasons, this is probably desirable.
Sean
2013/10/28 Sean Paul seanpaul@google.com:
Hi Inki, I noticed that you merged "drm/exynos: change callback argument of sub driver with device" to your tree without posting it to me, or dri-devel, first. I think it would have been prudent to send for review/comments considering that:
a) we don't agree on this, and were in discussion about it last week, and b) it essentially reverts my "Pass exynos_drm_manager in..." patch, and changes key elements of my "Split manager/display/subdrv" patch,
Don't worry about that. I have already removed my patch: it was really my mistake. And it doesn't need to discuss that issue anymore. I understood enough. :)
Lastly, I was working on fixing the vidi errors in the patchset, instead of just on top. For bisect reasons, this is probably desirable.
I had already commented about that, and my patch has already be removed from exynos-drm-next. Please re-post that fixup. :)
Thanks, Inki Dae
Sean _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
On Oct 29, 2013 8:16 AM, "Inki Dae" inki.dae@samsung.com wrote:
2013/10/28 Sean Paul seanpaul@google.com:
Hi Inki, I noticed that you merged "drm/exynos: change callback argument of sub driver with device" to your tree without posting it to me, or dri-devel, first. I think it would have been prudent to send for review/comments considering that:
a) we don't agree on this, and were in discussion about it last week,
and
b) it essentially reverts my "Pass exynos_drm_manager in..." patch, and changes key elements of my "Split manager/display/subdrv" patch,
Don't worry about that. I have already removed my patch: it was really my mistake. And it doesn't need to discuss that issue anymore. I understood enough. :)
Hi InKi, I sent this yesterday before your patches were posted to dri-devel, I guess it got lost in the ether.
Sean
Lastly, I was working on fixing the vidi errors in the patchset, instead of just on top. For bisect reasons, this is probably desirable.
I had already commented about that, and my patch has already be removed from exynos-drm-next. Please re-post that fixup. :)
Thanks, Inki Dae
Sean _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
dri-devel@lists.freedesktop.org