On Mon, Apr 4, 2016 at 3:24 AM, David Binderman dcb314@hotmail.com wrote:

Hello there,

linux-4.6-rc2/drivers/gpu/drm/radeon/si_dpm.c:3788]: (style) Condition 'td==0' is always true

Source code is

enum r600_td td = R600_TD_DFLT;

for (i = 0; i < R600_PM_NUMBER_OF_TC; i++)
    WREG32(CG_FFCT_0 + (i * 4), (UTC_0(r600_utc[i]) | DTC_0(r600_dtc[i])));

if (td == R600_TD_AUTO)

I included support for if we ever change the default setting.

[linux-4.6-rc2/drivers/gpu/drm/radeon/si_dpm.c:2838]: (style) Variable 'smc_result' is assigned a value that is never used.

In the disable case, we don't care if the request fails or not. I guess we could print a debug warning.

[linux-4.6-rc2/drivers/gpu/drm/radeon/si_dpm.c:3661]: (style) Variable 'backbias_response_time' is assigned a value that is never used.

Probably just a copy paste leftover from previous asics.

[linux-4.6-rc2/drivers/gpu/drm/radeon/si_dpm.c:4190]: (style) Variable 'voltage_found' is assigned a value that is never used.

It could be dropped.

Alex

Regards

David Binderman

---

dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel