From: Kieran Bingham kieran.bingham+renesas@ideasonboard.com
Extend the Renesas DU display bindings to support the r8a779a0 V3U.
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com Signed-off-by: Kieran Bingham kieran.bingham+renesas@ideasonboard.com
--- v2: - Collected Laurent's tag - Remove clock-names requirement - Specify only a single clock
v3: - Use clocknames: 'du.0' instead of 'du' to remain consistent
.../bindings/display/renesas,du.yaml | 50 +++++++++++++++++++ 1 file changed, 50 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml index e3ca5389c17d..6db6a3f15395 100644 --- a/Documentation/devicetree/bindings/display/renesas,du.yaml +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml @@ -39,6 +39,7 @@ properties: - renesas,du-r8a77980 # for R-Car V3H compatible DU - renesas,du-r8a77990 # for R-Car E3 compatible DU - renesas,du-r8a77995 # for R-Car D3 compatible DU + - renesas,du-r8a779a0 # for R-Car V3U compatible DU
reg: maxItems: 1 @@ -773,6 +774,55 @@ allOf: - reset-names - renesas,vsps
+ - if: + properties: + compatible: + contains: + enum: + - renesas,du-r8a779a0 + then: + properties: + clocks: + items: + - description: Functional clock + + clock-names: + maxItems: 1 + items: + - const: du.0 + + interrupts: + maxItems: 2 + + resets: + maxItems: 1 + + reset-names: + items: + - const: du.0 + + ports: + properties: + port@0: + description: DSI 0 + port@1: + description: DSI 1 + port@2: false + port@3: false + + required: + - port@0 + - port@1 + + renesas,vsps: + minItems: 2 + + required: + - interrupts + - resets + - reset-names + - renesas,vsps + additionalProperties: false
examples:
Hi Kieran,
On Thu, Sep 23, 2021 at 1:47 AM Kieran Bingham kieran.bingham@ideasonboard.com wrote:
From: Kieran Bingham kieran.bingham+renesas@ideasonboard.com
Extend the Renesas DU display bindings to support the r8a779a0 V3U.
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com Signed-off-by: Kieran Bingham kieran.bingham+renesas@ideasonboard.com
v2:
- Collected Laurent's tag
- Remove clock-names requirement
- Specify only a single clock
v3:
- Use clocknames: 'du.0' instead of 'du' to remain consistent
Thanks for the update!
--- a/Documentation/devicetree/bindings/display/renesas,du.yaml +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml @@ -39,6 +39,7 @@ properties: - renesas,du-r8a77980 # for R-Car V3H compatible DU - renesas,du-r8a77990 # for R-Car E3 compatible DU - renesas,du-r8a77995 # for R-Car D3 compatible DU
- renesas,du-r8a779a0 # for R-Car V3U compatible DU
reg: maxItems: 1
@@ -773,6 +774,55 @@ allOf: - reset-names - renesas,vsps
- if:
properties:
compatible:
contains:
enum:
- renesas,du-r8a779a0
- then:
properties:
clocks:
items:
- description: Functional clock
clock-names:
maxItems: 1
items:
- const: du.0
interrupts:
maxItems: 2
resets:
maxItems: 1
reset-names:
items:
- const: du.0
ports:
properties:
port@0:
description: DSI 0
port@1:
description: DSI 1
port@2: false
port@3: false
required:
- port@0
- port@1
renesas,vsps:
minItems: 2
required:
- interrupts
- resets
- reset-names
- renesas,vsps
clock-names, for consistency?
additionalProperties: false
examples:
With the above fixed: Reviewed-by: Geert Uytterhoeven geert+renesas@glider.be
Gr{oetje,eeting}s,
Geert
From: Kieran Bingham kieran.bingham+renesas@ideasonboard.com
Extend the Renesas DU display bindings to support the r8a779a0 V3U.
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com Reviewed-by: Geert Uytterhoeven geert+renesas@glider.be Signed-off-by: Kieran Bingham kieran.bingham+renesas@ideasonboard.com
--- v2: - Collected Laurent's tag - Remove clock-names requirement - Specify only a single clock
v3: - Use clocknames: 'du.0' instead of 'du' to remain consistent
v3.1: - Require clock-names - Collect Geert's tag
.../bindings/display/renesas,du.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/renesas,du.yaml b/Documentation/devicetree/bindings/display/renesas,du.yaml index e3ca5389c17d..13efea574584 100644 --- a/Documentation/devicetree/bindings/display/renesas,du.yaml +++ b/Documentation/devicetree/bindings/display/renesas,du.yaml @@ -39,6 +39,7 @@ properties: - renesas,du-r8a77980 # for R-Car V3H compatible DU - renesas,du-r8a77990 # for R-Car E3 compatible DU - renesas,du-r8a77995 # for R-Car D3 compatible DU + - renesas,du-r8a779a0 # for R-Car V3U compatible DU
reg: maxItems: 1 @@ -773,6 +774,56 @@ allOf: - reset-names - renesas,vsps
+ - if: + properties: + compatible: + contains: + enum: + - renesas,du-r8a779a0 + then: + properties: + clocks: + items: + - description: Functional clock + + clock-names: + maxItems: 1 + items: + - const: du.0 + + interrupts: + maxItems: 2 + + resets: + maxItems: 1 + + reset-names: + items: + - const: du.0 + + ports: + properties: + port@0: + description: DSI 0 + port@1: + description: DSI 1 + port@2: false + port@3: false + + required: + - port@0 + - port@1 + + renesas,vsps: + minItems: 2 + + required: + - clock-names + - interrupts + - resets + - reset-names + - renesas,vsps + additionalProperties: false
examples:
On Thu, 23 Sep 2021 14:01:38 +0100, Kieran Bingham wrote:
From: Kieran Bingham kieran.bingham+renesas@ideasonboard.com
Extend the Renesas DU display bindings to support the r8a779a0 V3U.
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com Reviewed-by: Geert Uytterhoeven geert+renesas@glider.be Signed-off-by: Kieran Bingham kieran.bingham+renesas@ideasonboard.com
v2:
- Collected Laurent's tag
- Remove clock-names requirement
- Specify only a single clock
v3:
- Use clocknames: 'du.0' instead of 'du' to remain consistent
v3.1:
- Require clock-names
- Collect Geert's tag
.../bindings/display/renesas,du.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+)
Reviewed-by: Rob Herring robh@kernel.org
On Mon, Sep 27, 2021 at 03:57:34PM -0500, Rob Herring wrote:
On Thu, 23 Sep 2021 14:01:38 +0100, Kieran Bingham wrote:
From: Kieran Bingham kieran.bingham+renesas@ideasonboard.com
Extend the Renesas DU display bindings to support the r8a779a0 V3U.
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com Reviewed-by: Geert Uytterhoeven geert+renesas@glider.be Signed-off-by: Kieran Bingham kieran.bingham+renesas@ideasonboard.com
v2:
- Collected Laurent's tag
- Remove clock-names requirement
- Specify only a single clock
v3:
- Use clocknames: 'du.0' instead of 'du' to remain consistent
v3.1:
- Require clock-names
- Collect Geert's tag
.../bindings/display/renesas,du.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+)
Reviewed-by: Rob Herring robh@kernel.org
Thank you Rob, that was the missing piece for a pull request :-)
dri-devel@lists.freedesktop.org