From: Stefan Riedmueller s.riedmueller@phytec.de
This patch adds support for the EDT ETMV570G2DHU 5.7" (640x480) lcd panel to DRM simple panel driver.
Signed-off-by: Stefan Riedmueller s.riedmueller@phytec.de Signed-off-by: Yunus Bas y.bas@phytec.de --- Changes in v3: - No changes in general, added additional maintainers and also sending to general kernel mailing list --- drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 21939d4352cf..07433bff6c2b 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2008,6 +2008,32 @@ static const struct panel_desc edt_et057090dhu = { .connector_type = DRM_MODE_CONNECTOR_DPI, };
+static const struct drm_display_mode edt_etmv570g2dhu_mode = { + .clock = 25175, + .hdisplay = 640, + .hsync_start = 640, + .hsync_end = 640 + 16, + .htotal = 640 + 16 + 30 + 114, + .vdisplay = 480, + .vsync_start = 480 + 10, + .vsync_end = 480 + 10 + 3, + .vtotal = 480 + 10 + 3 + 35, + .flags = DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_PHSYNC, +}; + +static const struct panel_desc edt_etmv570g2dhu = { + .modes = &edt_etmv570g2dhu_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 115, + .height = 86, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, + .connector_type = DRM_MODE_CONNECTOR_DPI, +}; + static const struct drm_display_mode edt_etm0700g0dh6_mode = { .clock = 33260, .hdisplay = 800, @@ -4338,6 +4364,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et057090dhu", .data = &edt_et057090dhu, + }, { + .compatible = "edt,etmv570g2dhu", + .data = &edt_etmv570g2dhu, }, { .compatible = "edt,et070080dh6", .data = &edt_etm0700g0dh6,
From: Stefan Riedmueller s.riedmueller@phytec.de
This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd panel to DRM simple panel driver.
Signed-off-by: Stefan Riedmueller s.riedmueller@phytec.de Signed-off-by: Yunus Bas y.bas@phytec.de --- Changes in v3: - No changes in general, added additional maintainers and also sending to general kernel mailing list --- drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 07433bff6c2b..8aba473a7592 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1929,6 +1929,32 @@ static const struct panel_desc edt_et035012dm6 = { .bus_flags = DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE, };
+static const struct drm_display_mode edt_etm0350g0dh6_mode = { + .clock = 6520, + .hdisplay = 320, + .hsync_start = 320 + 20, + .hsync_end = 320 + 20 + 68, + .htotal = 320 + 20 + 68, + .vdisplay = 240, + .vsync_start = 240 + 4, + .vsync_end = 240 + 4 + 18, + .vtotal = 240 + 4 + 18, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +}; + +static const struct panel_desc edt_etm0350g0dh6 = { + .modes = &edt_etm0350g0dh6_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 70, + .height = 53, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, + .connector_type = DRM_MODE_CONNECTOR_DPI, +}; + static const struct drm_display_mode edt_etm043080dh6gp_mode = { .clock = 10870, .hdisplay = 480, @@ -4355,6 +4381,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et035012dm6", .data = &edt_et035012dm6, + }, { + .compatible = "edt,etm0350g0dh6", + .data = &edt_etm0350g0dh6, }, { .compatible = "edt,etm043080dh6gp", .data = &edt_etm043080dh6gp,
Hi Yunus,
On Tue, Jul 06, 2021 at 09:59:08AM +0200, Yunus Bas wrote:
From: Stefan Riedmueller s.riedmueller@phytec.de
This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd panel to DRM simple panel driver.
Signed-off-by: Stefan Riedmueller s.riedmueller@phytec.de Signed-off-by: Yunus Bas y.bas@phytec.de
Changes in v3:
- No changes in general, added additional maintainers and also sending
to general kernel mailing list
drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 07433bff6c2b..8aba473a7592 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1929,6 +1929,32 @@ static const struct panel_desc edt_et035012dm6 = { .bus_flags = DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE, };
+static const struct drm_display_mode edt_etm0350g0dh6_mode = {
- .clock = 6520,
- .hdisplay = 320,
- .hsync_start = 320 + 20,
- .hsync_end = 320 + 20 + 68,
- .htotal = 320 + 20 + 68,
- .vdisplay = 240,
- .vsync_start = 240 + 4,
- .vsync_end = 240 + 4 + 18,
- .vtotal = 240 + 4 + 18,
- .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+static const struct panel_desc edt_etm0350g0dh6 = {
- .modes = &edt_etm0350g0dh6_mode,
- .num_modes = 1,
- .bpc = 6,
- .size = {
.width = 70,.height = 53,- },
- .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
- .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
- .connector_type = DRM_MODE_CONNECTOR_DPI,
+};
static const struct drm_display_mode edt_etm043080dh6gp_mode = { .clock = 10870, .hdisplay = 480, @@ -4355,6 +4381,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et035012dm6", .data = &edt_et035012dm6,
- }, {
.compatible = "edt,etm0350g0dh6",.data = &edt_etm0350g0dh6,
The compatible "edt,etm0350g0dh6" is not documented. You likely need to add it to panel-simple.yaml - and likewise for the first patch.
dt people like binding patches in separate patches so add them both in one dedicated patch.
Sam
Hi Sam,
Am Freitag, dem 09.07.2021 um 20:12 +0200 schrieb Sam Ravnborg:
Hi Yunus,
On Tue, Jul 06, 2021 at 09:59:08AM +0200, Yunus Bas wrote:
From: Stefan Riedmueller s.riedmueller@phytec.de
This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd panel to DRM simple panel driver.
Signed-off-by: Stefan Riedmueller s.riedmueller@phytec.de Signed-off-by: Yunus Bas y.bas@phytec.de
Changes in v3:
- No changes in general, added additional maintainers and also
sending to general kernel mailing list
drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 07433bff6c2b..8aba473a7592 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1929,6 +1929,32 @@ static const struct panel_desc edt_et035012dm6 = { .bus_flags = DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE, }; +static const struct drm_display_mode edt_etm0350g0dh6_mode = { + .clock = 6520, + .hdisplay = 320, + .hsync_start = 320 + 20, + .hsync_end = 320 + 20 + 68, + .htotal = 320 + 20 + 68, + .vdisplay = 240, + .vsync_start = 240 + 4, + .vsync_end = 240 + 4 + 18, + .vtotal = 240 + 4 + 18, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +};
+static const struct panel_desc edt_etm0350g0dh6 = { + .modes = &edt_etm0350g0dh6_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 70, + .height = 53, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, + .connector_type = DRM_MODE_CONNECTOR_DPI, +};
static const struct drm_display_mode edt_etm043080dh6gp_mode = { .clock = 10870, .hdisplay = 480, @@ -4355,6 +4381,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et035012dm6", .data = &edt_et035012dm6, + }, { + .compatible = "edt,etm0350g0dh6", + .data = &edt_etm0350g0dh6,
The compatible "edt,etm0350g0dh6" is not documented. You likely need to add it to panel-simple.yaml - and likewise for the first patch.
dt people like binding patches in separate patches so add them both in one dedicated patch.
I've already sent devicetree patches. Here is the link: https://lore.kernel.org/linux-devicetree/20210331181317.464926-1-y.bas@phyte...
It was just pending and waiting for these patches. Shall I send again?
Regards, Yunus
Sam
Hi Yunus,
On Fri, Jul 09, 2021 at 07:02:52PM +0000, Yunus Bas wrote:
Hi Sam,
Am Freitag, dem 09.07.2021 um 20:12 +0200 schrieb Sam Ravnborg:
Hi Yunus,
On Tue, Jul 06, 2021 at 09:59:08AM +0200, Yunus Bas wrote:
From: Stefan Riedmueller s.riedmueller@phytec.de
This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd panel to DRM simple panel driver.
Signed-off-by: Stefan Riedmueller s.riedmueller@phytec.de Signed-off-by: Yunus Bas y.bas@phytec.de
Changes in v3:
- No changes in general, added additional maintainers and also
sending to general kernel mailing list
drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 07433bff6c2b..8aba473a7592 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1929,6 +1929,32 @@ static const struct panel_desc edt_et035012dm6 = { .bus_flags = DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE, }; +static const struct drm_display_mode edt_etm0350g0dh6_mode = { + .clock = 6520, + .hdisplay = 320, + .hsync_start = 320 + 20, + .hsync_end = 320 + 20 + 68, + .htotal = 320 + 20 + 68, + .vdisplay = 240, + .vsync_start = 240 + 4, + .vsync_end = 240 + 4 + 18, + .vtotal = 240 + 4 + 18, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +};
+static const struct panel_desc edt_etm0350g0dh6 = { + .modes = &edt_etm0350g0dh6_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 70, + .height = 53, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, + .connector_type = DRM_MODE_CONNECTOR_DPI, +};
static const struct drm_display_mode edt_etm043080dh6gp_mode = { .clock = 10870, .hdisplay = 480, @@ -4355,6 +4381,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et035012dm6", .data = &edt_et035012dm6, + }, { + .compatible = "edt,etm0350g0dh6", + .data = &edt_etm0350g0dh6,
The compatible "edt,etm0350g0dh6" is not documented. You likely need to add it to panel-simple.yaml - and likewise for the first patch.
dt people like binding patches in separate patches so add them both in one dedicated patch.
I've already sent devicetree patches. Here is the link: https://lore.kernel.org/linux-devicetree/20210331181317.464926-1-y.bas@phyte...
It was just pending and waiting for these patches. Shall I send again?
I have likely deleted the patches already, so please resend. Been mostly offline for a period and then one week wihtout access to my linux box, and have to delete a lot to avoid getting too much behind.
Sam
Am Freitag, dem 09.07.2021 um 21:30 +0200 schrieb Sam Ravnborg:
Hi Yunus,
On Fri, Jul 09, 2021 at 07:02:52PM +0000, Yunus Bas wrote:
Hi Sam,
Am Freitag, dem 09.07.2021 um 20:12 +0200 schrieb Sam Ravnborg:
Hi Yunus,
On Tue, Jul 06, 2021 at 09:59:08AM +0200, Yunus Bas wrote:
From: Stefan Riedmueller s.riedmueller@phytec.de
This patch adds support for the EDT ETM0350G0DH6 3.5" (320x240) lcd panel to DRM simple panel driver.
Signed-off-by: Stefan Riedmueller s.riedmueller@phytec.de Signed-off-by: Yunus Bas y.bas@phytec.de
Changes in v3:
- No changes in general, added additional maintainers and also
sending to general kernel mailing list
drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 07433bff6c2b..8aba473a7592 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1929,6 +1929,32 @@ static const struct panel_desc edt_et035012dm6 = { .bus_flags = DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_PIXDATA_SAMPLE_POSEDGE, }; +static const struct drm_display_mode edt_etm0350g0dh6_mode = { + .clock = 6520, + .hdisplay = 320, + .hsync_start = 320 + 20, + .hsync_end = 320 + 20 + 68, + .htotal = 320 + 20 + 68, + .vdisplay = 240, + .vsync_start = 240 + 4, + .vsync_end = 240 + 4 + 18, + .vtotal = 240 + 4 + 18, + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, +};
+static const struct panel_desc edt_etm0350g0dh6 = { + .modes = &edt_etm0350g0dh6_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 70, + .height = 53, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, + .connector_type = DRM_MODE_CONNECTOR_DPI, +};
static const struct drm_display_mode edt_etm043080dh6gp_mode = { .clock = 10870, .hdisplay = 480, @@ -4355,6 +4381,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et035012dm6", .data = &edt_et035012dm6, + }, { + .compatible = "edt,etm0350g0dh6", + .data = &edt_etm0350g0dh6,
The compatible "edt,etm0350g0dh6" is not documented. You likely need to add it to panel-simple.yaml - and likewise for the first patch.
dt people like binding patches in separate patches so add them both in one dedicated patch.
I've already sent devicetree patches. Here is the link: https://lore.kernel.org/linux-devicetree/20210331181317.464926-1-y.bas@phyte...
It was just pending and waiting for these patches. Shall I send again?
I have likely deleted the patches already, so please resend. Been mostly offline for a period and then one week wihtout access to my linux box, and have to delete a lot to avoid getting too much behind.
No problem, I'll resend them ASAP.
Regards, Yunus
Sam
Hi Yunus,
On Tue, Jul 06, 2021 at 09:59:07AM +0200, Yunus Bas wrote:
From: Stefan Riedmueller s.riedmueller@phytec.de
This patch adds support for the EDT ETMV570G2DHU 5.7" (640x480) lcd panel to DRM simple panel driver.
Signed-off-by: Stefan Riedmueller s.riedmueller@phytec.de Signed-off-by: Yunus Bas y.bas@phytec.de
Changes in v3:
- No changes in general, added additional maintainers and also sending
to general kernel mailing list
drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 21939d4352cf..07433bff6c2b 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2008,6 +2008,32 @@ static const struct panel_desc edt_et057090dhu = { .connector_type = DRM_MODE_CONNECTOR_DPI, };
+static const struct drm_display_mode edt_etmv570g2dhu_mode = {
- .clock = 25175,
- .hdisplay = 640,
- .hsync_start = 640,
- .hsync_end = 640 + 16,
- .htotal = 640 + 16 + 30 + 114,
- .vdisplay = 480,
- .vsync_start = 480 + 10,
- .vsync_end = 480 + 10 + 3,
- .vtotal = 480 + 10 + 3 + 35,
- .flags = DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_PHSYNC,
+};
+static const struct panel_desc edt_etmv570g2dhu = {
- .modes = &edt_etmv570g2dhu_mode,
- .num_modes = 1,
- .bpc = 6,
- .size = {
.width = 115,.height = 86,- },
- .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
- .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
- .connector_type = DRM_MODE_CONNECTOR_DPI,
+};
static const struct drm_display_mode edt_etm0700g0dh6_mode = { .clock = 33260, .hdisplay = 800, @@ -4338,6 +4364,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et057090dhu", .data = &edt_et057090dhu,
- }, {
.compatible = "edt,etmv570g2dhu",.data = &edt_etmv570g2dhu,
This list must be alphabetically sorted after compatible.
"edt,etmv570g2dhu" comes after "edt,et070080dh6"
The same order must be used where edt_etmv570g2dhu is defined. Sorry for this nit, but if we fails to follw it we will soon have chaos.
The rest looks good, everything needed is defined.
Sam
Hi Sam,
Am Freitag, dem 09.07.2021 um 20:08 +0200 schrieb Sam Ravnborg:
Hi Yunus,
On Tue, Jul 06, 2021 at 09:59:07AM +0200, Yunus Bas wrote:
From: Stefan Riedmueller s.riedmueller@phytec.de
This patch adds support for the EDT ETMV570G2DHU 5.7" (640x480) lcd panel to DRM simple panel driver.
Signed-off-by: Stefan Riedmueller s.riedmueller@phytec.de Signed-off-by: Yunus Bas y.bas@phytec.de
Changes in v3:
- No changes in general, added additional maintainers and also
sending to general kernel mailing list
drivers/gpu/drm/panel/panel-simple.c | 29 ++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 21939d4352cf..07433bff6c2b 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2008,6 +2008,32 @@ static const struct panel_desc edt_et057090dhu = { .connector_type = DRM_MODE_CONNECTOR_DPI, }; +static const struct drm_display_mode edt_etmv570g2dhu_mode = { + .clock = 25175, + .hdisplay = 640, + .hsync_start = 640, + .hsync_end = 640 + 16, + .htotal = 640 + 16 + 30 + 114, + .vdisplay = 480, + .vsync_start = 480 + 10, + .vsync_end = 480 + 10 + 3, + .vtotal = 480 + 10 + 3 + 35, + .flags = DRM_MODE_FLAG_PVSYNC | DRM_MODE_FLAG_PHSYNC, +};
+static const struct panel_desc edt_etmv570g2dhu = { + .modes = &edt_etmv570g2dhu_mode, + .num_modes = 1, + .bpc = 6, + .size = { + .width = 115, + .height = 86, + }, + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE, + .connector_type = DRM_MODE_CONNECTOR_DPI, +};
static const struct drm_display_mode edt_etm0700g0dh6_mode = { .clock = 33260, .hdisplay = 800, @@ -4338,6 +4364,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "edt,et057090dhu", .data = &edt_et057090dhu, + }, { + .compatible = "edt,etmv570g2dhu", + .data = &edt_etmv570g2dhu, }, { .compatible = "edt,et070080dh6", .data = &edt_etm0700g0dh6,
This list must be alphabetically sorted after compatible.
"edt,etmv570g2dhu" comes after "edt,et070080dh6"
The same order must be used where edt_etmv570g2dhu is defined. Sorry for this nit, but if we fails to follw it we will soon have chaos.
Of course, sorry for not noticing earlier. I will change this.
Regards, Yunus
The rest looks good, everything needed is defined.
Sam
dri-devel@lists.freedesktop.org
-
Sam Ravnborg -
Yunus Bas -
Yunus Bas