On 21/12/2021 17:42, cgel.zte@gmail.com wrote:

From: Changcheng Deng deng.changcheng@zte.com.cn

Fix the following coccicheck warning: ./drivers/gpu/drm/msm/msm_debugfs.c: 132: 0-23: WARNING: shrink_fops should be defined with DEFINE_DEBUGFS_ATTRIBUTE

Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files.

Reported-by: Zeal Robot zealci@zte.com.cn Signed-off-by: Changcheng Deng deng.changcheng@zte.com.cn

Reviewed-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

---

drivers/gpu/drm/msm/msm_debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/msm/msm_debugfs.c b/drivers/gpu/drm/msm/msm_debugfs.c index 956b1efc3721..91fb0c83b600 100644 --- a/drivers/gpu/drm/msm/msm_debugfs.c +++ b/drivers/gpu/drm/msm/msm_debugfs.c @@ -129,9 +129,9 @@ shrink_set(void *data, u64 val) return 0; }

-DEFINE_SIMPLE_ATTRIBUTE(shrink_fops,

• 	shrink_get, shrink_set,
  

• 	"0x%08llx\n");
  

+DEFINE_DEBUGFS_ATTRIBUTE(shrink_fops,

• 	 shrink_get, shrink_set,
  

• 	 "0x%08llx\n");
  
  
  

  static int msm_gem_show(struct seq_file *m, void *arg)