Hi David, Laurent
These removes unneeded error message from Renesas DU driver. Current this unneeded error message makes user confuse.
Kuninori Morimoto (2): drm: rcar-du: error message is not needed for drm_vblank_init() drm: rcar-du: error message is not needed for EPROBE_DEFER
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
The only reason drm_vblank_init() could return an error at the moment is a kcalloc() failure. So we can remove current error message completely.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- v1 -> v2
- just removed error message
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 26fd3ba..786f5d6 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -353,10 +353,8 @@ static int rcar_du_probe(struct platform_device *pdev) * disabled for all CRTCs. */ ret = drm_vblank_init(ddev, (1 << rcdu->info->num_crtcs) - 1); - if (ret < 0) { - dev_err(&pdev->dev, "failed to initialize vblank\n"); + if (ret < 0) goto error; - }
/* DRM/KMS objects */ ret = rcar_du_modeset_init(rcdu);
From: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
EPROBE_DEFER is not error, thus, error message on kernel log on this case is confusable. Print it only error cases
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com --- v1 -> v2
- only for rcar_du_modeset_init()
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 786f5d6..cf2698e 100644 --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c @@ -359,7 +359,8 @@ static int rcar_du_probe(struct platform_device *pdev) /* DRM/KMS objects */ ret = rcar_du_modeset_init(rcdu); if (ret < 0) { - dev_err(&pdev->dev, "failed to initialize DRM/KMS (%d)\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, "failed to initialize DRM/KMS (%d)\n", ret); goto error; }
Hi David
ping ?
These removes unneeded error message from Renesas DU driver. Current this unneeded error message makes user confuse.
Kuninori Morimoto (2): drm: rcar-du: error message is not needed for drm_vblank_init() drm: rcar-du: error message is not needed for EPROBE_DEFER
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
Hi Morimoto-san,
On Wednesday 25 May 2016 00:38:48 Kuninori Morimoto wrote:
Hi David, Laurent
These removes unneeded error message from Renesas DU driver. Current this unneeded error message makes user confuse.
Thank you for the patches. For both of them,
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
I've applied them to my tree and include them in my next pull request.
Kuninori Morimoto (2): drm: rcar-du: error message is not needed for drm_vblank_init() drm: rcar-du: error message is not needed for EPROBE_DEFER
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
dri-devel@lists.freedesktop.org
-
Kuninori Morimoto -
Laurent Pinchart