[Bug 94595] [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly
https://bugs.freedesktop.org/show_bug.cgi?id=94595
Bug ID: 94595 Summary: [Mesa AMD&swrast] Texture views attached as framebuffers return their viewed tecture's color encoding and render incorrectly Product: Mesa Version: git Hardware: Other OS: Linux (All) Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: esmith@feralinteractive.com QA Contact: dri-devel@lists.freedesktop.org
As seen in the example given, when attaching an SRGB/RGB texture view is created from an alternate RGB/SRGB texture, then attached as a framebuffer, rendering will gamma correct wrongly and querying GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING will return GL_LINEAR for an SRGB backed frame buffer.
This is causing AA renders to be too dark as in our unreleased project, among many other subtle colour issues.
Tested on latest 11.3 (git-9d9965c from oibaf) and seen on older drivers as well. $ g++ TextureViewFramebufferSRGBTest.cpp.cpp $( sdl2-config --cflags --libs ) -lGL This reproduces on Mesa AMD and swrast.
https://bugs.freedesktop.org/show_bug.cgi?id=94595
--- Comment #1 from Nicolai Hähnle nhaehnle@gmail.com --- Thanks for the report - did you forget to attach a source file?
https://bugs.freedesktop.org/show_bug.cgi?id=94595
--- Comment #2 from Edwin Smith esmith@feralinteractive.com --- Created attachment 122407 --> https://bugs.freedesktop.org/attachment.cgi?id=122407&action=edit TextureViewFramebufferSRGB Test Sample Code
https://bugs.freedesktop.org/show_bug.cgi?id=94595
--- Comment #3 from Edwin Smith esmith@feralinteractive.com --- Created attachment 122408 --> https://bugs.freedesktop.org/attachment.cgi?id=122408&action=edit AMD Mesa Test Output
https://bugs.freedesktop.org/show_bug.cgi?id=94595
--- Comment #4 from Edwin Smith esmith@feralinteractive.com --- Created attachment 122409 --> https://bugs.freedesktop.org/attachment.cgi?id=122409&action=edit Intel Output (Correct Behaviour)
https://bugs.freedesktop.org/show_bug.cgi?id=94595
--- Comment #5 from Edwin Smith esmith@feralinteractive.com --- Created attachment 122410 --> https://bugs.freedesktop.org/attachment.cgi?id=122410&action=edit Nvidia Output (Correct Behaviour)
https://bugs.freedesktop.org/show_bug.cgi?id=94595
--- Comment #6 from Edwin Smith esmith@feralinteractive.com --- Created attachment 122411 --> https://bugs.freedesktop.org/attachment.cgi?id=122411&action=edit Swrast Output (Incorrect Behaviour)
https://bugs.freedesktop.org/show_bug.cgi?id=94595
Edwin Smith esmith@feralinteractive.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #122408|AMD Mesa Test Output |AMD Mesa Output (Incorrect description| |Behaviour)
https://bugs.freedesktop.org/show_bug.cgi?id=94595
--- Comment #7 from Nicolai Hähnle nhaehnle@gmail.com --- Hi Edwin, thanks for following up with the details. I'm going to look into this.
https://bugs.freedesktop.org/show_bug.cgi?id=94595
--- Comment #8 from Nicolai Hähnle nhaehnle@gmail.com --- There is a patch at https://patchwork.freedesktop.org/patch/77510/ which fixes your test case (and should fix format casting with render-to-texture more generally).
Let us know if this fixes your SRGB-related rendering problems.
https://bugs.freedesktop.org/show_bug.cgi?id=94595
Nicolai Hähnle nhaehnle@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED
--- Comment #9 from Nicolai Hähnle nhaehnle@gmail.com --- Fixed in Mesa master, commit a8b315b8271e867db30650dedb52e53d8dd9667c
https://bugs.freedesktop.org/show_bug.cgi?id=94595
Edwin Smith esmith@feralinteractive.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED
--- Comment #10 from Edwin Smith esmith@feralinteractive.com --- The test case submitted now works as expected using the latest mesa git drivers. Thank you for such a quick fix!
dri-devel@lists.freedesktop.org
-
bugzilla-daemon＠freedesktop.org