https://bugs.freedesktop.org/show_bug.cgi?id=105200

--- Comment #1 from Jan Vesely jan.vesely@rutgers.edu --- (In reply to nixscripter from comment #0)

Created attachment 137519 [details] The ImageMagick OpenCL Kernel

LLVM svn version: 325439 Mesa version: git fa8a764b62

The last version that worked was several weeks ago -- prior to the LLVM 6 branch.

The log is so short, I can paste it in here:

build options: -cl-single-precision-constant -cl-mad-enable -DMAGICKCORE_HDRI_SUPPORT=1 -DCLQuantum=float -DCLSignedQuantum=float -DCLPixelType=float4 -DQuantumRange=65535.000000 -DQuantumScale=0.000015 -DCharQuantumScale=1.000000 -DMagickEpsilon=0.000000 -DMagickPI=3.141593 -DMaxMap=65535 -DMAGICKCORE_QUANTUM_DEPTH=16 <unknown>:0:0: in function AddNoise void (<4 x float> addrspace(1)*, <4 x float> addrspace(1)*, i32, i32, i32, i32, float, i32, i32, i32): unsupported initializer for address space

The unknown is because I have a stripped binary. I have not done all the manual rebuilds for the symbols yet.

The actual kernel being compiled is attached. Hopefully it should be obvious enough what the problem is.

well, not really. AS error suggests that this is a fallout of r325030 and you'll need to update and rebuild libclc.

https://bugs.freedesktop.org/show_bug.cgi?id=105200

--- Comment #3 from Jan Vesely jan.vesely@rutgers.edu --- you'll need the libclc build fixes from: http://lists.llvm.org/pipermail/libclc-dev/2018-February/002796.html and http://lists.llvm.org/pipermail/libclc-dev/2018-February/002800.html

(all 5 of them). Alternatively you can wait until they land.

https://bugs.freedesktop.org/show_bug.cgi?id=105200

--- Comment #5 from Jan Vesely jan.vesely@rutgers.edu --- (In reply to nixscripter from comment #4)

Thanks to your quick response, I got libclc compiled successfully.

Now when I try to view an image, the OpenCL compile error is different:

<unknown>:0:0: in function ResizeHorizontalFilter void (float addrspace(1)*, i32, i32, i32, float addrspace(1)*, i32, i32, float, i32, i32, float addrspace(1)*, float, float, float, float, float addrspace(3)*, i32, i32, i32, <4 x float> addrspace(3)*, float addrspace(3)*, float addrspace(3)*): unsupported call to function applyResizeFilter

I'd call that progress, certainly.

applyResizeFilter is on line 78 of the kernel, and ResizeHorizontalFilter is on line 81.

that's weird. Probably a separate bug. All functions should be marked as always_inline. moreover the function in question is explicitly marked as inline. The only thing I can think of is that the function signature does not match between definition and the call site Does imagemagick use some form of kernel cache? if yes it needs to be cleaned.

what is the GPU that you're using? Can you run CLOVER_DEBUG=llvm,clc CLOVER_DEBUG_FILE=imagick and attach the .cl and .ll dump files?

https://bugs.freedesktop.org/show_bug.cgi?id=105200

--- Comment #7 from nixscripter@gmail.com --- Created attachment 137572 --> https://bugs.freedesktop.org/attachment.cgi?id=137572&action=edit clover debug imagemagick.link-0.ll

My GPU is:

01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Juniper PRO [Radeon HD 6750]

(Which is an Evergreen chipset, if I remember correctly.)

And I am pretty sure ImageMagick does not have an OpenCL cache. For better or worse, it has one giant blob of OpenCL, and re-compiles it when OpenCL is enabled -- whether you actually use any of it or not. I did try deleting the files, though, just in case.

https://bugs.freedesktop.org/show_bug.cgi?id=105200

--- Comment #9 from Jan Vesely jan.vesely@rutgers.edu --- did you by any chance run the DUMP commands twice? the files seems to contain duplicates.

Anyway I cannot reproduce the error. running:

clang -cc1 -x cl -triple=r600-- -target-cpu juniper -cl-single-precision-constant -cl-mad-enable -DMAGICKCORE_HDRI_SUPPORT=1 -DCLQuantum=float -DCLSignedQuantum=float -DCLPixelType=float4 -DQuantumRange=65535.000000f -DQuantumScale=0.000015 -DCharQuantumScale=1.000000 -DMagickEpsilon=0.000000 -DMagickPI=3.141593 -DMaxMap=65535 -DMAGICKCORE_QUANTUM_DEPTH=16 -I ./libclc/generic/include/ -include libclc/generic/include/clc/clc.h -emit-llvm -o magick-link.ll -mlink-bitcode-file libclc/built_libs/juniper-r600--.bc < magick.cl llc -march=r600-- -mcpu=juniper < magick-link.ll

Runs into: llvm/include/llvm/MC/MCRegisterInfo.h:64: unsigned int llvm::MCRegisterClass::getRegister(unsigned int) const: Assertion `i < getNumRegs() && "Register number out of range!"' failed.

which is expected, since register spilling is not implemented (yet)

https://bugs.freedesktop.org/show_bug.cgi?id=105200

nixscripter@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED

--- Comment #11 from nixscripter@gmail.com --- I finally got back to this, and sure enough, upgrading LLVM to r327238 seems to have fixed it. Thanks for your efforts.

Marking as RESOLVED FIXED.