Function mbxfb_debugfs_remove() accesses fbi->par without NULL check, hence do the NULL check in the caller mbxfb_remove().
Signed-off-by: Gaurav Singh gaurav1086@gmail.com --- drivers/video/fbdev/mbx/mbxfb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/mbx/mbxfb.c b/drivers/video/fbdev/mbx/mbxfb.c index 6dc287c819cb..515c0cda1994 100644 --- a/drivers/video/fbdev/mbx/mbxfb.c +++ b/drivers/video/fbdev/mbx/mbxfb.c @@ -1012,11 +1012,10 @@ static int mbxfb_remove(struct platform_device *dev)
write_reg_dly(SYSRST_RST, SYSRST);
- mbxfb_debugfs_remove(fbi); - if (fbi) { struct mbxfb_info *mfbi = fbi->par;
+ mbxfb_debugfs_remove(fbi); unregister_framebuffer(fbi); if (mfbi) { if (mfbi->platform_remove)
On Sun, Jul 26, 2020 at 8:26 AM Gaurav Singh gaurav1086@gmail.com wrote:
Function mbxfb_debugfs_remove() accesses fbi->par without NULL check, hence do the NULL check in the caller mbxfb_remove().
...
if (fbi) {
Can you explain how this is NULL on ->remove()?
I bet this check is simply redundant. But you have to check and update commit message accordingly.
dri-devel@lists.freedesktop.org