On 09/09/2019 16:51, Krzysztof Kozlowski wrote:

There is no point to print deferred probe (and its failures to get resources) as an error.

In case of multiple probe tries this would pollute the dmesg.

Signed-off-by: Krzysztof Kozlowski krzk@kernel.org

Looks like a good idea, however from what I can tell you haven't completely silenced the 'error' as the return from panfrost_regulator_init() will be -EPROBE_DEFER causing another dev_err() output:

err = panfrost_regulator_init(pfdev); if (err) { dev_err(pfdev->dev, "regulator init failed %d\n", err); goto err_out0; }

Can you fix that up as well? Or indeed drop it altogether since panfrost_regulator_init() already outputs an appropriate message.

Steve

---

drivers/gpu/drm/panfrost/panfrost_device.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c index 46b0b02e4289..2252147bc285 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -95,7 +95,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev) pfdev->regulator = NULL; if (ret == -ENODEV) return 0;

• dev_err(pfdev->dev, "failed to get regulator: %d\n", ret);
  

• if (ret != -EPROBE_DEFER)
  

• 	dev_err(pfdev->dev, "failed to get regulator: %d\n",
  

• 		ret);
  

  return ret; }