Temperature and hysteresis were picked after the CPU.
Changes from v1: - Update dt bindings - Fix broken phandle
Guido Günther (2): dts: arm64: imx8mq: Enable gpu passive throttling dt-bindings: etnaviv: Add #cooling-cells
.../bindings/display/etnaviv/etnaviv-drm.txt | 1 + arch/arm64/boot/dts/freescale/imx8mq.dtsi | 15 +++++++++++++++ 2 files changed, 16 insertions(+)
Temperature and hysteresis were picked after the CPU.
Signed-off-by: Guido Günther agx@sigxcpu.org --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index 4fdd60f2c51e..5023a0e5068d 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi @@ -235,12 +235,26 @@ thermal-sensors = <&tmu 1>;
trips { + gpu_alert: gpu-alert { + temperature = <80000>; + hysteresis = <2000>; + type = "passive"; + }; + gpu-crit { temperature = <90000>; hysteresis = <2000>; type = "critical"; }; }; + + cooling-maps { + map0 { + trip = <&gpu_alert>; + cooling-device = + <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + }; + }; };
vpu-thermal { @@ -912,6 +926,7 @@ <&clk IMX8MQ_CLK_GPU_AXI>, <&clk IMX8MQ_CLK_GPU_AHB>; clock-names = "core", "shader", "bus", "reg"; + #cooling-cells = <2>; assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>, <&clk IMX8MQ_CLK_GPU_SHADER_SRC>, <&clk IMX8MQ_CLK_GPU_AXI>,
On Mi, 2019-09-11 at 19:40 -0700, Guido Günther wrote:
Temperature and hysteresis were picked after the CPU.
Signed-off-by: Guido Günther agx@sigxcpu.org
Reviewed-by: Lucas Stach l.stach@pengutronix.de
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index 4fdd60f2c51e..5023a0e5068d 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi @@ -235,12 +235,26 @@ thermal-sensors = <&tmu 1>;
trips {
gpu_alert: gpu-alert {temperature = <80000>;hysteresis = <2000>;type = "passive";};gpu-crit { temperature = <90000>; hysteresis = <2000>; type = "critical"; }; };cooling-maps {map0 {trip = <&gpu_alert>;cooling-device =<&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;};};};
vpu-thermal {
@@ -912,6 +926,7 @@ <&clk IMX8MQ_CLK_GPU_AXI>, <&clk IMX8MQ_CLK_GPU_AHB>; clock-names = "core", "shader", "bus", "reg";
#cooling-cells = <2>; assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>, <&clk IMX8MQ_CLK_GPU_SHADER_SRC>, <&clk IMX8MQ_CLK_GPU_AXI>,
On Wed, Sep 11, 2019 at 07:40:35PM -0700, Guido Günther wrote:
Temperature and hysteresis were picked after the CPU.
Signed-off-by: Guido Günther agx@sigxcpu.org
The patch prefix should be 'arm64: dts: ...'
I fixed it up and applied the patch.
Shawn
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index 4fdd60f2c51e..5023a0e5068d 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi @@ -235,12 +235,26 @@ thermal-sensors = <&tmu 1>;
trips {
gpu_alert: gpu-alert {temperature = <80000>;hysteresis = <2000>;type = "passive";};gpu-crit { temperature = <90000>; hysteresis = <2000>; type = "critical"; }; };cooling-maps {map0 {trip = <&gpu_alert>;cooling-device =<&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;};};};
vpu-thermal {
@@ -912,6 +926,7 @@ <&clk IMX8MQ_CLK_GPU_AXI>, <&clk IMX8MQ_CLK_GPU_AHB>; clock-names = "core", "shader", "bus", "reg";
#cooling-cells = <2>; assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>, <&clk IMX8MQ_CLK_GPU_SHADER_SRC>, <&clk IMX8MQ_CLK_GPU_AXI>,-- 2.23.0.rc1
Add #cooling-cells for when the gpu acts as a cooling device.
Signed-off-by: Guido Günther agx@sigxcpu.org --- .../devicetree/bindings/display/etnaviv/etnaviv-drm.txt | 1 + 1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt b/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt index 8def11b16a24..640592e8ab2e 100644 --- a/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt +++ b/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt @@ -21,6 +21,7 @@ Required properties: Optional properties: - power-domains: a power domain consumer specifier according to Documentation/devicetree/bindings/power/power_domain.txt +- #cooling-cells: : If used as a cooling device, must be <2>
example:
On Mi, 2019-09-11 at 19:40 -0700, Guido Günther wrote:
Add #cooling-cells for when the gpu acts as a cooling device.
Signed-off-by: Guido Günther agx@sigxcpu.org
Reviewed-by: Lucas Stach l.stach@pengutronix.de
.../devicetree/bindings/display/etnaviv/etnaviv-drm.txt | 1 + 1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt b/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt index 8def11b16a24..640592e8ab2e 100644 --- a/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt +++ b/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt @@ -21,6 +21,7 @@ Required properties: Optional properties:
- power-domains: a power domain consumer specifier according to Documentation/devicetree/bindings/power/power_domain.txt
+- #cooling-cells: : If used as a cooling device, must be <2>
example:
On Mon, Sep 16, 2019 at 04:32:55PM +0200, Lucas Stach wrote:
On Mi, 2019-09-11 at 19:40 -0700, Guido Günther wrote:
Add #cooling-cells for when the gpu acts as a cooling device.
Signed-off-by: Guido Günther agx@sigxcpu.org
Reviewed-by: Lucas Stach l.stach@pengutronix.de
Lucas,
I assume you will pick it up.
Shawn
.../devicetree/bindings/display/etnaviv/etnaviv-drm.txt | 1 + 1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt b/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt index 8def11b16a24..640592e8ab2e 100644 --- a/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt +++ b/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt @@ -21,6 +21,7 @@ Required properties: Optional properties:
- power-domains: a power domain consumer specifier according to Documentation/devicetree/bindings/power/power_domain.txt
+- #cooling-cells: : If used as a cooling device, must be <2>
example:
On Wed, 11 Sep 2019 19:40:36 -0700, =?UTF-8?q?Guido=20G=C3=BCnther?= wrote:
Add #cooling-cells for when the gpu acts as a cooling device.
Signed-off-by: Guido Günther agx@sigxcpu.org
.../devicetree/bindings/display/etnaviv/etnaviv-drm.txt | 1 + 1 file changed, 1 insertion(+)
Acked-by: Rob Herring robh@kernel.org
Hi, On Wed, Sep 11, 2019 at 07:40:36PM -0700, Guido Günther wrote:
Add #cooling-cells for when the gpu acts as a cooling device.
Signed-off-by: Guido Günther agx@sigxcpu.org
.../devicetree/bindings/display/etnaviv/etnaviv-drm.txt | 1 + 1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt b/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt index 8def11b16a24..640592e8ab2e 100644 --- a/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt +++ b/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt @@ -21,6 +21,7 @@ Required properties: Optional properties:
- power-domains: a power domain consumer specifier according to Documentation/devicetree/bindings/power/power_domain.txt
+- #cooling-cells: : If used as a cooling device, must be <2>
The other patch of the series made it into linux-next already but this documentation fixup didn't. Anything i can do to get this applied as well so documentation stays in sync? Cheers, -- Guido
example:
-- 2.23.0.rc1
linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
On Fr, 2019-10-18 at 15:50 +0200, Guido Günther wrote:
Hi, On Wed, Sep 11, 2019 at 07:40:36PM -0700, Guido Günther wrote:
Add #cooling-cells for when the gpu acts as a cooling device.
Signed-off-by: Guido Günther agx@sigxcpu.org
.../devicetree/bindings/display/etnaviv/etnaviv-drm.txt | 1 + 1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt b/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt index 8def11b16a24..640592e8ab2e 100644 --- a/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt +++ b/Documentation/devicetree/bindings/display/etnaviv/etnaviv-drm.txt @@ -21,6 +21,7 @@ Required properties: Optional properties:
- power-domains: a power domain consumer specifier according to Documentation/devicetree/bindings/power/power_domain.txt
+- #cooling-cells: : If used as a cooling device, must be <2>
The other patch of the series made it into linux-next already but this documentation fixup didn't. Anything i can do to get this applied as well so documentation stays in sync?
I've applied and pushed this to my etnaviv/next branch just now, so it should show up in linux-next pretty soon.
Regards, Lucas
dri-devel@lists.freedesktop.org
-
Guido Günther -
Lucas Stach -
Rob Herring -
Shawn Guo