v1: Enable runtime pm autosuspend by default for Gen12 and later versions.
v2: Enable runtime pm autosuspend by default for all platforms(Syrjala Ville)
v3: Change commit message(Nikula Jani) Let's enable runtime pm autosuspend by default everywhere. So, we can allow D3hot and bigger power savings on idle scenarios.
But at this time let's not touch the autosuspend_delay time, what caused some regression on our previous attempt.
Also, the latest identified issue on GuC PM has been fixed by commit 1a52faed3131 ("drm/i915/guc: Take GT PM ref when deregistering context")
Signed-off-by: Tilak Tangudu tilak.tangudu@intel.com --- drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c index 0d85f3c5c526..22dab36afcb6 100644 --- a/drivers/gpu/drm/i915/intel_runtime_pm.c +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c @@ -590,6 +590,9 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm) pm_runtime_use_autosuspend(kdev); }
+ /* Enable by default */ + pm_runtime_allow(kdev); + /* * The core calls the driver load handler with an RPM reference held. * We drop that here and will reacquire it during unloading in
-----Original Message----- From: Tangudu, Tilak tilak.tangudu@intel.com Sent: Tuesday, November 16, 2021 9:23 PM To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: Tangudu, Tilak tilak.tangudu@intel.com; Ewins, Jon jon.ewins@intel.com; Vivi, Rodrigo rodrigo.vivi@intel.com; Nilawar, Badal badal.nilawar@intel.com; Gupta, Anshuman anshuman.gupta@intel.com; Syrjala, Ville ville.syrjala@intel.com Subject: [PATCH v3] drm/i915/rpm: Enable runtime pm autosuspend by default
v1: Enable runtime pm autosuspend by default for Gen12 and later versions.
v2: Enable runtime pm autosuspend by default for all platforms(Syrjala Ville)
v3: Change commit message(Nikula Jani) Let's enable runtime pm autosuspend by default everywhere. So, we can allow D3hot and bigger power savings on idle scenarios.
But at this time let's not touch the autosuspend_delay time, what caused some regression on our previous attempt.
Also, the latest identified issue on GuC PM has been fixed by commit 1a52faed3131 ("drm/i915/guc: Take GT PM ref when deregistering context")
Signed-off-by: Tilak Tangudu tilak.tangudu@intel.com
drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c index 0d85f3c5c526..22dab36afcb6 100644 --- a/drivers/gpu/drm/i915/intel_runtime_pm.c +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c @@ -590,6 +590,9 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm) pm_runtime_use_autosuspend(kdev); }
- /* Enable by default */
- pm_runtime_allow(kdev);
BAT is failing due to soft lockup on SKL. How about to enable the runtime PM only for discrete platforms till we fixes all issues on Gen9 for hybrid gfx use cases. (when discrete card will used only for rendering) Thanks, Anshuman Gupta.
/* * The core calls the driver load handler with an RPM reference held. * We drop that here and will reacquire it during unloading in -- 2.25.1
On 2021-11-16 at 21:22:38 +0530, Tilak Tangudu wrote:
v1: Enable runtime pm autosuspend by default for Gen12 and later versions.
v2: Enable runtime pm autosuspend by default for all platforms(Syrjala Ville)
v3: Change commit message(Nikula Jani)
It would require to reorder the commit log, version log need to move after commit message. Thanks, Anshuman.
Let's enable runtime pm autosuspend by default everywhere. So, we can allow D3hot and bigger power savings on idle scenarios.
But at this time let's not touch the autosuspend_delay time, what caused some regression on our previous attempt.
Also, the latest identified issue on GuC PM has been fixed by commit 1a52faed3131 ("drm/i915/guc: Take GT PM ref when deregistering context")
Signed-off-by: Tilak Tangudu tilak.tangudu@intel.com
drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c index 0d85f3c5c526..22dab36afcb6 100644 --- a/drivers/gpu/drm/i915/intel_runtime_pm.c +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c @@ -590,6 +590,9 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm) pm_runtime_use_autosuspend(kdev); }
- /* Enable by default */
- pm_runtime_allow(kdev);
- /*
- The core calls the driver load handler with an RPM reference held.
- We drop that here and will reacquire it during unloading in
-- 2.25.1
On Mon, Nov 22, 2021 at 07:18:17PM +0530, Anshuman Gupta wrote:
On 2021-11-16 at 21:22:38 +0530, Tilak Tangudu wrote:
v1: Enable runtime pm autosuspend by default for Gen12 and later versions.
v2: Enable runtime pm autosuspend by default for all platforms(Syrjala Ville)
v3: Change commit message(Nikula Jani)
It would require to reorder the commit log, version log need to move after commit message.
Well noticed. I changed while pushing.
So, for the record:
Reviewed-by: Rodrigo Vivi rodrigo.vivi@intel.com Signed-off-by: Rodrigo Vivi rodrigo.vivi@intel.com
Thanks, Anshuman.
Let's enable runtime pm autosuspend by default everywhere. So, we can allow D3hot and bigger power savings on idle scenarios.
But at this time let's not touch the autosuspend_delay time, what caused some regression on our previous attempt.
Also, the latest identified issue on GuC PM has been fixed by commit 1a52faed3131 ("drm/i915/guc: Take GT PM ref when deregistering context")
Signed-off-by: Tilak Tangudu tilak.tangudu@intel.com
drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c index 0d85f3c5c526..22dab36afcb6 100644 --- a/drivers/gpu/drm/i915/intel_runtime_pm.c +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c @@ -590,6 +590,9 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm) pm_runtime_use_autosuspend(kdev); }
- /* Enable by default */
- pm_runtime_allow(kdev);
- /*
- The core calls the driver load handler with an RPM reference held.
- We drop that here and will reacquire it during unloading in
-- 2.25.1
dri-devel@lists.freedesktop.org
-
Anshuman Gupta -
Gupta, Anshuman
-
Rodrigo Vivi -
Tilak Tangudu