On Fri, Sep 11, 2020 at 07:57:18PM +0530, Sai Prakash Ranjan wrote:
Add a quirk IO_PGTABLE_QUIRK_SYS_CACHE to override the attributes set in TCR for the page table walker when using system cache.
I wonder if the panfrost folks can reuse this for the issue discussed over at:
https://lore.kernel.org/r/cover.1600213517.git.robin.murphy@arm.com
However, Sai, your email setup went wrong when you posted this so you probably need to repost now that you have that fixed.
Will
On 2020-09-21 19:03, Will Deacon wrote:
On Fri, Sep 11, 2020 at 07:57:18PM +0530, Sai Prakash Ranjan wrote:
Add a quirk IO_PGTABLE_QUIRK_SYS_CACHE to override the attributes set in TCR for the page table walker when using system cache.
I wonder if the panfrost folks can reuse this for the issue discussed over at:
https://lore.kernel.org/r/cover.1600213517.git.robin.murphy@arm.com
Isn't this all hinged around the outer cacheability attribute, rather than shareability (since these are nominally NC mappings and thus already properly Osh)? The Panfrost issue is just about shareability domains being a bit wonky; the cacheability attributes there are actually reasonably normal (other than not having a non-cacheable type at all, only a choice of allocation policies...)
Robin.
However, Sai, your email setup went wrong when you posted this so you probably need to repost now that you have that fixed.
Will _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu
On Mon, Sep 21, 2020 at 11:03:49PM +0100, Robin Murphy wrote:
On 2020-09-21 19:03, Will Deacon wrote:
On Fri, Sep 11, 2020 at 07:57:18PM +0530, Sai Prakash Ranjan wrote:
Add a quirk IO_PGTABLE_QUIRK_SYS_CACHE to override the attributes set in TCR for the page table walker when using system cache.
I wonder if the panfrost folks can reuse this for the issue discussed over at:
https://lore.kernel.org/r/cover.1600213517.git.robin.murphy@arm.com
Isn't this all hinged around the outer cacheability attribute, rather than shareability (since these are nominally NC mappings and thus already properly Osh)? The Panfrost issue is just about shareability domains being a bit wonky; the cacheability attributes there are actually reasonably normal (other than not having a non-cacheable type at all, only a choice of allocation policies...)
Hmm, yes, this quirk _also_ changes the cacheability settings which isn't what we need. It's a bit grotty having two different ways to configure these TCR bits (i.e. a quirk and a format), but at least the mali format rejects all of the quirks so I suppose it's not the end of the world.
Will
Hi Will,
On 2020-09-21 23:33, Will Deacon wrote:
On Fri, Sep 11, 2020 at 07:57:18PM +0530, Sai Prakash Ranjan wrote:
Add a quirk IO_PGTABLE_QUIRK_SYS_CACHE to override the attributes set in TCR for the page table walker when using system cache.
I wonder if the panfrost folks can reuse this for the issue discussed over at:
https://lore.kernel.org/r/cover.1600213517.git.robin.murphy@arm.com
However, Sai, your email setup went wrong when you posted this so you probably need to repost now that you have that fixed.
I have sent a v5 [1] now since I had to drop cleanup of blank lines as Robin said it was intentional and also had to rebase over new gpu changes since it moves pretty fast.
[1] https://lore.kernel.org/patchwork/cover/1310000/
Thanks, Sai
dri-devel@lists.freedesktop.org
-
Robin Murphy -
Sai Prakash Ranjan -
Will Deacon