From: Oleksandr Suvorov oleksandr.suvorov@toradex.com
VESA Display Monitor Timing v1.13 has recommendations for the historical VGA mode 640x480 60Hz. These parameters are compatible with EDT ET057090DHU recommended timings.
Use VESA DMT timing parameters for EDT ET057090DHU panel.
Signed-off-by: Oleksandr Suvorov oleksandr.suvorov@toradex.com Cc: Oleksandr Suvorov oleksandr.suvorov@foundries.io Signed-off-by: Francesco Dolcini francesco.dolcini@toradex.com --- drivers/gpu/drm/panel/panel-simple.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 9e46db5e359c..c11427f94ac5 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1598,12 +1598,13 @@ static const struct drm_display_mode edt_et057090dhu_mode = { .clock = 25175, .hdisplay = 640, .hsync_start = 640 + 16, - .hsync_end = 640 + 16 + 30, - .htotal = 640 + 16 + 30 + 114, + .hsync_end = 640 + 16 + 48, + .htotal = 640 + 16 + 48 + 96, .vdisplay = 480, .vsync_start = 480 + 10, - .vsync_end = 480 + 10 + 3, - .vtotal = 480 + 10 + 3 + 32, + .vsync_end = 480 + 10 + 2, + .vtotal = 480 + 10 + 2 + 33, + .vrefresh = 60, .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, };
Hi Francesco,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm/drm-next] [also build test ERROR on v5.17-rc1 next-20220127] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Francesco-Dolcini/drm-panel-simple-... base: git://anongit.freedesktop.org/drm/drm drm-next config: ia64-allmodconfig (https://download.01.org/0day-ci/archive/20220127/202201271923.eBYUUA3X-lkp@i...) compiler: ia64-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/db3299763c5ae747c148fc1d85af84f93601... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Francesco-Dolcini/drm-panel-simple-Tune-timing-for-ET057090DHU/20220127-153123 git checkout db3299763c5ae747c148fc1d85af84f9360189fc # save the config file to linux build tree mkdir build_dir COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/gpu/drm/panel/
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
drivers/gpu/drm/panel/panel-simple.c:1607:10: error: 'const struct drm_display_mode' has no member named 'vrefresh'
1607 | .vrefresh = 60, | ^~~~~~~~
vim +1607 drivers/gpu/drm/panel/panel-simple.c
1596 1597 static const struct drm_display_mode edt_et057090dhu_mode = { 1598 .clock = 25175, 1599 .hdisplay = 640, 1600 .hsync_start = 640 + 16, 1601 .hsync_end = 640 + 16 + 48, 1602 .htotal = 640 + 16 + 48 + 96, 1603 .vdisplay = 480, 1604 .vsync_start = 480 + 10, 1605 .vsync_end = 480 + 10 + 2, 1606 .vtotal = 480 + 10 + 2 + 33,
1607 .vrefresh = 60,
1608 .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, 1609 }; 1610
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
dri-devel@lists.freedesktop.org
-
Francesco Dolcini -
kernel test robot