attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const.
File size before: text data bss dec hex filename 2673 368 0 3041 be1 panel-tpo-td043mtea1.o
File size After adding 'const': text data bss dec hex filename 2721 304 0 3025 bd1 panel-tpo-td043mtea1.o
Signed-off-by: Arvind Yadav arvind.yadav.cs@gmail.com --- drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c index 0787dba..b2a9946 100644 --- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c +++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c @@ -284,7 +284,7 @@ static DEVICE_ATTR(gamma, S_IRUGO | S_IWUSR, NULL, };
-static struct attribute_group tpo_td043_attr_group = { +static const struct attribute_group tpo_td043_attr_group = { .attrs = tpo_td043_attrs, };
dri-devel@lists.freedesktop.org