From: Carsten Haitzler carsten.haitzler@arm.com
Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
Signed-off-by: Carsten Haitzler carsten.haitzler@arm.com --- drivers/gpu/drm/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig index 58a242871b28..6e3f1d600541 100644 --- a/drivers/gpu/drm/arm/Kconfig +++ b/drivers/gpu/drm/arm/Kconfig @@ -6,6 +6,7 @@ config DRM_HDLCD depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST) depends on COMMON_CLK select DRM_KMS_HELPER + select DRM_GEM_CMA_HELPER help Choose this option if you have an ARM High Definition Colour LCD controller.
On Mon, Jan 24, 2022 at 04:24:37PM +0000, carsten.haitzler@foss.arm.com wrote:
From: Carsten Haitzler carsten.haitzler@arm.com
Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
Signed-off-by: Carsten Haitzler carsten.haitzler@arm.com
Acked-by: Liviu Dudau liviu.dudau@arm.com
I will add Steven's reviewed-by as well when pushing it.
Best regards, Liviu
drivers/gpu/drm/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig index 58a242871b28..6e3f1d600541 100644 --- a/drivers/gpu/drm/arm/Kconfig +++ b/drivers/gpu/drm/arm/Kconfig @@ -6,6 +6,7 @@ config DRM_HDLCD depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST) depends on COMMON_CLK select DRM_KMS_HELPER
- select DRM_GEM_CMA_HELPER help Choose this option if you have an ARM High Definition Colour LCD controller.
-- 2.30.1
On Tue, 25 Jan 2022 12:37:38 +0000 Liviu Dudau liviu.dudau@arm.com wrote:
Hi,
On Mon, Jan 24, 2022 at 04:24:37PM +0000, carsten.haitzler@foss.arm.com wrote:
From: Carsten Haitzler carsten.haitzler@arm.com
Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
Signed-off-by: Carsten Haitzler carsten.haitzler@arm.com
Acked-by: Liviu Dudau liviu.dudau@arm.com
I will add Steven's reviewed-by as well when pushing it.
Did this go anywhere? I see my .config just selecting HDLCD still failing with -rc5. Any chance this can be taken now, as this is a regression introduced with -rc1?
Cheers, Andre
drivers/gpu/drm/arm/Kconfig | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig index 58a242871b28..6e3f1d600541 100644 --- a/drivers/gpu/drm/arm/Kconfig +++ b/drivers/gpu/drm/arm/Kconfig @@ -6,6 +6,7 @@ config DRM_HDLCD depends on DRM && OF && (ARM || ARM64 || COMPILE_TEST) depends on COMMON_CLK select DRM_KMS_HELPER
- select DRM_GEM_CMA_HELPER help Choose this option if you have an ARM High Definition Colour LCD controller.
-- 2.30.1
On Wed, Feb 23, 2022 at 4:19 AM Andre Przywara andre.przywara@arm.com wrote:
On Tue, 25 Jan 2022 12:37:38 +0000 Liviu Dudau liviu.dudau@arm.com wrote:
Hi,
On Mon, Jan 24, 2022 at 04:24:37PM +0000, carsten.haitzler@foss.arm.com wrote:
From: Carsten Haitzler carsten.haitzler@arm.com
Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too.
Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option")
Signed-off-by: Carsten Haitzler carsten.haitzler@arm.com
Acked-by: Liviu Dudau liviu.dudau@arm.com
I will add Steven's reviewed-by as well when pushing it.
Did this go anywhere? I see my .config just selecting HDLCD still failing with -rc5. Any chance this can be taken now, as this is a regression introduced with -rc1?
I thought Liviu was going to, but in any case I've now pushed it to drm-misc-fixes.
Rob
dri-devel@lists.freedesktop.org
-
Andre Przywara -
carsten.haitzler＠foss.arm.com -
Liviu Dudau -
Rob Herring