Hi Xu Wang,

Thank you for the patch.

On Fri, Nov 27, 2020 at 09:18:29AM +0000, Xu Wang wrote:

Because clk_disable_unprepare() already checked NULL clock parameter, so the additional check is unnecessary, just remove them.

Signed-off-by: Xu Wang vulab@iscas.ac.cn

Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com

---

drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index a0d392c338da..76555ae64e9c 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -1292,8 +1292,7 @@ static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)

err_unregister_cec: i2c_unregister_device(adv7511->i2c_cec);

• if (adv7511->cec_clk)

• clk_disable_unprepare(adv7511->cec_clk);
  

• clk_disable_unprepare(adv7511->cec_clk);

err_i2c_unregister_packet: i2c_unregister_device(adv7511->i2c_packet); err_i2c_unregister_edid: @@ -1311,8 +1310,7 @@ static int adv7511_remove(struct i2c_client *i2c) if (adv7511->type == ADV7533 || adv7511->type == ADV7535) adv7533_detach_dsi(adv7511); i2c_unregister_device(adv7511->i2c_cec);

• if (adv7511->cec_clk)

• clk_disable_unprepare(adv7511->cec_clk);
  

• clk_disable_unprepare(adv7511->cec_clk);

  adv7511_uninit_regulators(adv7511);