Signed-off-by: Nayan Deshmukh nayan26deshmukh@gmail.com --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 0d95888ccc3e..27fdda1264f7 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -117,7 +117,6 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq) * @sched The pointer to the scheduler * @entity The pointer to a valid drm_sched_entity * @rq The run queue this entity belongs - * @kernel If this is an entity for the kernel * @jobs The max number of jobs in the job queue * * return 0 if succeed. negative error code on failure
Am 25.03.2018 um 13:09 schrieb Nayan Deshmukh:
Signed-off-by: Nayan Deshmukh nayan26deshmukh@gmail.com
drivers/gpu/drm/scheduler/gpu_scheduler.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 0d95888ccc3e..27fdda1264f7 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -117,7 +117,6 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq)
- @sched The pointer to the scheduler
- @entity The pointer to a valid drm_sched_entity
- @rq The run queue this entity belongs
- @kernel If this is an entity for the kernel
- @jobs The max number of jobs in the job queue
If I'm not completely mistaken the jobs parameter is unused and we also have a @guilty parameter as well.
The description for the @guilty should be something like "atomic_t set to 1 when a job on this queue is found to be guilty causing a timeout".
Regards, Christian.
- return 0 if succeed. negative error code on failure
On Sun, Mar 25, 2018 at 4:44 PM, Christian König christian.koenig@amd.com wrote:
Am 25.03.2018 um 13:09 schrieb Nayan Deshmukh:
Signed-off-by: Nayan Deshmukh nayan26deshmukh@gmail.com
drivers/gpu/drm/scheduler/gpu_scheduler.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 0d95888ccc3e..27fdda1264f7 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -117,7 +117,6 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq)
- @sched The pointer to the scheduler
- @entity The pointer to a valid drm_sched_entity
- @rq The run queue this entity belongs
- @kernel If this is an entity for the kernel
- @jobs The max number of jobs in the job queue
If I'm not completely mistaken the jobs parameter is unused and we also have a @guilty parameter as well.
Yes. But I am not sure what should be done with the jobs parameter. Should I remove it entirely?
The description for the @guilty should be something like "atomic_t set to 1 when a job on this queue is found to be guilty causing a timeout".
Regards, Christian.
- return 0 if succeed. negative error code on failure
Am 25.03.2018 um 13:21 schrieb Nayan Deshmukh:
On Sun, Mar 25, 2018 at 4:44 PM, Christian König christian.koenig@amd.com wrote:
Am 25.03.2018 um 13:09 schrieb Nayan Deshmukh:
Signed-off-by: Nayan Deshmukh nayan26deshmukh@gmail.com
drivers/gpu/drm/scheduler/gpu_scheduler.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 0d95888ccc3e..27fdda1264f7 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -117,7 +117,6 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq) * @sched The pointer to the scheduler * @entity The pointer to a valid drm_sched_entity * @rq The run queue this entity belongs
- @kernel If this is an entity for the kernel
- @jobs The max number of jobs in the job queue
If I'm not completely mistaken the jobs parameter is unused and we also have a @guilty parameter as well.
Yes. But I am not sure what should be done with the jobs parameter. Should I remove it entirely?
Yes, probably a leftover from when we used a kfifo for the queue.
Regards, Christian.
The description for the @guilty should be something like "atomic_t set to 1 when a job on this queue is found to be guilty causing a timeout".
Regards, Christian.
* * return 0 if succeed. negative error code on failure
Signed-off-by: Nayan Deshmukh nayan26deshmukh@gmail.com --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 0d95888ccc3e..1d368bc66ac2 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -117,8 +117,9 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq) * @sched The pointer to the scheduler * @entity The pointer to a valid drm_sched_entity * @rq The run queue this entity belongs - * @kernel If this is an entity for the kernel * @jobs The max number of jobs in the job queue + * @guilty atomic_t set to 1 when a job on this queue + * is found to be guilty causing a timeout * * return 0 if succeed. negative error code on failure */
A bit more commit message would be nice to have, like "There is no more @kernel parameter and document the new @guilty parameter".
Am 26.03.2018 um 17:21 schrieb Nayan Deshmukh:
Signed-off-by: Nayan Deshmukh nayan26deshmukh@gmail.com
With the commit message fixed the patch is Reviewed-by: Christian König christian.koenig@amd.com.
Christian.
drivers/gpu/drm/scheduler/gpu_scheduler.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 0d95888ccc3e..1d368bc66ac2 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -117,8 +117,9 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq)
- @sched The pointer to the scheduler
- @entity The pointer to a valid drm_sched_entity
- @rq The run queue this entity belongs
- @kernel If this is an entity for the kernel
- @jobs The max number of jobs in the job queue
- @guilty atomic_t set to 1 when a job on this queue
*/
is found to be guilty causing a timeout- return 0 if succeed. negative error code on failure
There is no @kernel parameter anymore and document the @guilty parameter
Signed-off-by: Nayan Deshmukh nayan26deshmukh@gmail.com --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 0d95888ccc3e..1d368bc66ac2 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -117,8 +117,9 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq) * @sched The pointer to the scheduler * @entity The pointer to a valid drm_sched_entity * @rq The run queue this entity belongs - * @kernel If this is an entity for the kernel * @jobs The max number of jobs in the job queue + * @guilty atomic_t set to 1 when a job on this queue + * is found to be guilty causing a timeout * * return 0 if succeed. negative error code on failure */
On Mon, Mar 26, 2018 at 08:51:14PM +0530, Nayan Deshmukh wrote:
Signed-off-by: Nayan Deshmukh nayan26deshmukh@gmail.com
You might want to add a kerneldoc page in Documentation/gpu/scheduler.rst, which pulls in all the nice kerneldoc you have here + has a short intro text what this is all about.
Cheers, Daniel
drivers/gpu/drm/scheduler/gpu_scheduler.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 0d95888ccc3e..1d368bc66ac2 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -117,8 +117,9 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq)
- @sched The pointer to the scheduler
- @entity The pointer to a valid drm_sched_entity
- @rq The run queue this entity belongs
- @kernel If this is an entity for the kernel
- @jobs The max number of jobs in the job queue
- @guilty atomic_t set to 1 when a job on this queue
is found to be guilty causing a timeout- return 0 if succeed. negative error code on failure
*/
2.14.3
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Tue, Mar 27, 2018 at 1:47 PM, Daniel Vetter daniel@ffwll.ch wrote:
On Mon, Mar 26, 2018 at 08:51:14PM +0530, Nayan Deshmukh wrote:
Signed-off-by: Nayan Deshmukh nayan26deshmukh@gmail.com
You might want to add a kerneldoc page in Documentation/gpu/scheduler.rst, which pulls in all the nice kerneldoc you have here + has a short intro text what this is all about.
Yeah Sure. I'll send a patch for this in a while.
Cheers, Nayan
Cheers, Daniel
drivers/gpu/drm/scheduler/gpu_scheduler.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 0d95888ccc3e..1d368bc66ac2 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -117,8 +117,9 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq)
- @sched The pointer to the scheduler
- @entity The pointer to a valid drm_sched_entity
- @rq The run queue this entity belongs
- @kernel If this is an entity for the kernel
- @jobs The max number of jobs in the job queue
- @guilty atomic_t set to 1 when a job on this queue
is found to be guilty causing a timeout- return 0 if succeed. negative error code on failure
*/
2.14.3
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
On Tue, Mar 27, 2018 at 1:29 PM, Nayan Deshmukh nayan26deshmukh@gmail.com wrote:
On Tue, Mar 27, 2018 at 1:47 PM, Daniel Vetter daniel@ffwll.ch wrote:
On Mon, Mar 26, 2018 at 08:51:14PM +0530, Nayan Deshmukh wrote:
Signed-off-by: Nayan Deshmukh nayan26deshmukh@gmail.com
You might want to add a kerneldoc page in Documentation/gpu/scheduler.rst, which pulls in all the nice kerneldoc you have here + has a short intro text what this is all about.
Yeah Sure. I'll send a patch for this in a while.
FWIW, I started improving the documentation in the GPU scheduler last week, but ran out of time to finish it. Here's the WIP patch. Feel free to run with it.
Alex
Cheers, Nayan
Cheers, Daniel
drivers/gpu/drm/scheduler/gpu_scheduler.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 0d95888ccc3e..1d368bc66ac2 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -117,8 +117,9 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq)
- @sched The pointer to the scheduler
- @entity The pointer to a valid drm_sched_entity
- @rq The run queue this entity belongs
- @kernel If this is an entity for the kernel
- @jobs The max number of jobs in the job queue
- @guilty atomic_t set to 1 when a job on this queue
is found to be guilty causing a timeout- return 0 if succeed. negative error code on failure
*/
2.14.3
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Thu, Mar 29, 2018 at 8:56 PM, Alex Deucher alexdeucher@gmail.com wrote:
On Tue, Mar 27, 2018 at 1:29 PM, Nayan Deshmukh nayan26deshmukh@gmail.com wrote:
On Tue, Mar 27, 2018 at 1:47 PM, Daniel Vetter daniel@ffwll.ch wrote:
On Mon, Mar 26, 2018 at 08:51:14PM +0530, Nayan Deshmukh wrote:
Signed-off-by: Nayan Deshmukh nayan26deshmukh@gmail.com
You might want to add a kerneldoc page in Documentation/gpu/scheduler.rst, which pulls in all the nice kerneldoc you have here + has a short intro text what this is all about.
Yeah Sure. I'll send a patch for this in a while.
FWIW, I started improving the documentation in the GPU scheduler last week, but ran out of time to finish it. Here's the WIP patch. Feel free to run with it.
This will be useful. I'll go over it during the weekend and probably send a patch early next week.
Thanks
Alex
Cheers, Nayan
Cheers, Daniel
drivers/gpu/drm/scheduler/gpu_scheduler.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 0d95888ccc3e..1d368bc66ac2 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -117,8 +117,9 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq)
- @sched The pointer to the scheduler
- @entity The pointer to a valid drm_sched_entity
- @rq The run queue this entity belongs
- @kernel If this is an entity for the kernel
- @jobs The max number of jobs in the job queue
- @guilty atomic_t set to 1 when a job on this queue
is found to be guilty causing a timeout- return 0 if succeed. negative error code on failure
*/
2.14.3
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
I am not removing jobs parameters as of now as it will lead to changes in all the calls to this function and will affect the etnaviv patches.
Regards, Nayan.
On Sun, Mar 25, 2018 at 4:59 PM, Christian König christian.koenig@amd.com wrote:
Am 25.03.2018 um 13:21 schrieb Nayan Deshmukh:
On Sun, Mar 25, 2018 at 4:44 PM, Christian König christian.koenig@amd.com wrote:
Am 25.03.2018 um 13:09 schrieb Nayan Deshmukh:
Signed-off-by: Nayan Deshmukh nayan26deshmukh@gmail.com
drivers/gpu/drm/scheduler/gpu_scheduler.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 0d95888ccc3e..27fdda1264f7 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -117,7 +117,6 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq) * @sched The pointer to the scheduler * @entity The pointer to a valid drm_sched_entity * @rq The run queue this entity belongs
- @kernel If this is an entity for the kernel
- @jobs The max number of jobs in the job queue
If I'm not completely mistaken the jobs parameter is unused and we also have a @guilty parameter as well.
Yes. But I am not sure what should be done with the jobs parameter. Should I remove it entirely?
Yes, probably a leftover from when we used a kfifo for the queue.
Regards, Christian.
The description for the @guilty should be something like "atomic_t set to 1 when a job on this queue is found to be guilty causing a timeout".
Regards, Christian.
* * return 0 if succeed. negative error code on failure
Yeah, probably good idea to have that separate.
But would still be a nice cleanup and it is merged upstream after the etnaviv patches anyway.
Regards, Christian.
Am 26.03.2018 um 17:29 schrieb Nayan Deshmukh:
I am not removing jobs parameters as of now as it will lead to changes in all the calls to this function and will affect the etnaviv patches.
Regards, Nayan.
On Sun, Mar 25, 2018 at 4:59 PM, Christian König christian.koenig@amd.com wrote:
Am 25.03.2018 um 13:21 schrieb Nayan Deshmukh:
On Sun, Mar 25, 2018 at 4:44 PM, Christian König christian.koenig@amd.com wrote:
Am 25.03.2018 um 13:09 schrieb Nayan Deshmukh:
Signed-off-by: Nayan Deshmukh nayan26deshmukh@gmail.com
drivers/gpu/drm/scheduler/gpu_scheduler.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 0d95888ccc3e..27fdda1264f7 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -117,7 +117,6 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq) * @sched The pointer to the scheduler * @entity The pointer to a valid drm_sched_entity * @rq The run queue this entity belongs
- @kernel If this is an entity for the kernel
- @jobs The max number of jobs in the job queue
If I'm not completely mistaken the jobs parameter is unused and we also have a @guilty parameter as well.
Yes. But I am not sure what should be done with the jobs parameter. Should I remove it entirely?
Yes, probably a leftover from when we used a kfifo for the queue.
Regards, Christian.
The description for the @guilty should be something like "atomic_t set to 1 when a job on this queue is found to be guilty causing a timeout".
Regards, Christian.
* * return 0 if succeed. negative error code on failure
I will send in the patches.
On Mon, Mar 26, 2018 at 10:29 PM, Christian König christian.koenig@amd.com wrote:
Yeah, probably good idea to have that separate.
But would still be a nice cleanup and it is merged upstream after the etnaviv patches anyway.
Regards, Christian.
Am 26.03.2018 um 17:29 schrieb Nayan Deshmukh:
I am not removing jobs parameters as of now as it will lead to changes in all the calls to this function and will affect the etnaviv patches.
Regards, Nayan.
On Sun, Mar 25, 2018 at 4:59 PM, Christian König christian.koenig@amd.com wrote:
Am 25.03.2018 um 13:21 schrieb Nayan Deshmukh:
On Sun, Mar 25, 2018 at 4:44 PM, Christian König christian.koenig@amd.com wrote:
Am 25.03.2018 um 13:09 schrieb Nayan Deshmukh:
Signed-off-by: Nayan Deshmukh nayan26deshmukh@gmail.com
drivers/gpu/drm/scheduler/gpu_scheduler.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler.c b/drivers/gpu/drm/scheduler/gpu_scheduler.c index 0d95888ccc3e..27fdda1264f7 100644 --- a/drivers/gpu/drm/scheduler/gpu_scheduler.c +++ b/drivers/gpu/drm/scheduler/gpu_scheduler.c @@ -117,7 +117,6 @@ drm_sched_rq_select_entity(struct drm_sched_rq *rq) * @sched The pointer to the scheduler * @entity The pointer to a valid drm_sched_entity * @rq The run queue this entity belongs
- @kernel If this is an entity for the kernel
- @jobs The max number of jobs in the job queue
If I'm not completely mistaken the jobs parameter is unused and we also have a @guilty parameter as well.
Yes. But I am not sure what should be done with the jobs parameter. Should I remove it entirely?
Yes, probably a leftover from when we used a kfifo for the queue.
Regards, Christian.
The description for the @guilty should be something like "atomic_t set to 1 when a job on this queue is found to be guilty causing a timeout".
Regards, Christian.
* * return 0 if succeed. negative error code on failure
dri-devel@lists.freedesktop.org
-
Alex Deucher -
Christian König -
Daniel Vetter -
Nayan Deshmukh