Hi Sagar,

Thank you for the patch.

On Saturday 08 March 2014 13:51:19 sagar.a.kamble@intel.com wrote:

From: Sagar Kamble sagar.a.kamble@intel.com

Cc: Rob Landley rob@landley.net Cc: Dave Airlie airlied@redhat.com Cc: Daniel Vetter daniel.vetter@ffwll.ch Cc: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com Cc: David Herrmann dh.herrmann@gmail.com Cc: Alex Deucher alexander.deucher@amd.com Cc: "Ville Syrjälä" ville.syrjala@linux.intel.com Cc: Sagar Kamble sagar.a.kamble@intel.com Cc: "Purushothaman, Vijay A" vijay.a.purushothaman@intel.com Cc: linux-doc@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Sagar Kamble sagar.a.kamble@intel.com

---

Documentation/DocBook/drm.tmpl | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl index 5650d13..ba260e8 100644 --- a/Documentation/DocBook/drm.tmpl +++ b/Documentation/DocBook/drm.tmpl @@ -2334,7 +2334,7 @@ void intel_crt_init(struct drm_device *dev)

</tr> <tr> <td rowspan="19" valign="top" >DRM</td> -<td rowspan="2" valign="top" >Generic</td> +<td rowspan="3" valign="top" >Generic</td> <td valign="top" >“EDID”</td> <td valign="top" >BLOB | IMMUTABLE</td> <td valign="top" >0</td> @@ -2349,6 +2349,17 @@ void intel_crt_init(struct drm_device *dev) <td valign="top" >Contains DPMS operation mode value.</td> </tr> <tr> +<td valign="top" >“blend”</td> +<td valign="top" >BITMASK</td> +<td valign="top" >{ {0, "none"}, {1, "zero"}, {2, "one"}, {3, "src-color"}, {4, "one-minus-src-color"} +, {5, "dst-color"}, {6, "one-minus-dst-color"}, {7, "src-alpha"}, {8, "one-minus-src-alpha"}, {9, "dst-alpha"} +, {10, "one-minus-dst-alpha"}, {11, "constant-color"}, {12, "one-minus-constant-color"}, {13, "constant-alpha"} +, {14, "one-minus-constant-alpha"}, {15, "alpha-saturate"}, {16, "src1-color"}, {17, "one-minus-src1-color"} +, {18, "src1-alpha"}, {19, "one-minus-src1-alpha"}, {20, "pre-multiplied-alpha"} }</td> +<td valign="top" >Plane</td> +<td valign="top" >Contains plane alpha/color blending operation value.</td>

I believe this calls for a description of each property value. From patches 1/4 and 4/4 it's not entirely clear to me what all values mean.

+</tr> +<tr>

<td rowspan="2" valign="top" >DVI-I</td> <td valign="top" >“subconnector”</td> <td valign="top" >ENUM</td>