Already fixed. Thanks for the patch.

Alex

On Thu, Feb 24, 2022 at 5:43 PM Colin Ian King colin.i.king@gmail.com wrote:

Currently the call to function amdgpu_benchmark_move should be assigning the return value to variable r as this is checked in the next statement, however, this assignment is missing. Fix this by adding in the missing assignment.

Addresses clang scan warning: drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c:168:7: warning: variable 'r' is uninitialized when used here [-Wuninitialized]

Fixes: 9645c9c9fb15 ("drm/amdgpu: plumb error handling though amdgpu_benchmark()") Signed-off-by: Colin Ian King colin.i.king@gmail.com

---

drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c index 3136a9ad2d54..bb293a5c6fd5 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_benchmark.c @@ -163,7 +163,7 @@ int amdgpu_benchmark(struct amdgpu_device *adev, int test_number) "benchmark test: %d (simple test, VRAM to VRAM)\n", test_number); /* simple test, VRAM to VRAM */

•           amdgpu_benchmark_move(adev, 1024*1024, AMDGPU_GEM_DOMAIN_VRAM,
  

•           r = amdgpu_benchmark_move(adev, 1024*1024, AMDGPU_GEM_DOMAIN_VRAM,
                                  AMDGPU_GEM_DOMAIN_VRAM);
            if (r)
                    goto done;
  

-- 2.34.1