The variable 'priv' got introduced in commit 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces") by accident. It's unused; remove it. Fixes a compiler warning.
Signed-off-by: Thomas Zimmermann tzimmermann@suse.de Fixes: 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces") Reported-by: Dave Airlie airlied@gmail.com Cc: Thomas Zimmermann tzimmermann@suse.de Cc: Tian Tao tiantao6@hisilicon.com Cc: Maxime Ripard maxime@cerno.tech Cc: Daniel Vetter daniel.vetter@ffwll.ch Cc: Sam Ravnborg sam@ravnborg.org --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c index f73a8e0ea12e..610fc8e135f9 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c @@ -249,7 +249,6 @@ static int hibmc_hw_init(struct hibmc_drm_private *priv)
static int hibmc_unload(struct drm_device *dev) { - struct hibmc_drm_private *priv = to_hibmc_drm_private(dev); struct pci_dev *pdev = to_pci_dev(dev->dev);
drm_atomic_helper_shutdown(dev);
On Wed, Jul 21, 2021 at 3:17 PM Thomas Zimmermann tzimmermann@suse.de wrote:
The variable 'priv' got introduced in commit 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces") by accident. It's unused; remove it. Fixes a compiler warning.
Signed-off-by: Thomas Zimmermann tzimmermann@suse.de Fixes: 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces") Reported-by: Dave Airlie airlied@gmail.com Cc: Thomas Zimmermann tzimmermann@suse.de Cc: Tian Tao tiantao6@hisilicon.com Cc: Maxime Ripard maxime@cerno.tech Cc: Daniel Vetter daniel.vetter@ffwll.ch Cc: Sam Ravnborg sam@ravnborg.org
Reviewed-by: Daniel Vetter daniel.vetter@ffwll.ch
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c index f73a8e0ea12e..610fc8e135f9 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c @@ -249,7 +249,6 @@ static int hibmc_hw_init(struct hibmc_drm_private *priv)
static int hibmc_unload(struct drm_device *dev) {
struct hibmc_drm_private *priv = to_hibmc_drm_private(dev); struct pci_dev *pdev = to_pci_dev(dev->dev); drm_atomic_helper_shutdown(dev);-- 2.32.0
Reviewed-by: Tian Tao tiantao6@hisilicon.com
-----邮件原件----- 发件人: Thomas Zimmermann [mailto:tzimmermann@suse.de] 发送时间: 2021年7月21日 21:17 收件人: xinliang.liu@linaro.org; tiantao (H) tiantao6@hisilicon.com; john.stultz@linaro.org; kongxinwei (A) kong.kongxinwei@hisilicon.com; Chenfeng (puck) puck.chen@hisilicon.com; airlied@linux.ie; daniel@ffwll.ch; maxime@cerno.tech; sam@ravnborg.org 抄送: dri-devel@lists.freedesktop.org; Thomas Zimmermann tzimmermann@suse.de; Dave Airlie airlied@gmail.com; Daniel Vetter daniel.vetter@ffwll.ch 主题: [PATCH] drm/hisilicon/hibmc: Remove variable 'priv' from hibmc_unload()
The variable 'priv' got introduced in commit 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces") by accident. It's unused; remove it. Fixes a compiler warning.
Signed-off-by: Thomas Zimmermann tzimmermann@suse.de Fixes: 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces") Reported-by: Dave Airlie airlied@gmail.com Cc: Thomas Zimmermann tzimmermann@suse.de Cc: Tian Tao tiantao6@hisilicon.com Cc: Maxime Ripard maxime@cerno.tech Cc: Daniel Vetter daniel.vetter@ffwll.ch Cc: Sam Ravnborg sam@ravnborg.org --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c index f73a8e0ea12e..610fc8e135f9 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c @@ -249,7 +249,6 @@ static int hibmc_hw_init(struct hibmc_drm_private *priv)
static int hibmc_unload(struct drm_device *dev) { - struct hibmc_drm_private *priv = to_hibmc_drm_private(dev); struct pci_dev *pdev = to_pci_dev(dev->dev);
drm_atomic_helper_shutdown(dev); -- 2.32.0
dri-devel@lists.freedesktop.org
-
Daniel Vetter -
Thomas Zimmermann -
tiantao (H)