On Wed, 2020-04-08 at 09:37 -0400, Aurabindo Pillai wrote:

amdgpu uses lots of pr_* calls for printing error messages. With this prefix, errors shall be more obvious to the end use regarding its origin, and may help debugging.

Prefix format:

[xxx.xxxxx] amdgpu: ...

[]

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h

[]

@@ -28,6 +28,12 @@ #ifndef __AMDGPU_H__ #define __AMDGPU_H__

+#ifdef pr_fmt +#undef pr_fmt +#endif

+#define pr_fmt(fmt) "amdgpu: " fmt

#include "amdgpu_ctx.h"

#include <linux/atomic.h>

All the embedded uses of "amdgpu:" in logging messages should also be deleted.

$ git grep -P '(?:dev_|pr_).*"amdgpu:' drivers/gpu/drm/amd/amdgpu/ drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: pr_err("amdgpu: failed to validate PT BOs\n"); drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: pr_err("amdgpu: failed to validate PD\n"); drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: pr_err("amdgpu: failed to kmap PD, ret=%d\n", ret); drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: pr_info("amdgpu: switched on\n"); drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: pr_info("amdgpu: switched off\n"); drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c: dev_dbg(adev->dev, "amdgpu: using MSI/MSI-X.\n"); drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c: dev_warn(adev->dev, "amdgpu: No suitable DMA available.\n"); drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c: pr_warn("amdgpu: No suitable DMA available\n"); drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c: pr_warn("amdgpu: No suitable DMA available\n");