From: howl howl.nsp@gmail.com
The (void *) casting in the driver_data variable assignment is superfluous. Spotted by Jani Nikula.
Signed-off-by: David Santamaría Rogado howl.nsp@gmail.com --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 52e445bb1aa5..61d3361381b7 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -86,13 +86,13 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"), }, - .driver_data = (void *)&acer_s1003, + .driver_data = &acer_s1003, }, { /* Asus T100HA */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"), }, - .driver_data = (void *)&asus_t100ha, + .driver_data = &asus_t100ha, }, { /* * GPD Pocket, note that the the DMI data is less generic then * it seems, devices with a board-vendor of "AMI Corporation" @@ -105,7 +105,7 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"), }, - .driver_data = (void *)&gpd_pocket, + .driver_data = &gpd_pocket, }, { /* GPD Win (same note on DMI match as GPD Pocket) */ .matches = { DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"), @@ -113,7 +113,7 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"), }, - .driver_data = (void *)&gpd_win, + .driver_data = &gpd_win, }, { /* GPD Win 2 (too generic strings, also match on bios date) */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"), @@ -121,7 +121,7 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"), DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"), }, - .driver_data = (void *)&gpd_win2, + .driver_data = &gpd_win2, }, { /* I.T.Works TW891 */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."), @@ -129,7 +129,7 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by O.E.M."), DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"), }, - .driver_data = (void *)&itworks_tw891, + .driver_data = &itworks_tw891, }, { /* * Lenovo Ideapad Miix 310 laptop, only some production batches * have a portrait screen, the resolution checks makes the quirk @@ -140,20 +140,20 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"), DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"), }, - .driver_data = (void *)&lcd800x1280_rightside_up, + .driver_data = &lcd800x1280_rightside_up, }, { /* Lenovo Ideapad Miix 320 */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX 320-10ICR"), }, - .driver_data = (void *)&lcd800x1280_rightside_up, + .driver_data = &lcd800x1280_rightside_up, }, { /* VIOS LTH17 */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"), }, - .driver_data = (void *)&lcd800x1280_rightside_up, + .driver_data = &lcd800x1280_rightside_up, }, {} };
From: howl howl.nsp@gmail.com
Lenovo Ideapad D330 Pentium CPU version has 1920x1200 LCD. Console ouput gets rotated at boot as Miix 310.
Signed-off-by: David Santamaría Rogado howl.nsp@gmail.com --- drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 61d3361381b7..835574e2d5bf 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -80,6 +80,12 @@ static const struct drm_dmi_panel_orientation_data lcd800x1280_rightside_up = { .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, };
+static const struct drm_dmi_panel_orientation_data lcd1200x1920_rightside_up = { + .width = 1200, + .height = 1920, + .orientation = DRM_MODE_PANEL_ORIENTATION_RIGHT_UP, +}; + static const struct dmi_system_id orientation_data[] = { { /* Acer One 10 (S1003) */ .matches = { @@ -130,6 +136,13 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"), }, .driver_data = &itworks_tw891, + }, { /* Lenovo Ideapad D330 */ + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "81H3"), + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo ideapad D330-10IGM"), + }, + .driver_data = &lcd1200x1920_rightside_up, }, { /* * Lenovo Ideapad Miix 310 laptop, only some production batches * have a portrait screen, the resolution checks makes the quirk
On Sat, 16 Feb 2019, David Santamaría Rogado howl.nsp@gmail.com wrote:
From: howl howl.nsp@gmail.com
The (void *) casting in the driver_data variable assignment is superfluous. Spotted by Jani Nikula.
Signed-off-by: David Santamaría Rogado howl.nsp@gmail.com
Reviewed-by: Jani Nikula jani.nikula@intel.com
drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 52e445bb1aa5..61d3361381b7 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -86,13 +86,13 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"), },
.driver_data = (void *)&acer_s1003,
.driver_data = &acer_s1003,
.driver_data = (void *)&asus_t100ha,
.driver_data = &asus_t100ha,
- GPD Pocket, note that the the DMI data is less generic then
- it seems, devices with a board-vendor of "AMI Corporation"
@@ -105,7 +105,7 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"), },
.driver_data = (void *)&gpd_pocket,
.driver_data = &gpd_pocket,@@ -113,7 +113,7 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"), },
.driver_data = (void *)&gpd_win,
.driver_data = &gpd_win,@@ -121,7 +121,7 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"), DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"), },
.driver_data = (void *)&gpd_win2,
.driver_data = &gpd_win2,@@ -129,7 +129,7 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by O.E.M."), DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"), },
.driver_data = (void *)&itworks_tw891,
.driver_data = &itworks_tw891,
- Lenovo Ideapad Miix 310 laptop, only some production batches
- have a portrait screen, the resolution checks makes the quirk
@@ -140,20 +140,20 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"), DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"), },
.driver_data = (void *)&lcd800x1280_rightside_up,
.driver_data = &lcd800x1280_rightside_up,
.driver_data = (void *)&lcd800x1280_rightside_up,
.driver_data = &lcd800x1280_rightside_up,
.driver_data = (void *)&lcd800x1280_rightside_up,
.driver_data = &lcd800x1280_rightside_up,};
On Sat, Feb 16, 2019 at 08:58:33PM +0100, David Santamaría Rogado wrote:
From: howl howl.nsp@gmail.com
Any reason why this differs from the Signed-off-by line? Perhaps check your git configuration if this wasn't on purpose. Or perhaps you've fixed the configuration since you authored the commits, in which case you should be able to fix this by doing this:
$ git commit --reset-author --amend
You'd need to run that for each of the commits.
Thierry
The (void *) casting in the driver_data variable assignment is superfluous. Spotted by Jani Nikula.
Signed-off-by: David Santamaría Rogado howl.nsp@gmail.com
drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c index 52e445bb1aa5..61d3361381b7 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -86,13 +86,13 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"), },
.driver_data = (void *)&acer_s1003,
.driver_data = &acer_s1003,
.driver_data = (void *)&asus_t100ha,
.driver_data = &asus_t100ha,
- GPD Pocket, note that the the DMI data is less generic then
- it seems, devices with a board-vendor of "AMI Corporation"
@@ -105,7 +105,7 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"), },
.driver_data = (void *)&gpd_pocket,
.driver_data = &gpd_pocket,@@ -113,7 +113,7 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"), },
.driver_data = (void *)&gpd_win,
.driver_data = &gpd_win,@@ -121,7 +121,7 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"), DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"), },
.driver_data = (void *)&gpd_win2,
.driver_data = &gpd_win2,@@ -129,7 +129,7 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by O.E.M."), DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"), },
.driver_data = (void *)&itworks_tw891,
.driver_data = &itworks_tw891,
- Lenovo Ideapad Miix 310 laptop, only some production batches
- have a portrait screen, the resolution checks makes the quirk
@@ -140,20 +140,20 @@ static const struct dmi_system_id orientation_data[] = { DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"), DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"), },
.driver_data = (void *)&lcd800x1280_rightside_up,
.driver_data = &lcd800x1280_rightside_up,
.driver_data = (void *)&lcd800x1280_rightside_up,
.driver_data = &lcd800x1280_rightside_up,
.driver_data = (void *)&lcd800x1280_rightside_up,
.driver_data = &lcd800x1280_rightside_up,};
2.20.1
I have my mail and real name in git configuration but it has taken my computer's username. I suppose there should be a way to make git to take the real name I have set in it's configuration. Will check it and resend as I won't do ammend cause I have signed of by all public commits as in these patches. Wanted to bring this up at time for 5.0 to have it out of the box in the next Fedora but I suppose is not going to be possible.
Thanks for the guidance you are giving to me.
El lunes, 18 de febrero de 2019, Thierry Reding thierry.reding@gmail.com escribió:
On Sat, Feb 16, 2019 at 08:58:33PM +0100, David Santamaría Rogado wrote:
From: howl howl.nsp@gmail.com
Any reason why this differs from the Signed-off-by line? Perhaps check your git configuration if this wasn't on purpose. Or perhaps you've fixed the configuration since you authored the commits, in which case you should be able to fix this by doing this:
$ git commit --reset-author --amendYou'd need to run that for each of the commits.
Thierry
The (void *) casting in the driver_data variable assignment is
superfluous.
Spotted by Jani Nikula.
Signed-off-by: David Santamaría Rogado howl.nsp@gmail.com
drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c
b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 52e445bb1aa5..61d3361381b7 100644 --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c @@ -86,13 +86,13 @@ static const struct dmi_system_id orientation_data[]
= {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "One S1003"), },
.driver_data = (void *)&acer_s1003,
.driver_data = &acer_s1003, }, { /* Asus T100HA */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "T100HAN"), },
.driver_data = (void *)&asus_t100ha,
.driver_data = &asus_t100ha, }, { /* * GPD Pocket, note that the the DMI data is less generic
then
* it seems, devices with a board-vendor of "AMI
Corporation"
@@ -105,7 +105,7 @@ static const struct dmi_system_id orientation_data[]
= {
DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"), },
.driver_data = (void *)&gpd_pocket,
.driver_data = &gpd_pocket, }, { /* GPD Win (same note on DMI match as GPD Pocket) */ .matches = { DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),@@ -113,7 +113,7 @@ static const struct dmi_system_id orientation_data[]
= {
DMI_EXACT_MATCH(DMI_BOARD_SERIAL, "Default string"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Default string"), },
.driver_data = (void *)&gpd_win,
.driver_data = &gpd_win, }, { /* GPD Win 2 (too generic strings, also match on bios
date) */
.matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Default string"),@@ -121,7 +121,7 @@ static const struct dmi_system_id orientation_data[]
= {
DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"), DMI_EXACT_MATCH(DMI_BOARD_NAME, "Default string"), },
.driver_data = (void *)&gpd_win2,
.driver_data = &gpd_win2, }, { /* I.T.Works TW891 */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by
O.E.M."),
@@ -129,7 +129,7 @@ static const struct dmi_system_id orientation_data[]
= {
DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "To be filled by
O.E.M."),
DMI_EXACT_MATCH(DMI_BOARD_NAME, "TW891"), },
.driver_data = (void *)&itworks_tw891,
.driver_data = &itworks_tw891, }, { /* * Lenovo Ideapad Miix 310 laptop, only some production
batches
* have a portrait screen, the resolution checks makes the
quirk
@@ -140,20 +140,20 @@ static const struct dmi_system_id
orientation_data[] = {
DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80SG"), DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"), },
.driver_data = (void *)&lcd800x1280_rightside_up,
.driver_data = &lcd800x1280_rightside_up, }, { /* Lenovo Ideapad Miix 320 */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "80XF"), DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "Lenovo MIIX
320-10ICR"),
},
.driver_data = (void *)&lcd800x1280_rightside_up,
.driver_data = &lcd800x1280_rightside_up, }, { /* VIOS LTH17 */ .matches = { DMI_EXACT_MATCH(DMI_SYS_VENDOR, "VIOS"), DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"), },
.driver_data = (void *)&lcd800x1280_rightside_up,
.driver_data = &lcd800x1280_rightside_up, }, {}};
2.20.1
dri-devel@lists.freedesktop.org
-
David Santamaría Rogado -
Jani Nikula -
Thierry Reding