On Tue, Feb 19, 2013 at 6:48 PM, Stephen Warren swarren@wwwdotorg.org wrote:

Daniel,

Commit 6aed8ec "drm: review locking for drm_fb_helper_restore_fbdev_mode" (now in next-20130218 and later) causes build failures for tegra_defconfig. The issue is this part of the patch:

You need to yell at Dave Airlie:

https://patchwork.kernel.org/patch/2162391/

Cheers, Daniel

...

diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c index 3742bc9..1b6ba2d 100644 --- a/drivers/gpu/drm/drm_fb_cma_helper.c +++ b/drivers/gpu/drm/drm_fb_cma_helper.c @@ -389,8 +389,10 @@ EXPORT_SYMBOL_GPL(drm_fbdev_cma_fini); */ void drm_fbdev_cma_restore_mode(struct drm_fbdev_cma *fbdev_cma) {

•   drm_modeset_lock_all(dev);
    if (fbdev_cma)
            drm_fb_helper_restore_fbdev_mode(&fbdev_cma->fb_helper);
  

•   drm_modeset_unlock_all(dev);
  

} EXPORT_SYMBOL_GPL(drm_fbdev_cma_restore_mode);

There, there is no "dev" variable, so compile fails.

If I revert this one patch, the build succeeds, although I didn't check whether DRM still works after that (e.g. due to any dependencies from the rest of the series).