Hi

Am 10.06.20 um 13:58 schrieb Colin King:

From: Colin Ian King colin.king@canonical.com

Currently the switch statement for format->cpp[0] value 4 assigns color_index which is never read again and then falls through to the default case and returns. This looks like a missing break statement bug. Fix this by adding a break statement.

Addresses-Coverity: ("Unused value") Fixes: 259d14a76a27 ("drm/ast: Split ast_set_vbios_mode_info()") Signed-off-by: Colin Ian King colin.king@canonical.com

Reviewed-by: Thomas Zimmermann tzimmermann@suse.de

Thanks for the fix. I'll test and merge the patch tomorrow.

Best regards Thomas

---

drivers/gpu/drm/ast/ast_mode.c | 1 + 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c index 7d39b858c9f1..3a3a511670c9 100644 --- a/drivers/gpu/drm/ast/ast_mode.c +++ b/drivers/gpu/drm/ast/ast_mode.c @@ -226,6 +226,7 @@ static void ast_set_vbios_color_reg(struct ast_private *ast, case 3: case 4: color_index = TrueCModeIndex;

• break;
  

  default: return; }