On 2/1/22 07:26, Yang Li wrote:

The print function dev_err() is redundant because platform_get_irq() already prints an error.

Eliminate the follow coccicheck warning: ./drivers/video/fbdev/pxa168fb.c:621:2-9: line 621 is redundant because platform_get_irq() already prints an error

Reported-by: Abaci Robot abaci@linux.alibaba.com Signed-off-by: Yang Li yang.lee@linux.alibaba.com

---

drivers/video/fbdev/pxa168fb.c | 1 - 1 file changed, 1 deletion(-)

diff --git a/drivers/video/fbdev/pxa168fb.c b/drivers/video/fbdev/pxa168fb.c index c25739f6934d..d533c0bf7031 100644 --- a/drivers/video/fbdev/pxa168fb.c +++ b/drivers/video/fbdev/pxa168fb.c @@ -618,7 +618,6 @@ static int pxa168fb_probe(struct platform_device *pdev)

irq = platform_get_irq(pdev, 0); if (irq < 0) {

• dev_err(&pdev->dev, "no IRQ defined\n");
  

  return -ENOENT; }

Please drop the surrounding braces then as well in both of your patches, e.g.

if (irq < 0) return -ENOENT;

Helge