The secondary video layer (VI) on "Allwinner V3s" displays decoded video (YUV) in wrong colors. The secondary CSC should be programmed. Let's correct CSC register offset and extend regmap size.
Regards.
Martin Cerveny (2): drm/sun4i: sun8i-csc: Secondary CSC register correction drm/sun4i: mixer: Extend regmap max_register
drivers/gpu/drm/sun4i/sun8i_csc.h | 2 +- drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
"Allwinner V3s" has secondary video layer (VI). Decoded video is displayed in wrong colors until secondary CSC registers are programmed correctly.
Signed-off-by: Martin Cerveny m.cerveny@computer.org --- drivers/gpu/drm/sun4i/sun8i_csc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun8i_csc.h b/drivers/gpu/drm/sun4i/sun8i_csc.h index f42441b1b14d..a55a38ad849c 100644 --- a/drivers/gpu/drm/sun4i/sun8i_csc.h +++ b/drivers/gpu/drm/sun4i/sun8i_csc.h @@ -12,7 +12,7 @@ struct sun8i_mixer;
/* VI channel CSC units offsets */ #define CCSC00_OFFSET 0xAA050 -#define CCSC01_OFFSET 0xFA000 +#define CCSC01_OFFSET 0xFA050 #define CCSC10_OFFSET 0xA0000 #define CCSC11_OFFSET 0xF0000
Following tag should be added: Fixes: 883029390550 ("drm/sun4i: Add DE2 CSC library")
Reviewed-by: Jernej Skrabec jernej.skrabec@siol.net
Best regards, Jernej
Better guess. Secondary CSC registers are from 0xF0000.
Signed-off-by: Martin Cerveny m.cerveny@computer.org --- drivers/gpu/drm/sun4i/sun8i_mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c index cc4fb916318f..c3304028e3dc 100644 --- a/drivers/gpu/drm/sun4i/sun8i_mixer.c +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c @@ -307,7 +307,7 @@ static struct regmap_config sun8i_mixer_regmap_config = { .reg_bits = 32, .val_bits = 32, .reg_stride = 4, - .max_register = 0xbfffc, /* guessed */ + .max_register = 0xffffc, /* guessed */ };
static int sun8i_mixer_of_get_id(struct device_node *node)
Better guess. Secondary CSC registers are from 0xF0000.
Signed-off-by: Martin Cerveny m.cerveny@computer.org
Reviewed-by: Jernej Skrabec jernej.skrabec@siol.net
Best regards, Jernej
dri-devel@lists.freedesktop.org
-
Jernej Škrabec -
Martin Cerveny -
Maxime Ripard