On Wed, Jul 01, 2015 at 09:18:18PM +0530, Kausal Malladi wrote:

From: Kausal Malladi Kausal.Malladi@intel.com

drm_property_replace_global_blob() is getting used by many wrapper functions to replace an existing blob with new values. Because this function was static, modules are forced to create wrapper functions in same file. Exporting this function will remove need for such wrapper functions.

This patch makes the function drm_property_replace_global_blob() be accessible globally.

Signed-off-by: Shashank Sharma shashank.sharma@intel.com Signed-off-by: Kausal Malladi Kausal.Malladi@intel.com

---

drivers/gpu/drm/drm_crtc.c | 2 +- include/drm/drm_crtc.h | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 5d12ea9..15263a1 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -4458,7 +4458,7 @@ EXPORT_SYMBOL(drm_property_lookup_blob);

• a completely atomic update. The access to path_blob_ptr is protected by the
• caller holding a lock on the connector.

*/ -static int drm_property_replace_global_blob(struct drm_device *dev, +int drm_property_replace_global_blob(struct drm_device *dev, struct drm_property_blob **replace, size_t length, const void *data,

Whether this is a good idea or not, you probably want an EXPORT_SYMBOL().