On Tue, Jul 23, 2019 at 02:20:06PM +0200, Artur Świgoń wrote:

This patch adds a new static function, exynos_bus_profile_init(), extracted from exynos_bus_probe().

Signed-off-by: Artur Świgoń a.swigon@partner.samsung.com

drivers/devfreq/exynos-bus.c | 106 ++++++++++++++++++++--------------- 1 file changed, 60 insertions(+), 46 deletions(-)

diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index d9f377912c10..d8f1efaf2d49 100644 --- a/drivers/devfreq/exynos-bus.c +++ b/drivers/devfreq/exynos-bus.c @@ -372,12 +372,69 @@ static int exynos_bus_parse_of(struct device_node *np, return ret; }

+static int exynos_bus_profile_init(struct exynos_bus *bus,

• 		   struct devfreq_dev_profile *profile)
  

+{

• struct device *dev = bus->dev;
• struct devfreq_simple_ondemand_data *ondemand_data;
• int ret;
• /* Initialize the struct profile and governor data for parent device */
• profile->polling_ms = 50;
• profile->target = exynos_bus_target;
• profile->get_dev_status = exynos_bus_get_dev_status;
• profile->exit = exynos_bus_exit;
• ondemand_data = devm_kzalloc(dev, sizeof(*ondemand_data), GFP_KERNEL);
• if (!ondemand_data) {

• ret = -ENOMEM;
  

• goto err;
  

Just return proper error code. Less lines, obvious code since you do not have any cleanup in error path.

• }
• ondemand_data->upthreshold = 40;
• ondemand_data->downdifferential = 5;
• /* Add devfreq device to monitor and handle the exynos bus */
• bus->devfreq = devm_devfreq_add_device(dev, profile,

• 				DEVFREQ_GOV_SIMPLE_ONDEMAND,
  

• 				ondemand_data);
  

• if (IS_ERR(bus->devfreq)) {

• dev_err(dev, "failed to add devfreq device\n");
  

• ret = PTR_ERR(bus->devfreq);
  

• goto err;
  

• }
• /* Register opp_notifier to catch the change of OPP */
• ret = devm_devfreq_register_opp_notifier(dev, bus->devfreq);
• if (ret < 0) {

• dev_err(dev, "failed to register opp notifier\n");
  

• goto err;
  

The same - return err.

Best regards, Krzysztof