Second version of patch-set that adds support for EDT ETM043080DH6-GP. This is a 480x272 TFT Display with capacitive touchscreen and it is compatible with the simple panel driver.
We have tested it with our iWave-G22D Generic SODIMM Development Board.
In v2, after Sam Ravnborg's review, I've rebased the patches against drm-misc-next and modified the proper bindings file for the simple panels.
I have also added the mandatory connector-type field and corrected the bus type as it is a 18bbp, therefore an RGB666.
Unfortunately, we do not have access to the datasheet, therefore we could not use the display_timings format.
Marian-Cristian Rotariu (2): dt-bindings: display: Add bindings for EDT panel drm/panel: simple: Add EDT panel support
.../bindings/display/panel/panel-simple.yaml | 2 ++ drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++ 2 files changed, 36 insertions(+)
Document the Emerging Display Technology Corp. (EDT) ETM043080DH6-GP display, which is a 480x272 4.3" TFT display with capacitive touchscreen.
Changes in v2: -modify proper bindings file
Signed-off-by: Marian-Cristian Rotariu marian-cristian.rotariu.rb@bp.renesas.com Reviewed-by: Lad Prabhakar prabhakar.mahadev-lad.rj@bp.renesas.com --- Documentation/devicetree/bindings/display/panel/panel-simple.yaml | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml index bdf4d0b..cf23b0a 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml @@ -89,6 +89,8 @@ properties: - dlc,dlc1010gig # Emerging Display Technology Corp. 3.5" QVGA TFT LCD panel - edt,et035012dm6 + # Emerging Display Technology Corp. 480x272 TFT Display with capacitive touch + - edt,etm043080dh6gp # Emerging Display Technology Corp. 480x272 TFT Display - edt,etm0430g0dh6 # Emerging Display Technology Corp. 5.7" VGA TFT LCD panel
EDT ET043080DH6-GP is a 4.3" WQVGA 480x272 RGB LCD panel used on the iWave Generic SODIMM Development Platform.
Changes in v2: -added mandatory .connector_type field -changed the .bus_format MEDIA_BUS_FMT_RGB666_1X18
Signed-off-by: Marian-Cristian Rotariu marian-cristian.rotariu.rb@bp.renesas.com Reviewed-by: Lad Prabhakar prabhakar.mahadev-lad.rj@bp.renesas.com --- drivers/gpu/drm/panel/panel-simple.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index a0dd84e..b8e0d88e 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1301,6 +1301,37 @@ static const struct panel_desc edt_et035012dm6 = { .bus_flags = DRM_BUS_FLAG_DE_LOW | DRM_BUS_FLAG_PIXDATA_NEGEDGE, };
+static const struct drm_display_mode edt_etm043080dh6gp_mode = { + .clock = 10870, + .hdisplay = 480, + .hsync_start = 480 + 8, + .hsync_end = 480 + 8 + 4, + .htotal = 480 + 8 + 4 + 41, + + /* + * IWG22M: Y resolution changed for "dc_linuxfb" module crashing while + * fb_align + */ + + .vdisplay = 288, + .vsync_start = 288 + 2, + .vsync_end = 288 + 2 + 4, + .vtotal = 288 + 2 + 4 + 10, + .vrefresh = 60, +}; + +static const struct panel_desc edt_etm043080dh6gp = { + .modes = &edt_etm043080dh6gp_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 100, + .height = 65, + }, + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, + .connector_type = DRM_MODE_CONNECTOR_DPI, +}; + static const struct drm_display_mode edt_etm0430g0dh6_mode = { .clock = 9000, .hdisplay = 480, @@ -3371,6 +3402,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "edt,et035012dm6", .data = &edt_et035012dm6, }, { + .compatible = "edt,etm043080dh6gp", + .data = &edt_etm043080dh6gp, + }, { .compatible = "edt,etm0430g0dh6", .data = &edt_etm0430g0dh6, }, {
Hi Marian-Christian.
Thanks for the quick reponse. On Thu, Jan 30, 2020 at 12:08:36PM +0000, Marian-Cristian Rotariu wrote:
Second version of patch-set that adds support for EDT ETM043080DH6-GP. This is a 480x272 TFT Display with capacitive touchscreen and it is compatible with the simple panel driver.
We have tested it with our iWave-G22D Generic SODIMM Development Board.
In v2, after Sam Ravnborg's review, I've rebased the patches against drm-misc-next and modified the proper bindings file for the simple panels.
I have also added the mandatory connector-type field and corrected the bus type as it is a 18bbp, therefore an RGB666.
Unfortunately, we do not have access to the datasheet, therefore we could not use the display_timings format.
Marian-Cristian Rotariu (2): dt-bindings: display: Add bindings for EDT panel drm/panel: simple: Add EDT panel support
Applied to drm-misc-next and pushed out. Note: Will hit next merge window, as it is too late for the current merge window.
Sam
dri-devel@lists.freedesktop.org
-
Marian-Cristian Rotariu -
Sam Ravnborg