https://bugs.freedesktop.org/show_bug.cgi?id=95285

--- Comment #2 from Ilia Mirkin imirkin@alum.mit.edu --- Try some of Ken's patches at

https://cgit.freedesktop.org/~kwg/mesa/log/?h=tombraider-2

There are some issues which tressfx happens to hit. (And some other option too...) However at least on nouveau, tressfx is still a fail even with those. [Sorry, don't have the game myself, so don't have further details. Just an FYI with the current state of affairs.]

https://bugs.freedesktop.org/show_bug.cgi?id=95285

Kai kai@dev.carbon-project.org changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |kenneth@whitecape.org

--- Comment #4 from Kai kai@dev.carbon-project.org --- (In reply to Ilia Mirkin from comment #2)

Try some of Ken's patches at

https://cgit.freedesktop.org/~kwg/mesa/log/?h=tombraider-2

Thanks for the pointer, Ilia! I've applied the following patches: fb4f8f9 glsl: Make opt_constant_variable() bail in useless cases. a6bebce glsl: Remove bonus tree walking in opt_constant_folding(). b01114f glsl: Consolidate duplicate copies of constant folding. 2040a80 glsl: Avoid excess tree walking when folding ir_dereference_arrays. 285e966 glsl: Don't do constant propagation in opt_constant_folding. 862fb32 glsl: Make lower_const_arrays_to_uniforms work directly on constants. 341ee51 glsl: Don't constant propagate arrays

Additionally, I think I should mention, that I've applied https://patchwork.freedesktop.org/patch/85101/ locally, since I'm using a LLVM > 268259. Just in case that could have an impact.

Anyway, with those patches applied the game freezes the system (ie. the system stops responding to any kind of input) while entering the main menu. The only output I could capture was "[0505/185411:WARNING:x11_util.cc(1490)] X error received: serial 1001, error_code 3 (BadWindow (invalid Window parameter)), request_code 4, minor_code 0 (X_DestroyWindow)" CCing Kenneth, maybe he has an idea which of his patches could cause this.

There are some issues which tressfx happens to hit. (And some other option too...)

Do you mean bug 95190 or something else? I'm seeing bug 95190 as well. Therefore I've kept post processing disabled so far.

However at least on nouveau, tressfx is still a fail even with those. [Sorry, don't have the game myself, so don't have further details. Just an FYI with the current state of affairs.]

No need to apologize! Any piece of information is appreciated. As far as access to TR goes: did you try contacting Feral? They were willing to give access to XCOM 2 to some Mesa developers IIRC, maybe they're willing to do the same here?

(In reply to Nicolai Hähnle from comment #3)

If the patches mentioned by Ilia don't help, an apitrace showing the problem would be useful.

Ok, I'll do that.

https://bugs.freedesktop.org/show_bug.cgi?id=95285

Kai kai@dev.carbon-project.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |NOTOURBUG Status|NEW |RESOLVED

--- Comment #6 from Kai kai@dev.carbon-project.org --- Ok, I did one last test. I only set "MESA_GLSL_VERSION_OVERRIDE=430" (notice the missing override for MESA_GL_VERSION_OVERRIDE in comparison to comment #0). When launched this way, TressFX works (at least in the benchmark, I used to check this and to produce the trace from comment #5)!

I'm closing this bug as NOTOURBUG as it seems the game is using functionality, when the TressFX option is enabled, it should only use when GLSL 4.30 is available. Or put differently: it shouldn't offer TressFX unless GLSL 4.30 is available, ie. this is a game bug.

The launcher problem described in comment #0 seems to stem from the fact, that MESA_GL_VERSION_OVERRIDE also overrides the compatibility profile version as well and the launcher then uses that instead of a core profile. While forcing GLSL to 4.30 only enables 4.3 in the core profile.