One of the two local variables old_crtc_state is redundantly defined in the function disable_outputs(). It has only a scope partway through the block for_each_connector_in_state. So, let's remove it and use the one which has the scope within the function disable_outputs().
Signed-off-by: Liu Ying gnuiyl@gmail.com --- drivers/gpu/drm/drm_atomic_helper.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 57cccd6..b9d8b53 100644 --- a/drivers/gpu/drm/drm_atomic_helper.c +++ b/drivers/gpu/drm/drm_atomic_helper.c @@ -617,7 +617,6 @@ disable_outputs(struct drm_device *dev, struct drm_atomic_state *old_state) for_each_connector_in_state(old_state, connector, old_conn_state, i) { const struct drm_encoder_helper_funcs *funcs; struct drm_encoder *encoder; - struct drm_crtc_state *old_crtc_state;
/* Shut down everything that's in the changeset and currently * still on. So need to check the old, saved state. */
On Mon, Jan 18, 2016 at 11:36:35AM +0800, Liu Ying wrote:
Applied to drm-misc, thanks. -Daniel
dri-devel@lists.freedesktop.org
-
Daniel Vetter -
Liu Ying