This patch-set convert 3 of the remaining panel bindings to yaml.
This is a follow-up on v2 that converted a lot of panel bindings: https://lore.kernel.org/dri-devel/20200408195109.32692-1-sam@ravnborg.org/ All was applied except for the reaming three patches included here.
One binding is a DSI binding so just added to panel-simple-dsi. The other two bindings addressed review feedback from Rob.
Sebastian Reichel has a pending patch to address the remaining panel binding in display/panel/
All bindings pass dt-binding-check. Based on top of drm-misc-next.
Sam
Sam Ravnborg (3): dt-bindings: display: convert innolux,p079zca to DT Schema dt-bindings: display: convert samsung,s6e8aa0 to DT Schema dt-bindings: display: convert sharp,lq101r1sx01 to DT Schema
.../bindings/display/panel/innolux,p079zca.txt | 22 ----- .../bindings/display/panel/panel-simple-dsi.yaml | 2 + .../bindings/display/panel/samsung,s6e8aa0.txt | 56 ------------ .../bindings/display/panel/samsung,s6e8aa0.yaml | 100 +++++++++++++++++++++ .../bindings/display/panel/sharp,lq101r1sx01.txt | 49 ---------- .../bindings/display/panel/sharp,lq101r1sx01.yaml | 87 ++++++++++++++++++ 6 files changed, 189 insertions(+), 127 deletions(-)
As the binding matches panel-simple-dsi, added the compatible to the panel-simple-dsi list. With this change enable-gpios is now optional.
v2: - It is a DSI panel, add it to panel-simple-dsi (Rob)
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Rob Herring robh@kernel.org Cc: Chris Zhong zyw@rock-chips.com Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org --- .../display/panel/innolux,p079zca.txt | 22 ------------------- .../display/panel/panel-simple-dsi.yaml | 2 ++ 2 files changed, 2 insertions(+), 22 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt
diff --git a/Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt b/Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt deleted file mode 100644 index 3ab8c7412cf6..000000000000 --- a/Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt +++ /dev/null @@ -1,22 +0,0 @@ -Innolux P079ZCA 7.85" 768x1024 TFT LCD panel - -Required properties: -- compatible: should be "innolux,p079zca" -- reg: DSI virtual channel of the peripheral -- power-supply: phandle of the regulator that provides the supply voltage -- enable-gpios: panel enable gpio - -Optional properties: -- backlight: phandle of the backlight device attached to the panel - -Example: - - &mipi_dsi { - panel@0 { - compatible = "innolux,p079zca"; - reg = <0>; - power-supply = <...>; - backlight = <&backlight>; - enable-gpios = <&gpio1 13 GPIO_ACTIVE_HIGH>; - }; - }; diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml index 16778ce782fc..c0dd9fa29f1d 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yaml @@ -33,6 +33,8 @@ properties: - auo,b080uan01 # Boe Corporation 8.0" WUXGA TFT LCD panel - boe,tv080wum-nl0 + # Innolux P079ZCA 7.85" 768x1024 TFT LCD panel + - innolux,p079zca # Kingdisplay KD097D04 9.7" 1536x2048 TFT LCD panel - kingdisplay,kd097d04 # LG ACX467AKM-7 4.95" 1080×1920 LCD Panel
On Sat, 04 Jul 2020 12:28:04 +0200, Sam Ravnborg wrote:
As the binding matches panel-simple-dsi, added the compatible to the panel-simple-dsi list. With this change enable-gpios is now optional.
v2:
- It is a DSI panel, add it to panel-simple-dsi (Rob)
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Rob Herring robh@kernel.org Cc: Chris Zhong zyw@rock-chips.com Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org
.../display/panel/innolux,p079zca.txt | 22 ------------------- .../display/panel/panel-simple-dsi.yaml | 2 ++ 2 files changed, 2 insertions(+), 22 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/panel/innolux,p079zca.txt
Reviewed-by: Rob Herring robh@kernel.org
v2: - Add missing types (Rob) - Fix example to specify panel@0 (Rob)
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Rob Herring robh@kernel.org Cc: Andrzej Hajda a.hajda@samsung.com Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org --- .../display/panel/samsung,s6e8aa0.txt | 56 ---------- .../display/panel/samsung,s6e8aa0.yaml | 100 ++++++++++++++++++ 2 files changed, 100 insertions(+), 56 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.txt create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.txt b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.txt deleted file mode 100644 index 9e766c5f86da..000000000000 --- a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.txt +++ /dev/null @@ -1,56 +0,0 @@ -Samsung S6E8AA0 AMOLED LCD 5.3 inch panel - -Required properties: - - compatible: "samsung,s6e8aa0" - - reg: the virtual channel number of a DSI peripheral - - vdd3-supply: core voltage supply - - vci-supply: voltage supply for analog circuits - - reset-gpios: a GPIO spec for the reset pin - - display-timings: timings for the connected panel as described by [1] - -Optional properties: - - power-on-delay: delay after turning regulators on [ms] - - reset-delay: delay after reset sequence [ms] - - init-delay: delay after initialization sequence [ms] - - panel-width-mm: physical panel width [mm] - - panel-height-mm: physical panel height [mm] - - flip-horizontal: boolean to flip image horizontally - - flip-vertical: boolean to flip image vertically - -The device node can contain one 'port' child node with one child -'endpoint' node, according to the bindings defined in [2]. This -node should describe panel's video bus. - -[1]: Documentation/devicetree/bindings/display/panel/display-timing.txt -[2]: Documentation/devicetree/bindings/media/video-interfaces.txt - -Example: - - panel { - compatible = "samsung,s6e8aa0"; - reg = <0>; - vdd3-supply = <&vcclcd_reg>; - vci-supply = <&vlcd_reg>; - reset-gpios = <&gpy4 5 0>; - power-on-delay= <50>; - reset-delay = <100>; - init-delay = <100>; - panel-width-mm = <58>; - panel-height-mm = <103>; - flip-horizontal; - flip-vertical; - - display-timings { - timing0: timing-0 { - clock-frequency = <57153600>; - hactive = <720>; - vactive = <1280>; - hfront-porch = <5>; - hback-porch = <5>; - hsync-len = <5>; - vfront-porch = <13>; - vback-porch = <1>; - vsync-len = <2>; - }; - }; - }; diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml new file mode 100644 index 000000000000..f155074726d2 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml @@ -0,0 +1,100 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/samsung,s6e8aa0.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung S6E8AA0 AMOLED LCD 5.3 inch panel + +maintainers: + - Andrzej Hajda a.hajda@samsung.com + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: samsung,s6e8aa0 + + reg: true + reset-gpios: true + display-timings: true + + vdd3-supply: + description: core voltage supply + + vci-supply: + description: voltage supply for analog circuits + + power-on-delay: + description: delay after turning regulators on [ms] + $ref: /schemas/types.yaml#/definitions/uint32 + + reset-delay: + description: delay after reset sequence [ms] + $ref: /schemas/types.yaml#/definitions/uint32 + + init-delay: + description: delay after initialization sequence [ms] + + panel-width-mm: + description: physical panel width [mm] + + panel-height-mm: + description: physical panel height [mm] + + flip-horizontal: + description: boolean to flip image horizontally + type: boolean + + flip-vertical: + description: boolean to flip image vertically + type: boolean + +required: + - compatible + - reg + - vdd3-supply + - vci-supply + - reset-gpios + - display-timings + +additionalProperties: false + +examples: + - | + dsi { + #address-cells = <1>; + #size-cells = <0>; + + panel@0 { + compatible = "samsung,s6e8aa0"; + reg = <0>; + vdd3-supply = <&vcclcd_reg>; + vci-supply = <&vlcd_reg>; + reset-gpios = <&gpy4 5 0>; + power-on-delay= <50>; + reset-delay = <100>; + init-delay = <100>; + panel-width-mm = <58>; + panel-height-mm = <103>; + flip-horizontal; + flip-vertical; + + display-timings { + timing0: timing-0 { + clock-frequency = <57153600>; + hactive = <720>; + vactive = <1280>; + hfront-porch = <5>; + hback-porch = <5>; + hsync-len = <5>; + vfront-porch = <13>; + vback-porch = <1>; + vsync-len = <2>; + }; + }; + }; + }; + +...
On Sat, 04 Jul 2020 12:28:05 +0200, Sam Ravnborg wrote:
v2:
- Add missing types (Rob)
- Fix example to specify panel@0 (Rob)
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Rob Herring robh@kernel.org Cc: Andrzej Hajda a.hajda@samsung.com Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org
.../display/panel/samsung,s6e8aa0.txt | 56 ---------- .../display/panel/samsung,s6e8aa0.yaml | 100 ++++++++++++++++++ 2 files changed, 100 insertions(+), 56 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.txt create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml
Reviewed-by: Rob Herring robh@kernel.org
This binding describes a panel with a secondary channel.
v3: - Add reg property and unit-address to dsi nodes (Rob)
v2: - add check for required properties if link2 is present (Rob)
Signed-off-by: Sam Ravnborg sam@ravnborg.org Reviewed-by: Rob Herring robh@kernel.org Cc: Rob Herring robh@kernel.org Cc: Thierry Reding thierry.reding@gmail.com Cc: Sam Ravnborg sam@ravnborg.org --- .../display/panel/sharp,lq101r1sx01.txt | 49 ----------- .../display/panel/sharp,lq101r1sx01.yaml | 87 +++++++++++++++++++ 2 files changed, 87 insertions(+), 49 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.txt create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.txt deleted file mode 100644 index f522bb8e47e1..000000000000 --- a/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.txt +++ /dev/null @@ -1,49 +0,0 @@ -Sharp Microelectronics 10.1" WQXGA TFT LCD panel - -This panel requires a dual-channel DSI host to operate. It supports two modes: -- left-right: each channel drives the left or right half of the screen -- even-odd: each channel drives the even or odd lines of the screen - -Each of the DSI channels controls a separate DSI peripheral. The peripheral -driven by the first link (DSI-LINK1), left or even, is considered the primary -peripheral and controls the device. The 'link2' property contains a phandle -to the peripheral driven by the second link (DSI-LINK2, right or odd). - -Note that in video mode the DSI-LINK1 interface always provides the left/even -pixels and DSI-LINK2 always provides the right/odd pixels. In command mode it -is possible to program either link to drive the left/even or right/odd pixels -but for the sake of consistency this binding assumes that the same assignment -is chosen as for video mode. - -Required properties: -- compatible: should be "sharp,lq101r1sx01" -- reg: DSI virtual channel of the peripheral - -Required properties (for DSI-LINK1 only): -- link2: phandle to the DSI peripheral on the secondary link. Note that the - presence of this property marks the containing node as DSI-LINK1. -- power-supply: phandle of the regulator that provides the supply voltage - -Optional properties (for DSI-LINK1 only): -- backlight: phandle of the backlight device attached to the panel - -Example: - - dsi@54300000 { - panel: panel@0 { - compatible = "sharp,lq101r1sx01"; - reg = <0>; - - link2 = <&secondary>; - - power-supply = <...>; - backlight = <...>; - }; - }; - - dsi@54400000 { - secondary: panel@0 { - compatible = "sharp,lq101r1sx01"; - reg = <0>; - }; - }; diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml b/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml new file mode 100644 index 000000000000..a679d3647dbd --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq101r1sx01.yaml @@ -0,0 +1,87 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/sharp,lq101r1sx01.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sharp Microelectronics 10.1" WQXGA TFT LCD panel + +maintainers: + - Thierry Reding treding@nvidia.com + +description: | + This panel requires a dual-channel DSI host to operate. It supports two modes: + - left-right: each channel drives the left or right half of the screen + - even-odd: each channel drives the even or odd lines of the screen + + Each of the DSI channels controls a separate DSI peripheral. The peripheral + driven by the first link (DSI-LINK1), left or even, is considered the primary + peripheral and controls the device. The 'link2' property contains a phandle + to the peripheral driven by the second link (DSI-LINK2, right or odd). + + Note that in video mode the DSI-LINK1 interface always provides the left/even + pixels and DSI-LINK2 always provides the right/odd pixels. In command mode it + is possible to program either link to drive the left/even or right/odd pixels + but for the sake of consistency this binding assumes that the same assignment + is chosen as for video mode. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: sharp,lq101r1sx01 + + reg: true + power-supply: true + backlight: true + + link2: + $ref: /schemas/types.yaml#/definitions/phandle + description: | + phandle to the DSI peripheral on the secondary link. Note that the + presence of this property marks the containing node as DSI-LINK1 + +required: + - compatible + - reg + +if: + required: + - link2 +then: + required: + - power-supply + +additionalProperties: false + +examples: + - | + dsi0: dsi@fd922800 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0xfd922800 0x200>; + + panel: panel@0 { + compatible = "sharp,lq101r1sx01"; + reg = <0>; + + link2 = <&secondary>; + + power-supply = <&power>; + backlight = <&backlight>; + }; + }; + + dsi1: dsi@fd922a00 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0xfd922a00 0x200>; + + secondary: panel@0 { + compatible = "sharp,lq101r1sx01"; + reg = <0>; + }; + }; + +...
On Sat, Jul 04, 2020 at 12:28:03PM +0200, Sam Ravnborg wrote:
This patch-set convert 3 of the remaining panel bindings to yaml.
This is a follow-up on v2 that converted a lot of panel bindings: https://lore.kernel.org/dri-devel/20200408195109.32692-1-sam@ravnborg.org/ All was applied except for the reaming three patches included here.
One binding is a DSI binding so just added to panel-simple-dsi. The other two bindings addressed review feedback from Rob.
Sebastian Reichel has a pending patch to address the remaining panel binding in display/panel/
All bindings pass dt-binding-check. Based on top of drm-misc-next.
Sam
Sam Ravnborg (3): dt-bindings: display: convert innolux,p079zca to DT Schema dt-bindings: display: convert samsung,s6e8aa0 to DT Schema dt-bindings: display: convert sharp,lq101r1sx01 to DT Schema
git format-patch adds a space after the ',' - in the subject. This is often a good idea, but not for binding files. Will fix when I apply - if I do not forget that is..
Any setttings so I can prevent this in the future?
Sam
.../bindings/display/panel/innolux,p079zca.txt | 22 ----- .../bindings/display/panel/panel-simple-dsi.yaml | 2 + .../bindings/display/panel/samsung,s6e8aa0.txt | 56 ------------ .../bindings/display/panel/samsung,s6e8aa0.yaml | 100 +++++++++++++++++++++ .../bindings/display/panel/sharp,lq101r1sx01.txt | 49 ---------- .../bindings/display/panel/sharp,lq101r1sx01.yaml | 87 ++++++++++++++++++ 6 files changed, 189 insertions(+), 127 deletions(-)
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
On Sat, Jul 04, 2020 at 12:34:08PM +0200, Sam Ravnborg wrote:
On Sat, Jul 04, 2020 at 12:28:03PM +0200, Sam Ravnborg wrote:
This patch-set convert 3 of the remaining panel bindings to yaml.
This is a follow-up on v2 that converted a lot of panel bindings: https://lore.kernel.org/dri-devel/20200408195109.32692-1-sam@ravnborg.org/ All was applied except for the reaming three patches included here.
One binding is a DSI binding so just added to panel-simple-dsi. The other two bindings addressed review feedback from Rob.
Sebastian Reichel has a pending patch to address the remaining panel binding in display/panel/
All bindings pass dt-binding-check. Based on top of drm-misc-next.
Sam
Sam Ravnborg (3): dt-bindings: display: convert innolux,p079zca to DT Schema dt-bindings: display: convert samsung,s6e8aa0 to DT Schema dt-bindings: display: convert sharp,lq101r1sx01 to DT Schema
git format-patch adds a space after the ',' - in the subject. This is often a good idea, but not for binding files. Will fix when I apply - if I do not forget that is..
Sure about that? I'm pretty sure it's dri-devel doing it. Look at lore.kernel.org copies for different lists. I've been fighting with that first in patchwork (which had this bug) and then in b4 (which is where it got nailed down to dri-devel).
Rob
Hi Rob.
On Sat, Jul 04, 2020 at 12:28:03PM +0200, Sam Ravnborg wrote:
This patch-set convert 3 of the remaining panel bindings to yaml.
This is a follow-up on v2 that converted a lot of panel bindings: https://lore.kernel.org/dri-devel/20200408195109.32692-1-sam@ravnborg.org/ All was applied except for the reaming three patches included here.
One binding is a DSI binding so just added to panel-simple-dsi. The other two bindings addressed review feedback from Rob.
Sebastian Reichel has a pending patch to address the remaining panel binding in display/panel/
All bindings pass dt-binding-check. Based on top of drm-misc-next.
Sam
Sam Ravnborg (3): dt-bindings: display: convert innolux,p079zca to DT Schema dt-bindings: display: convert samsung,s6e8aa0 to DT Schema dt-bindings: display: convert sharp,lq101r1sx01 to DT Schema
git format-patch adds a space after the ',' - in the subject. This is often a good idea, but not for binding files. Will fix when I apply - if I do not forget that is..
Sure about that? I'm pretty sure it's dri-devel doing it. Look at lore.kernel.org copies for different lists. I've been fighting with that first in patchwork (which had this bug) and then in b4 (which is where it got nailed down to dri-devel).
You are right.
The patches that I copied myself on had the correct subject. Only the dri-devel mails had the mangled subject.
Sam
Rob
On Sat, Jul 04, 2020 at 12:28:03PM +0200, Sam Ravnborg wrote:
This patch-set convert 3 of the remaining panel bindings to yaml.
This is a follow-up on v2 that converted a lot of panel bindings: https://lore.kernel.org/dri-devel/20200408195109.32692-1-sam@ravnborg.org/ All was applied except for the reaming three patches included here.
One binding is a DSI binding so just added to panel-simple-dsi. The other two bindings addressed review feedback from Rob.
Sebastian Reichel has a pending patch to address the remaining panel binding in display/panel/
All bindings pass dt-binding-check. Based on top of drm-misc-next.
Sam
Sam Ravnborg (3): dt-bindings: display: convert innolux,p079zca to DT Schema dt-bindings: display: convert samsung,s6e8aa0 to DT Schema dt-bindings: display: convert sharp,lq101r1sx01 to DT Schema
All applied to drm-misc-next.
Sam
.../bindings/display/panel/innolux,p079zca.txt | 22 ----- .../bindings/display/panel/panel-simple-dsi.yaml | 2 + .../bindings/display/panel/samsung,s6e8aa0.txt | 56 ------------ .../bindings/display/panel/samsung,s6e8aa0.yaml | 100 +++++++++++++++++++++ .../bindings/display/panel/sharp,lq101r1sx01.txt | 49 ---------- .../bindings/display/panel/sharp,lq101r1sx01.yaml | 87 ++++++++++++++++++ 6 files changed, 189 insertions(+), 127 deletions(-)
dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
dri-devel@lists.freedesktop.org